Skip to content

fix(trim-paths)!: remove default scope from release profile - #17424

Merged
epage merged 2 commits into
rust-lang:masterfrom
weihanglo:trim-path-release
Sep 2, 2026
Merged

fix(trim-paths)!: remove default scope from release profile#17424
epage merged 2 commits into
rust-lang:masterfrom
weihanglo:trim-path-release

Conversation

@weihanglo

Copy link
Copy Markdown
Member

What does this PR try to resolve?

This is a stabilization preparation.
A saner default is still wanted in the future maybe in a new edition.

See #12137 (comment)

@weihanglo weihanglo added the Z-trim-paths Nightly: path sanitization label Sep 2, 2026
@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation A-profiles Area: profiles labels Sep 2, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2026
@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo

This is a stabilization preparation.
A saner default is still wanted in the future maybe in a new edition.
@epage
epage added this pull request to the merge queue Sep 2, 2026
@epage

epage commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Note that profiles are config or workspace scoped and Editions are generally not able to impact them.

Merged via the queue into rust-lang:master with commit aa45f72 Sep 2, 2026
28 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2026
@weihanglo
weihanglo deleted the trim-path-release branch September 2, 2026 15:24
@weihanglo

Copy link
Copy Markdown
Member Author

Note that profiles are config or workspace scoped and Editions are generally not able to impact them.

Hmm… good point. That make the transition a bit harder. As we have plans to change the default for the dev profile, I wonder if we should do a similar thing for release. Or we can document that Cargo's builtin profiles are subject to (some tiny) change. Granted, trim-paths deals with release profile, which may impacts production grade binaries, so harder to justify a breaking change.

@epage

epage commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

We've made profile changes before. I think the question is what would be broken and how bad.

pull Bot pushed a commit to Mattlk13/cargo that referenced this pull request Sep 2, 2026
### What does this PR try to resolve?

This doc polish is a stabilization preparation.

See
<rust-lang#12137 (comment)>

### How to test and review this PR?

This is stacked on top of
<rust-lang#17424> to minimize merge
conflict. Please review from c99bbf2

```
mdbook serve doc/book
```
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 2, 2026
Update cargo submodule



26 commits in e8cb624d5701824f46a2ec5873cfd59ee3d2f66c..b2e9d5f9db3fb1c454ab84f10c16508984a266e2
2026-08-22 00:23:45 +0000 to 2026-09-02 14:49:16 +0000
- fix(parser): Resolve theoretical use-after-free (rust-lang/cargo#17428)
- fix(trim-paths)!: remove default scope from release profile (rust-lang/cargo#17424)
- fix(git): Use git's 429 retry, when available (rust-lang/cargo#17422)
- Avoid passing search path (-L) args when they are passed as --extern (rust-lang/cargo#17410)
- chore(deps): update crate-ci/typos action to v1.50.0 (rust-lang/cargo#17417)
- test: Move -Z onto its own line (rust-lang/cargo#17416)
- chore(triagebot): enable `@rustbot merge/delegate` (rust-lang/cargo#17415)
- Micro-optimize two package dir functions (rust-lang/cargo#17413)
- perf: Do not build SBOM if user has not set build.sbom (rust-lang/cargo#17412)
- feat(manifest)!: implement feature-metadata RFC3416 (rust-lang/cargo#15056)
- Cargo profiling improvements (rust-lang/cargo#17411)
- test(git): Remove gix override run in CI and the mode in code (rust-lang/cargo#17405)
- perf(git): Reduce extra work when using git-cli (rust-lang/cargo#17406)
- feat(resolver): Stabilize min-publish-age (rust-lang/cargo#17335)
- fix(git): Remove ref status update when showing progress  (rust-lang/cargo#17400)
- revert: refactor: move sysroot lookup to GlobalContext (rust-lang/cargo#17401)
- fix(run): Printing a new line to avoid overwriting error code after \r (rust-lang/cargo#17373)
- fix(trim-paths): custom workspace-relative member paths remap (rust-lang/cargo#17366)
- fix(home): rustdoc lint (rust-lang/cargo#17394)
- feat(diag): Stabilize cargo-lints  (rust-lang/cargo#17298)
- chore(deps): Update partial_ref to v0.3.4 (rust-lang/cargo#17392)
- refactor: remove ad-hoc `subslice_range` (rust-lang/cargo#17390)
- docs(changelog): move build-dir new layout to Changed (rust-lang/cargo#17387)
- chore(deps): update msrv (1 version) to v1.98 (rust-lang/cargo#17386)
- docs: Use mdbook admonitions (rust-lang/cargo#17384)
- chore(ci): exclude resolver-tests from intra doc link checks (rust-lang/cargo#17385)
@rustbot rustbot added this to the 1.100.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-documenting-cargo-itself Area: Cargo's documentation A-profiles Area: profiles Z-trim-paths Nightly: path sanitization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants