revert: refactor: move sysroot lookup to GlobalContext - #17401
Merged
epage merged 3 commits intoAug 27, 2026
Conversation
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-cache-messages
epage
approved these changes
Aug 27, 2026
Member
|
The PR was added in 1.99 already, so @rustbot label beta-nominated |
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR fixes #17351 by reverting the offending #17276. It should be backported to beta.
We tried to address the issues in #17393 but found that the situation was more complex than we thought, and I'll go another route to make the changes I need.
This PR did not revert cleanly, and there were merge conflicts in the 2nd commit in
trim_paths.rs.How to test and review this PR?
Compare with the reverted PR.