docs(trim-paths): add limitations and polish - #17425
Merged
Merged
Conversation
rustbot
added
A-documenting-cargo-itself
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
cc @Urgau, if you'd also like to take a look. I generally want to mostly refer to rustc docs 😆. |
epage
reviewed
Sep 2, 2026
weihanglo
force-pushed
the
trim-paths-docs
branch
from
September 2, 2026 14:55
6a4abd9 to
f4b56c6
Compare
This comment has been minimized.
This comment has been minimized.
epage
approved these changes
Sep 2, 2026
Urgau
reviewed
Sep 2, 2026
Comment on lines
1520
to
1527
| It takes the following values: | ||
|
|
||
| - `"none"` and `false` --- disable path sanitization | ||
| - `"macro"` --- sanitize paths in the expansion of `std::file!()` macro. | ||
| This is where paths in embedded panic messages come from | ||
| - `"diagnostics"` --- sanitize paths in printed compiler diagnostics | ||
| - `"object"` --- sanitize paths in compiled executables or libraries | ||
| - `"all"` and `true` --- sanitize paths in all possible locations |
Member
There was a problem hiding this comment.
I don't know if this list is intended to be the same as rustc, but if it's the case then it's missing the coverage and debuginfo scopes. If it's intended to diverge, it should maybe be mentioned that it's only a subset.
Member
Author
There was a problem hiding this comment.
Good point. I avoided touching this right now at this moment as we may want to stabilize a subset.
We are discussing it in #t-cargo > stabilization plan for `-Ztrim-paths` (though no discussions yet)
Member
There was a problem hiding this comment.
We are discussing it in #t-cargo > stabilization plan for
-Ztrim-paths(though no discussions yet)
Replied the in the Zulip thread.
This is implementation details for better diagonstic remap that is not really meaning for cargo users directly.
weihanglo
force-pushed
the
trim-paths-docs
branch
from
September 2, 2026 18:47
f4b56c6 to
2198a00
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Urgau
approved these changes
Sep 2, 2026
rustbot
removed
the
S-waiting-on-review
This was referenced Sep 2, 2026
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 5, 2026
Update cargo submodule 9 commits in b2e9d5f9db3fb1c454ab84f10c16508984a266e2..3c0b534756e166d12eb9fd2e1abfe5b42ac6101e 2026-09-02 14:49:16 +0000 to 2026-09-04 17:03:10 +0000 - fix(trim-paths)!: limit options to `none|object|all` (rust-lang/cargo#17432) - fix(git): Apply pr hint to git-fetch-with-cli (rust-lang/cargo#17437) - fix(git): Make PR dep note cloer to our style guide (rust-lang/cargo#17436) - docs: clarify cargo vendor source config option (rust-lang/cargo#17435) - docs(trim-paths): workspace remap begins with `.` (rust-lang/cargo#17433) - docs: Switch from "target triple" to "target tuple" (rust-lang/cargo#17430) - docs(trim-paths): add limitations and polish (rust-lang/cargo#17425) - fix(git): Simplify error message (rust-lang/cargo#17429) - chore(deps): update rust crate base64 to 0.23.0 (rust-lang/cargo#17418)
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 5, 2026
Update cargo submodule 9 commits in b2e9d5f9db3fb1c454ab84f10c16508984a266e2..3c0b534756e166d12eb9fd2e1abfe5b42ac6101e 2026-09-02 14:49:16 +0000 to 2026-09-04 17:03:10 +0000 - fix(trim-paths)!: limit options to `none|object|all` (rust-lang/cargo#17432) - fix(git): Apply pr hint to git-fetch-with-cli (rust-lang/cargo#17437) - fix(git): Make PR dep note cloer to our style guide (rust-lang/cargo#17436) - docs: clarify cargo vendor source config option (rust-lang/cargo#17435) - docs(trim-paths): workspace remap begins with `.` (rust-lang/cargo#17433) - docs: Switch from "target triple" to "target tuple" (rust-lang/cargo#17430) - docs(trim-paths): add limitations and polish (rust-lang/cargo#17425) - fix(git): Simplify error message (rust-lang/cargo#17429) - chore(deps): update rust crate base64 to 0.23.0 (rust-lang/cargo#17418)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This doc polish is a stabilization preparation.
See #12137 (comment)
How to test and review this PR?
This is stacked on top of #17424 to minimize merge conflict. Please review from c99bbf2