test: Move -Z onto its own line - #17416
Merged
Merged
Conversation
I tried this out with a previous change and I found it makes it easier toe remove and review -Z flags Things left alone - `-Zscript` when it needs to come before the script name - `cargo_features.rs`
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
weihanglo
reviewed
Aug 31, 2026
Member
There was a problem hiding this comment.
Thanks. I think this is good for review and diffing. Should we document this in https://doc.crates.io/contrib/tests/writing.html#testing-nightly-features or somewhere?
weihanglo
approved these changes
Aug 31, 2026
Member
There was a problem hiding this comment.
Given this is likely conflicting with other PRs, let's not wait for doc polish.
@rustbot merge
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
I tried this out with a previous change and I found it makes it easier toe remove and review -Z flags
How to test and review this PR?
Things left alone
-Zscriptwhen it needs to come before the script namecargo_features.rs