refactor: remove ad-hoc subslice_range - #17390
Merged
Merged
Conversation
This API is stabilized in 1.98
rustbot
added
A-registries
Collaborator
|
r? @epage rustbot has assigned @epage. Use Why was this reviewer chosen?The reviewer was selected based on:
|
epage
approved these changes
Aug 25, 2026
epage
enabled auto-merge
August 25, 2026 01:34
Contributor
|
|
Member
Author
I wonder if that deserves a new cargo-util-frontmatter package. |
Contributor
|
Maybe, eventually. Part of the move to utils was prep for that one day. For r-a, I'm unsure if it would help because they likely wouldn't want to wait for a release. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 25, 2026
rustbot
removed
the
S-waiting-on-review
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Aug 26, 2026
Update cargo submodule 7 commits in e8cb624d5701824f46a2ec5873cfd59ee3d2f66c..94ba974179df2adb3c911fadf361f03b84aa8f14 2026-08-22 00:23:45 +0000 to 2026-08-25 18:16:11 +0000 - feat(diag): Stabilize cargo-lints (rust-lang/cargo#17298) - chore(deps): Update partial_ref to v0.3.4 (rust-lang/cargo#17392) - refactor: remove ad-hoc `subslice_range` (rust-lang/cargo#17390) - docs(changelog): move build-dir new layout to Changed (rust-lang/cargo#17387) - chore(deps): update msrv (1 version) to v1.98 (rust-lang/cargo#17386) - docs: Use mdbook admonitions (rust-lang/cargo#17384) - chore(ci): exclude resolver-tests from intra doc link checks (rust-lang/cargo#17385)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slice::subslice_rangeAPI is stabilized in 1.98🤖 LLM disclosure: I asked LLM to show if there is any cleanup we can do with 1.98. It pointed out some. Code was hand-written and never generated.
The rest were not interesting at all. One in frontmatter.rs for
substr_range, though I guess we want to keep it as close as rust-lang/rust's impl (or it has been diverged I forgot). Others werestr::strip_circumfixandPath::is_empty.