Skip to content

chore(deps): Update partial_ref to v0.3.4 - #17392

Merged
epage merged 1 commit into
rust-lang:masterfrom
adamgemmell:dev/adagem01/varisat-bump
Aug 25, 2026
Merged

chore(deps): Update partial_ref to v0.3.4#17392
epage merged 1 commit into
rust-lang:masterfrom
adamgemmell:dev/adagem01/varisat-bump

Conversation

@adamgemmell

Copy link
Copy Markdown
Contributor

What does this PR try to resolve?

Running the resolver tests hangs for quite a while when using a nightly with the new trait solver. This is because it experiences a huge compile time regression when trying to build varisat due to the use of unconstrained lifetimes in partial_ref.

This PR bumps partial_ref to include jix/partial_ref#6. See rust-lang/rust#161575 for more details.

How to test and review this PR?

CI should be sufficient testing for this PR.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2026
@rustbot

rustbot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @epage, @weihanglo
  • @epage, @weihanglo expanded to epage, weihanglo
  • Random selection from epage, weihanglo

@adamgemmell

Copy link
Copy Markdown
Contributor Author

This CI failure is sporadic and happens on master too. It seems gitoxide is sometimes providing different output for ssh errors, for example:

thread 'ssh::bundled_github_works' (2306524) panicked at tests/testsuite/ssh.rs:528:10:

---- expected: tests/testsuite/ssh.rs:469:9
++++ actual:   stderr
   1    1 | [UPDATING] git repository `ssh://git@github.com/rust-lang/bitflags.git`
   2    2 | [ERROR] failed to get `bitflags` as a dependency of package `foo v0.1.0 ([ROOT]/foo)`
   3    3 |
   4    4 | Caused by:
   5    5 |   failed to load source for dependency `bitflags`
          ⋮
   9    9 |
  10   10 | Caused by:
  11   11 |   failed to clone into: [ROOT]/home/.cargo/git/db/bitflags-[HASH]
  12   12 |
  13   13 | Caused by:
  14      -   failed to authenticate when downloading repository
  15      -
  16      -   * attempted to find username/password via `credential.helper`, but maybe the found credentials were incorrect
  17      -
  18      -   if the git CLI succeeds then `net.git-fetch-with-cli` may help here
       14 +   network failure seems to have happened
       15 +   if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
  19   16 |   https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli
  20   17 |
  21   18 | Caused by:
  22      - [CREDENTIAL]s provided for "ssh://git@github.com/rust-lang/bitflags.git" were not accepted by the remote
       19 +   An IO error occurred when talking to the server
  23   20 |
  24   21 | Caused by:
  25      -   git@github.com: Permission denied (publickey).
       22 +   Connection closed by 20.26.156.215 port 22

@adamgemmell
adamgemmell force-pushed the dev/adagem01/varisat-bump branch from 0b23c4b to 4ca1a7b Compare August 25, 2026 11:09
@epage
epage enabled auto-merge August 25, 2026 11:15
auto-merge was automatically disabled August 25, 2026 11:30

Head branch was pushed to by a user without write access

@adamgemmell
adamgemmell force-pushed the dev/adagem01/varisat-bump branch from 4ca1a7b to a4350aa Compare August 25, 2026 11:30
@epage
epage enabled auto-merge August 25, 2026 12:02
@epage
epage added this pull request to the merge queue Aug 25, 2026
Merged via the queue into rust-lang:master with commit 77a6fbc Aug 25, 2026
31 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2026
@adamgemmell
adamgemmell deleted the dev/adagem01/varisat-bump branch August 25, 2026 13:05
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Aug 26, 2026
Update cargo submodule

7 commits in e8cb624d5701824f46a2ec5873cfd59ee3d2f66c..94ba974179df2adb3c911fadf361f03b84aa8f14
2026-08-22 00:23:45 +0000 to 2026-08-25 18:16:11 +0000
- feat(diag): Stabilize cargo-lints  (rust-lang/cargo#17298)
- chore(deps): Update partial_ref to v0.3.4 (rust-lang/cargo#17392)
- refactor: remove ad-hoc `subslice_range` (rust-lang/cargo#17390)
- docs(changelog): move build-dir new layout to Changed (rust-lang/cargo#17387)
- chore(deps): update msrv (1 version) to v1.98 (rust-lang/cargo#17386)
- docs: Use mdbook admonitions (rust-lang/cargo#17384)
- chore(ci): exclude resolver-tests from intra doc link checks (rust-lang/cargo#17385)
rust-bors Bot pushed a commit to rust-lang/rust that referenced this pull request Sep 2, 2026
Update cargo submodule



26 commits in e8cb624d5701824f46a2ec5873cfd59ee3d2f66c..b2e9d5f9db3fb1c454ab84f10c16508984a266e2
2026-08-22 00:23:45 +0000 to 2026-09-02 14:49:16 +0000
- fix(parser): Resolve theoretical use-after-free (rust-lang/cargo#17428)
- fix(trim-paths)!: remove default scope from release profile (rust-lang/cargo#17424)
- fix(git): Use git's 429 retry, when available (rust-lang/cargo#17422)
- Avoid passing search path (-L) args when they are passed as --extern (rust-lang/cargo#17410)
- chore(deps): update crate-ci/typos action to v1.50.0 (rust-lang/cargo#17417)
- test: Move -Z onto its own line (rust-lang/cargo#17416)
- chore(triagebot): enable `@rustbot merge/delegate` (rust-lang/cargo#17415)
- Micro-optimize two package dir functions (rust-lang/cargo#17413)
- perf: Do not build SBOM if user has not set build.sbom (rust-lang/cargo#17412)
- feat(manifest)!: implement feature-metadata RFC3416 (rust-lang/cargo#15056)
- Cargo profiling improvements (rust-lang/cargo#17411)
- test(git): Remove gix override run in CI and the mode in code (rust-lang/cargo#17405)
- perf(git): Reduce extra work when using git-cli (rust-lang/cargo#17406)
- feat(resolver): Stabilize min-publish-age (rust-lang/cargo#17335)
- fix(git): Remove ref status update when showing progress  (rust-lang/cargo#17400)
- revert: refactor: move sysroot lookup to GlobalContext (rust-lang/cargo#17401)
- fix(run): Printing a new line to avoid overwriting error code after \r (rust-lang/cargo#17373)
- fix(trim-paths): custom workspace-relative member paths remap (rust-lang/cargo#17366)
- fix(home): rustdoc lint (rust-lang/cargo#17394)
- feat(diag): Stabilize cargo-lints  (rust-lang/cargo#17298)
- chore(deps): Update partial_ref to v0.3.4 (rust-lang/cargo#17392)
- refactor: remove ad-hoc `subslice_range` (rust-lang/cargo#17390)
- docs(changelog): move build-dir new layout to Changed (rust-lang/cargo#17387)
- chore(deps): update msrv (1 version) to v1.98 (rust-lang/cargo#17386)
- docs: Use mdbook admonitions (rust-lang/cargo#17384)
- chore(ci): exclude resolver-tests from intra doc link checks (rust-lang/cargo#17385)
@rustbot rustbot added this to the 1.100.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants