Add current workspace to the rosdep install command#1115
Conversation
ghost
requested a review
from 
|
Yea, this must have been a typo from when I refactored the config to use functions.
Just note that changes to
Yep, exactly! This will help support arbitrary workspace layering, and shore up cache restores. |
Nevermind, forgot that |
ghost
mentioned this pull request
* Remove COLCON_IGNORE * Revert branch typo * Merge pull request #1115 from crdelsey/circleci-rosdep Add current workspace to the rosdep install command * Cache per packge.xml via multistage * Include COLCON_IGNORE in cache * Colcon mixin now installed from base image * Revert FROM tag change * Comment new directives * Update labels * Cache both underlay and overlay layers * Fix underlay parameter for install_overlay_dependencies Otherwise the checksum.txt for the overlay is improperly copied from `/opt/ros_ws` instead of `/opt/underlay_ws`. * Include complete path of checksum.txt in checksum To make the checksum output easier to read, trace and debug. * Simplify checksum commands for consistency * Add test for rmw_cyclonedds_cpp to nightly job * Use ament index to resolve rosdep install * Update design for providing transform to bt nodes (#1157) * Making a transform (buffer) available on the behavior tree blackboard for nodes to pull and use. Updating `GoalReachedCondition` to use the blackboard provided tf. * Removed unnecessary include Changing to non-lifecycle node for tf listener. The lifecycle interface doesn't exist in dashing. * Always build underlay as release * Instead of copying icons, reference them in origin package. (#1188) * Instead of copying icons, reference them in origin package. * Remove icon install step as well.
1 participant
Basic Info
Description of contribution in a few bullet points
install_dependenciescommand is run on the underlay, the two paths will collapse to the same directory and should be harmless but redundant. When theinstall_dependenciescommand is run on the overlay (nav2) workspace, then underlay and overlay will be scanned for dependencies as desired.$UNDERLAY_WS/srccomponent can be removed and the redundancy can be eliminated.