Extend workspace packages using ament index for ROS2 support#699
Extend workspace packages using ament index for ROS2 support#699wjwwood merged 8 commits intoros-infrastructure:masterfrom
Conversation
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Signed-off-by: ruffsl <roxfoxpox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 75.47% 75.77% +0.29%
==========================================
Files 32 37 +5
Lines 2968 3013 +45
==========================================
+ Hits 2240 2283 +43
- Misses 728 730 +2
Continue to review full report at Codecov.
|
wjwwood
left a comment
There was a problem hiding this comment.
Copying the code sucks, but I guess it's unavoidable right now. However, please make a comment (or a README.md in the ament_packages folder) mentioning that this code is essentially copied directly from ament_package or ament_index_python or wherever it came from. That way it can be more easily updated in the future.
I think at least one test would be a good idea, and maybe one for the case I mentioned in my comment (mixing ROS 1 and ament packages).
Add fake_catkin_package that depends on packages in ament inedex. Also add testboost as a colliding package in ament inedex.
|
@wjwwood , I've added the readme linking to the repo/commit copied from, as well a extension to the install tests to check the behavior when colliding packages from ament and package path. |
|
While testing this branch in the wild, I found the ament_packages sub module wasn't being installed. I've updated the setup.py to fix this and can confirm this patch is working as expected. See this before, after Dockerfile that achieve the same effect, now without needing to monkeypatch ROS_PACKAGE_PATH everyware: ros-swg/turtlebot3_demo@97d9c33 Could we merge this upstream for the next eventual sync? |
|
I'll be triggering an update to the ros docker image library soon. I would be neat to have this included. |
|
I'll try to merge and release this asap, but I can't do it today. |
|
@wjwwood , now that dashing sync is out, I'd like to get this in the docker library rebuild as well. |
|
Looks like either I will release this next week (I'm pretty busy for the rest of this week), or maybe @nuclearsandwich because I think he mentioned on discourse he may do a release soon. |
Fixes #660