Instead of copying icons, reference them in origin package.#1188
Merged
2 commits merged intomasterfrom Oct 2, 2019
unknown repository
Merged
Instead of copying icons, reference them in origin package.#11882 commits merged intomasterfrom unknown repository
2 commits merged intomasterfrom
unknown repository
Conversation
SteveMacenski
approved these changes
Oct 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
=========================================
+ Coverage 30.32% 36.32% +6%
=========================================
Files 243 243
Lines 10978 10992 +14
Branches 3576 4293 +717
=========================================
+ Hits 3329 3993 +664
+ Misses 5511 4365 -1146
- Partials 2138 2634 +496
Continue to review full report at Codecov.
|
mkhansenbot
approved these changes
Oct 2, 2019
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Oct 4, 2019
* Remove COLCON_IGNORE * Revert branch typo * Merge pull request #1115 from crdelsey/circleci-rosdep Add current workspace to the rosdep install command * Cache per packge.xml via multistage * Include COLCON_IGNORE in cache * Colcon mixin now installed from base image * Revert FROM tag change * Comment new directives * Update labels * Cache both underlay and overlay layers * Fix underlay parameter for install_overlay_dependencies Otherwise the checksum.txt for the overlay is improperly copied from `/opt/ros_ws` instead of `/opt/underlay_ws`. * Include complete path of checksum.txt in checksum To make the checksum output easier to read, trace and debug. * Simplify checksum commands for consistency * Add test for rmw_cyclonedds_cpp to nightly job * Use ament index to resolve rosdep install * Update design for providing transform to bt nodes (#1157) * Making a transform (buffer) available on the behavior tree blackboard for nodes to pull and use. Updating `GoalReachedCondition` to use the blackboard provided tf. * Removed unnecessary include Changing to non-lifecycle node for tf listener. The lifecycle interface doesn't exist in dashing. * Always build underlay as release * Instead of copying icons, reference them in origin package. (#1188) * Instead of copying icons, reference them in origin package. * Remove icon install step as well.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points