use distinct xunit pattern for ROS 2#828
Merged
dirk-thomas merged 1 commit intomasterfrom Aug 14, 2020
Merged
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
This was referenced Aug 14, 2020
nuclearsandwich
approved these changes
Aug 14, 2020
j-rivero
reviewed
Aug 14, 2020
j-rivero
reviewed
Aug 14, 2020
j-rivero
approved these changes
Aug 14, 2020
dirk-thomas
deleted the
dirk-thomas/use-distinct-xunit-pattern-for-ros2
branch
Member
Author
|
I assume the current patch resolves the issue for Rolling and Foxy. For Eloquent (and likely Dashing) this needs more work: e.g. |
This was referenced Aug 14, 2020
Merged
jacobperron
reviewed
Aug 27, 2020
| types.append(('CTestType', 'ws/test_results/*/Testing/*/Test.xml')) | ||
| types.append(('GoogleTestType', 'ws/test_results/**/*.gtest.xml')) | ||
| types.append(( | ||
| 'JUnitType' if pytest_junit_compliant else 'GoogleTestType', |
Contributor
There was a problem hiding this comment.
It's not super clear in the pytest documentation or in the deprecation warnings produced, but testing locally I've observed that using pytest version >= 6 does not imply that the junit_family type will be xunit2. In fact, if you don't explicitly set the junit_family (either with a pytest.ini file or a pytest -o option), then we get the legacy behavior. This is what's causing CI to fail for Foxy (ros2/ros2#1016).
I think this only happened to work for Rolling because of all of the backports explicitly setting the junit_family in pytest.ini files (ros2/ros2#951).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This redoes #723 and #724 (which were reverted in #725) and also adds a specific pattern for the xUnit type
CTestTypesince CTest result files are available now (see colcon/colcon-cmake#89).Without this change Jenkins tries to interpret the newly copied CTest result files as GoogleTest results files and chokes, e.g.:
With this patch:
I assume this works now because both buildfarms have been updated to the latest xUnit plugin version.