Copy CTest results to custom location#89
Merged
dirk-thomas merged 2 commits intomasterfrom Aug 13, 2020
Merged
Conversation
dirk-thomas
force-pushed
the
dirk-thomas/symlink-or-copy-test-result-to-custom-path
branch
from
aafceff to
c922317
Compare
cottsay
reviewed
Aug 10, 2020
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
I'm not sure this will work on the CI jobs on build.ros2.org. Pretty sure the build_base gets deleted at the end of the job, but before the test results are inspected by Jenkins. So the symlinks would be dead then, no?
dirk-thomas
force-pushed
the
dirk-thomas/symlink-or-copy-test-result-to-custom-path
branch
from
75b014e to
2300576
Compare
Member
Author
Good point. I didn't think of that use case. I modified the patch to do a plain copy: 2300576. |
cottsay
changed the title
cottsay
approved these changes
Aug 13, 2020
dirk-thomas
deleted the
dirk-thomas/symlink-or-copy-test-result-to-custom-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79.