improve color support for themes

[mikeferguson]

based on ros-visualization/rviz#1319

[mikeferguson]

This makes dark mode look good on Mac. Before:

After:

Also tested against regular mode, all looks good (and this is merged into Melodic)

[mikeferguson]

CI appears to be broken due to #589 (seems that the resource_retriever package hasn't been re-released yet with those changes)

[clalancette]

CI appears to be broken due to #589 (seems that the resource_retriever package hasn't been re-released yet with those changes)

Yeah, we need to release a new resource_retriever and a new rviz2.

[clalancette]

@ros-pull-request-builder retest this please

[clalancette]

@mikeferguson FYI, the current failures look to be style failures with this patch.

[mikeferguson]

@clalancette style fixes are fixed - but there's some weird failure I can't seem to figure out:

WARNING: The converted file for the input file '/home/jenkins-agent/workspace/Rpr__rviz__ubuntu_focal_amd64/ws/test_results/rviz2/Testing/20200814-1326/Test.xml' doesnt match the JUnit format.
09:26:57 WARNING: At line 2 of file:/home/jenkins-agent/workspace/Rpr__rviz__ubuntu_focal_amd64/generatedJUnitFiles/4c631cba-8659-477a-bd2f-9af6c0c9a750/GoogleTest/TEST-3d6e02d0-4e95-4845-9763-7699c02eb1d7.xml:Premature end of file.
09:26:57 WARNING: Technical validation:Premature end of file.
09:26:57 ERROR: Premature end of file.
09:26:57 ERROR: Premature end of file.
09:26:57 ERROR: Step ‘Publish xUnit test result report’ failed: The converted file for the result file '/home/jenkins-agent/workspace/Rpr__rviz__ubuntu_focal_amd64/ws/test_results/rviz2/Testing/20200814-1326/Test.xml' (during conversion process for the metric 'GoogleTest') is not valid. The report file has been skipped.

• but in the "rviz2" section, there are no failures listed - or even any gtests (and the output for the rviz2 section looks the same as a PR that succeeds: http://build.ros2.org/job/Rpr__rviz__ubuntu_focal_amd64/27/console#console-section-2)

[clalancette]

@clalancette style fixes are fixed - but there's some weird failure I can't seem to figure out:

Yeah, sorry, we are having some infrastructure issues at the moment. Those should be fixed once ros-infrastructure/ros_buildfarm#828 is merged. If that is the only failure, then you are good to go.

[mikeferguson]

@clalancette -- thanks for the quick feedback -- yeah that appears to be the only issue (I had forgotten to lint before opening the PR - thos issues are fixed).

[dirk-thomas]

@ros-pull-request-builder retest this please

[mikeferguson]

@clalancette tests are now passing!

[jacobperron]

LGTM

• Linux
• Linux-aarch64
• macOS
• Windows

[jacobperron]

The Windows build is complaining that Qt::TextColorRole is deprecated.
Docs suggest changing this to Qt::ForegroundRole.

[mikeferguson]

Looks right to me on the Mac - want to rerun the other tests?

[jacobperron]

Windows:

[jacobperron]

@mikeferguson thanks!