Skip to content

De-deplicate type_support_map.h header#81

Merged
j-rivero merged 11 commits intomasterfrom
jrivero/deduplicate
Sep 11, 2020
Merged

De-deplicate type_support_map.h header#81
j-rivero merged 11 commits intomasterfrom
jrivero/deduplicate

Conversation

@j-rivero
Copy link
Copy Markdown

@j-rivero j-rivero commented Aug 3, 2020

Fixes: #79

@j-rivero j-rivero force-pushed the jrivero/deduplicate branch 2 times, most recently from c2b69e8 to fab24a5 Compare August 4, 2020 16:27
@j-rivero j-rivero requested a review from dirk-thomas August 4, 2020 16:44
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 4, 2020

The removal of the public header file rosidl_typesupport_cpp/type_support_map.h is breaking public API. I would suggest to avoid that kind of breakage and keep the header in place (redirecting to the C header) and add a deprecation warning in case it is still used.

@j-rivero j-rivero self-assigned this Aug 4, 2020
@j-rivero j-rivero force-pushed the jrivero/deduplicate branch 2 times, most recently from b0d43b4 to d678bed Compare August 13, 2020 18:32
@j-rivero
Copy link
Copy Markdown
Author

j-rivero commented Aug 13, 2020

@ros-pull-request-builder run tests please

@j-rivero j-rivero mentioned this pull request Aug 13, 2020
Closed
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2020

@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828)

dirk-thomas
dirk-thomas reviewed Aug 14, 2020
View reviewed changes
@j-rivero j-rivero force-pushed the jrivero/deduplicate branch from 1f77561 to 9be02fe Compare August 14, 2020 18:04
@j-rivero j-rivero requested a review from dirk-thomas August 14, 2020 18:09
dirk-thomas
dirk-thomas reviewed Aug 14, 2020
View reviewed changes
Jose Luis Rivero added 11 commits September 10, 2020 20:42
De-deplicate type_support_map.h header
768ccbe 
Fixes: #79
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Use rosidl_typesupport_c in CMake
af99fbf 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Revert the removal of type_support_map.h file to avoid breaking API
a74937a 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Add compiler warning
9e81c05 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Fix uncrustify report
cfc226b 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Declare rosidl_typesupport_c as a build_depend
1037a32 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Revert changes in empy files
a8696a9 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Reorder headers to keep alphabetic order
5f0118a 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Revert missing changes in empy files
6e22ee2 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Need to export rosidl_typesupport_c as build depend
5f58fa2 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Right alpha order for headers
4d9a6fa 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Copy link
Copy Markdown
Author

j-rivero commented Sep 10, 2020

ough the signoff amend command re-push a good bunch of commits, the ones did since your last comments are 4d9a6fa and
5f58fa2

@j-rivero j-rivero merged commit 29da73a into master Sep 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the jrivero/deduplicate branch September 11, 2020 17:08
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Sep 11, 2020

Did you happen to run any CI builds for this change?

@j-rivero
Copy link
Copy Markdown
Author

j-rivero commented Sep 11, 2020 •
edited
Loading

Did you happen to run any CI builds for this change?

eh uh ... totally forgot to run ros2 ci jobs, I just relied on the github CI mark. Go to check now.

@j-rivero
Copy link
Copy Markdown
Author

j-rivero commented Sep 11, 2020

eh uh ... totally forgot to run ros2 ci jobs, I just relied on the github CI mark. Go to check now.

Testing up to rclcpp, running rclcpp tests:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@j-rivero j-rivero mentioned this pull request Sep 14, 2020
Merged
@christophebedard christophebedard mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@j-rivero j-rivero

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Same header file hosted in two packages: type_support_map.h

2 participants

@j-rivero @dirk-thomas