[foxy backport] Add in pytest.ini so tests succeed locally. (#280)#309
Merged
jacobperron merged 3 commits intofoxyfrom Aug 18, 2020
Merged
[foxy backport] Add in pytest.ini so tests succeed locally. (#280)#309jacobperron merged 3 commits intofoxyfrom
jacobperron merged 3 commits intofoxyfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Member
Author
This is a backport of the change made when splitting out the Python module into its own packages in #210. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/backport_280
branch
from
4d60c02 to
c11a1bf
Compare
Member
Author
|
@ros-pull-request-builder retest this please |
Member
Author
|
CI for this PR and several other similar backports can be found here: ros2/ci#503 (comment) |
Member
Author
|
I thought ros-infrastructure/ros_buildfarm#828 would resolve the Fpr failure 🤔 Maybe it's failing because we've only changed the junit_family option for a subset of the packages being tested in this repo. I can try updating the option for all packages and see what happens. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Yeah, you need to have it for all of the packages. This is looking good to me. |
clalancette
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #280 to Foxy.
This should help resolve one of the outstanding failures in ros2/ci#503