use GoogleTest / JUnit test result parser based on file pattern in ROS 2#723
Merged
dirk-thomas merged 4 commits intomasterfrom Jan 30, 2020
Merged
Conversation
tfoote
approved these changes
Jan 30, 2020
Member
|
The CI is having an issue with "names" in the template. Is this the empy bug you found? |
Member
Author
Correct. I already reported it upstream. But even if upstream fixed the problem and released a new version I think we have to work around the problem by not using the problematic logic in |
nuclearsandwich
approved these changes
Jan 30, 2020
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
The change itself looks good. CI not passing sounds like a separate issue that's being worked on independently.
dirk-thomas
deleted the
dirk-thomas/ros2-use-specific-junit-test-types
branch
This was referenced Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ROS 1 the logic keeps using only
GoogleTestfor all XML results.The change matches the logic of ci.ros2.org except that there is no CTest type configured since the build directory is wiped before test results are collected. This will make Jenkins render better error messages for failed test: e.g. bad vs. good.
http://build.ros2.org/job/Ddev_reconfigure-jobs/494/ used this branch for a dry run and successfully reconfigured
develjobs (with no changes) while their template wasn't update to the modified arguments of thepublisher_junitsnippet: 9139aa9#diff-5cf979d1d9687b7cad0d95e630cc87c6R269. This ensured the backward compatibility of the changed snippet arguments works.http://build.ros.org/job/Nci_reconfigure-jobs/186/ used this branch for a dry run and successfully reconfigured
cijobs (with no changes): 9139aa9#diff-7b020c516b04814ffc3fc28ed8fac0deR597. This ensures ROS 1 stays untouched.http://build.ros2.org/job/Fci_reconfigure-jobs/5/ (dry run) reconfigured ROS 2 CI jobs to use the more specific xunit types bases on the various patterns.