Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new modal with the blueprint panel "+" button #4652

Closed
Tracked by #4140
abey79 opened this issue Jan 3, 2024 · 0 comments · Fixed by #5012
Closed
Tracked by #4140

Use the new modal with the blueprint panel "+" button #4652

abey79 opened this issue Jan 3, 2024 · 0 comments · Fixed by #5012
Assignees
@abey79
Labels
ui concerns graphical user interface
Milestone
0.13

Comments

@abey79
Copy link
Member

abey79 commented Jan 3, 2024 •
edited
Loading

After #4616, both the blueprint tree + icon and the selection planel offer a way to add space views and/or container to the tree. They currently show different modals and should be reunified.

This might be implemented and/or superseded by #1132
@abey79 abey79 mentioned this issue Jan 3, 2024
Open
23 tasks
@abey79 abey79 added the ui concerns graphical user interface label Jan 3, 2024
@abey79 abey79 mentioned this issue Jan 3, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue Jan 4, 2024
@abey79 @jleibs
Initial support for manually adding container and space view in the h…
7342ff8 
…ierarchy (#4616)

### What

This is an initial take for the new so-called "additive workflow", which
enables building a hierarchy of container and space views from scratch.
It involves the following changes in UX:
- The automatic simplification of the container tree is (mostly)
disabled, as empty containers must be (temporarily) allowed while
building a hierarchy.
- Instead, a new "Simplify Container" button is available in the
Selection Panel to simplify the subtree under the selected container.
- A list if container children is displayed in the container Selection
Panel, with a button to add more.
- A new "Add Container or Space View" modal makes it possible to add a
container and/or a space view of any type in the selected container.
This feature is gated behind an experimental flag (Rerun Menu -> Options
-> Enable the container addition workflow).

<img width="1248" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/0b58c298-d75c-480e-a88d-c1a5fe2265f5">

~~This PR also reorganises the experimental flags in the rerun menu such
that they are visible in web and release builds.~~ (superseded by #4661)

Fixes #4492 
Fixes #4493 

#### TODO (not necessarily in this PR)

- [x] Fix the hover/click UI of the big PLUS button in the modal.
- The PLUS button in the blueprint tree panel still shows the older
menu. This should reunified somehow (when we figure out how we want the
heuristics to show up): #4652
- Lots of container tree behaviour edge case to identify and fix.
- The modal really needs the new icons #4321
- Better hover highlight in the modal:
#4673

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4616/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4616)
- [Docs
preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Jeremy Leibs <[email protected]>
@abey79 abey79 mentioned this issue Jan 16, 2024
Open
30 tasks
@abey79 abey79 changed the title Unify addition workflow associated with the blueprint tree and the selection panel Use the new modal with the blueprint panel "+" button Jan 30, 2024
@abey79 abey79 self-assigned this Jan 30, 2024
@nikolausWest nikolausWest added this to the 0.13 milestone Jan 30, 2024
@abey79 abey79 mentioned this issue Feb 2, 2024
Merged
4 tasks
Wumpf added a commit that referenced this issue Feb 4, 2024
@abey79 @Wumpf
Use the "Add Space View/Container" modal for the + button of the bl…
412cd87 
…ueprint tree (#5012)

### What

This PR wires the new "Add SV/Container" modal to the blueprint tree `+`
button when the "Additive workflow" feature flag is enabled.

Now, the new SV or Container is added to the selected container _**if**_
the selection consist of a single container. Otherwise the SV or
Container is added to the root container.

* Closes: #4652 
* Follow-up: #5011


https://github.com/rerun-io/rerun/assets/49431240/e0c2925a-c821-4fe0-ac00-6c1843a51fe4


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/5012)
- [Docs
preview](https://rerun.io/preview/e71339054ad8be8ee3da946140d1c2256f0a645c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e71339054ad8be8ee3da946140d1c2256f0a645c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
ui concerns graphical user interface
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Use the "Add Space View/Container" modal for the + button of the blueprint tree rerun-io/rerun
2 participants
@nikolausWest @abey79