Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "Add Space View/Container" modal for the + button of the blueprint tree #5012

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Feb 2, 2024

What

This PR wires the new "Add SV/Container" modal to the blueprint tree + button when the "Additive workflow" feature flag is enabled.

Now, the new SV or Container is added to the selected container if the selection consist of a single container. Otherwise the SV or Container is added to the root container.

add_sv_container_bp_tree.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Feb 2, 2024
@Wumpf Wumpf self-requested a review February 4, 2024 15:55
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, very likable! 😄

@Wumpf
Copy link
Member

Wumpf commented Feb 4, 2024

(merged in main and resolved conflict)

@Wumpf Wumpf merged commit 412cd87 into main Feb 4, 2024
40 checks passed
@Wumpf Wumpf deleted the antoine/add-sv-container-blueprint-tree branch February 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new modal with the blueprint panel "+" button
2 participants