Improve modal window styling to support full span highlighting #4673
Labels
ui
concerns graphical user interface
Comments
5 tasks
abey79
added a commit
that referenced
this issue
Jan 4, 2024
…ierarchy (#4616) ### What This is an initial take for the new so-called "additive workflow", which enables building a hierarchy of container and space views from scratch. It involves the following changes in UX: - The automatic simplification of the container tree is (mostly) disabled, as empty containers must be (temporarily) allowed while building a hierarchy. - Instead, a new "Simplify Container" button is available in the Selection Panel to simplify the subtree under the selected container. - A list if container children is displayed in the container Selection Panel, with a button to add more. - A new "Add Container or Space View" modal makes it possible to add a container and/or a space view of any type in the selected container. This feature is gated behind an experimental flag (Rerun Menu -> Options -> Enable the container addition workflow). <img width="1248" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/0b58c298-d75c-480e-a88d-c1a5fe2265f5"> ~~This PR also reorganises the experimental flags in the rerun menu such that they are visible in web and release builds.~~ (superseded by #4661) Fixes #4492 Fixes #4493 #### TODO (not necessarily in this PR) - [x] Fix the hover/click UI of the big PLUS button in the modal. - The PLUS button in the blueprint tree panel still shows the older menu. This should reunified somehow (when we figure out how we want the heuristics to show up): #4652 - Lots of container tree behaviour edge case to identify and fix. - The modal really needs the new icons #4321 - Better hover highlight in the modal: #4673 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4616/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4616) - [Docs preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <[email protected]>
4 tasks
abey79
added a commit
that referenced
this issue
Jan 16, 2024
…d Space View or Container" modal (#4822) ### What This PR does the following: - Make sure the modal's clip rect is the same size as the modal itself. - Add a `full_span_separator()` helper function that's similar to `ui.separator()` but draws a full-span line and doesn't add vertical spacing. - Add a "full span" mode to our modal. In this mode, the vertical spacing is entirely left up to the user code. - Use the above in the "Add Space View or Container" modal for a nice, full span hover highlighting. - Add an example in `re_ui_example` showcasing how full span modal and `ListItem` work together. - Fixes #4673 `re_ui_example` with `ListItem`:  Add SV or Container:  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4822/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4822/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4822/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4822) - [Docs preview](https://rerun.io/preview/c76b1a5e8cf8acbb01c89d1741ab36d2f942189a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c76b1a5e8cf8acbb01c89d1741ab36d2f942189a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The styling and structure of the
re_ui::Modalhelper should be updated so that the clip rectangle is equal to the window and full span highlighting (in the style ofListItem) looks good.This should be applied along with full-span hover highlight on the "add SV/Container modal"
The text was updated successfully, but these errors were encountered: