Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Add SV/Container" modal should specify somewhere where the new item will be added #5011

Open
Tracked by #4825
abey79 opened this issue Feb 2, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Feb 2, 2024

No description provided.

@abey79 abey79 changed the title the modal title should specify where the SV/container will be added The "Add SV/Container" modal should specify somewhere where the new item will be added Feb 2, 2024
@abey79 abey79 added the ui concerns graphical user interface label Feb 2, 2024
Wumpf added a commit that referenced this issue Feb 4, 2024
…ueprint tree (#5012)

### What

This PR wires the new "Add SV/Container" modal to the blueprint tree `+`
button when the "Additive workflow" feature flag is enabled.

Now, the new SV or Container is added to the selected container _**if**_
the selection consist of a single container. Otherwise the SV or
Container is added to the root container.

* Closes: #4652 
* Follow-up: #5011


https://github.com/rerun-io/rerun/assets/49431240/e0c2925a-c821-4fe0-ac00-6c1843a51fe4


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5012/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/5012)
- [Docs
preview](https://rerun.io/preview/e71339054ad8be8ee3da946140d1c2256f0a645c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e71339054ad8be8ee3da946140d1c2256f0a645c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

1 participant