Improve Rerun Menu with link to Rerun Discord #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
emilk
force-pushed
the
emilk/improve-rerun-menu
branch
from
7814824 to
405ca80
Compare
# Conflicts: # crates/re_viewer/src/ui/rerun_menu.rs
abey79
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Might be nice to make it 14x14 for consistence with all other icons that I'm currently updating.
There was a problem hiding this comment.
Maybe @martenbjork want to take a stab at it, too :)
There was a problem hiding this comment.
14x14 what, pixels or ui points?
if it is 14x14 points, then we should probably make it 28x28 pixels, right?
There was a problem hiding this comment.
Anyways, I chose the 24 width because it is 2x the currently default icon size of 12x12
There was a problem hiding this comment.
Right, actually I meant 28x28, which is the new default.
5 tasks
abey79
added a commit
that referenced
this pull request
Jan 4, 2024
…ierarchy (#4616) ### What This is an initial take for the new so-called "additive workflow", which enables building a hierarchy of container and space views from scratch. It involves the following changes in UX: - The automatic simplification of the container tree is (mostly) disabled, as empty containers must be (temporarily) allowed while building a hierarchy. - Instead, a new "Simplify Container" button is available in the Selection Panel to simplify the subtree under the selected container. - A list if container children is displayed in the container Selection Panel, with a button to add more. - A new "Add Container or Space View" modal makes it possible to add a container and/or a space view of any type in the selected container. This feature is gated behind an experimental flag (Rerun Menu -> Options -> Enable the container addition workflow). <img width="1248" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/0b58c298-d75c-480e-a88d-c1a5fe2265f5"> ~~This PR also reorganises the experimental flags in the rerun menu such that they are visible in web and release builds.~~ (superseded by #4661) Fixes #4492 Fixes #4493 #### TODO (not necessarily in this PR) - [x] Fix the hover/click UI of the big PLUS button in the modal. - The PLUS button in the blueprint tree panel still shows the older menu. This should reunified somehow (when we figure out how we want the heuristics to show up): #4652 - Lots of container tree behaviour edge case to identify and fix. - The modal really needs the new icons #4321 - Better hover highlight in the modal: #4673 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4616/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4616) - [Docs preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cleans up the code around the options menu, and splits out the debug options to its own menu.
Also adds a link to our Discord (part of #4436)
The icon comes from https://discord.com/branding
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io