Build and test with CUDA 13.0.0#19768
Build and test with CUDA 13.0.0#19768rapids-bot[bot] merged 15 commits intorapidsai:branch-25.10from jameslamb:cuda-13.0.0
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Expecting this to fail until we have |
|
/ok to test |
|
Builds are failing with the issue described here: #19710 |
Splitting some changes off of the CUDA 13 support PR (#19768) ... that has gotten too large to review. Contributes to rapidsai/build-planning#208 * uses the new `[cu12, cu13]` extras added to `dask-cuda` for wheels: rapidsai/dask-cuda#1536 * replaces hard-coding of CUDA major version in `pandas` diff script * moves `numba-cuda` floor from `>=0.19.0` to `>=0.19.1` * consolidates some dependency lists with unnecessary `cuda: "12.*"` filters Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #19794
Problem 1: failing C++ testdetails (click me)The Fixed by #19807 Problem 2:
|
Splitting some changes off of the CUDA 13 support PR (rapidsai#19768) ... that has gotten too large to review. Contributes to rapidsai/build-planning#208 * uses the new `[cu12, cu13]` extras added to `dask-cuda` for wheels: rapidsai/dask-cuda#1536 * replaces hard-coding of CUDA major version in `pandas` diff script * moves `numba-cuda` floor from `>=0.19.0` to `>=0.19.1` * consolidates some dependency lists with unnecessary `cuda: "12.*"` filters Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: rapidsai#19794
gforsyth
left a comment
There was a problem hiding this comment.
This looks solid to me @jameslamb -- I'll leave you an approval so you can merge it in once #19806 lands
…ython 12.9.2, cupy 13.6.0, numba 0.60.0) (#19806) Contributes to rapidsai/build-planning#208 * updates dependency pins: - `cuda-python`: >=12.9.2 (CUDA 12) - `cupy`: >=13.6.0 - `numba`: >=0.60.0 (now that NVIDIA/numba-cuda#403 is done) * ensures that "oldest" `numpy` is pinned in `dask-cudf` tests - _the "oldest" pin for `numpy` was previously not used in `dask-cudf` wheel tests, allowing an incompatible mix of packages (`pandas 2.0.3, numpy 2.0.2`) to be installed together_ ## Notes for Reviewers ### Why a separate PR? In #19768 (comment), we saw this set of dependency changes caused failures like this in CUDA 12 and CUDA 13 environments: ```text ... ERROR io/tests/test_csv.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ERROR io/tests/test_json.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ERROR io/tests/test_orc.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ERROR io/tests/test_parquet.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ERROR io/tests/test_s3.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ... many more ... ``` ([wheel-test-dask-cudf link](https://github.com/rapidsai/cudf/actions/runs/17249655997/job/48950898976?pr=19768#step:11:11795)) Opening this more narrowly-scoped PR to investigate that. ### How I tested this First commit here contained some of the dependency changes from #19768 , and those were enough to reproduce the test failures! https://github.com/rapidsai/cudf/actions/runs/17271893124/job/49021534507?pr=19806#step:11:11928 # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Matthew Murray (https://github.com/Matt711) - Gil Forsyth (https://github.com/gforsyth) URL: #19806
|
Thanks very much! I just merged in #19806, hopefully that'll be the last thing and we'll be able to merge this as soon as CI pass. |
|
gahhhh we're so close! There's a new issue here. Problem 5: JSON wheel test failing (only on CUDA 13 + arm)One wheel test is failing as follows: I'll go ask for some help, but if we can't fix it quickly I think we should just skip it, write up an issue, and move on. |
@Matt711 informed me that this is a known-to-be-flaky test and sure enough... it passed on a re-run. |
|
/merge |
94e0f92
into
rapidsai:branch-25.10
|
This was a tough one, thanks so much to everyone for helping get this in!!! @Matt711 @mroeschke @robertmaynard @gforsyth @bdice @brandon-b-miller @davidwendt |
CUDA 13 support was initially added here in #19768 During that work, we faced some runtime issues with conda packages that @brandon-b-miller diagnosed as a missing dependency in `numba-cuda` (NVIDIA/numba-cuda#430). To get past that, we temporarily introduced a runtime dependency on `cuda-nvvm-tools` in this project. That's no longer necessary, thanks to these: * conda-forge/numba-cuda-feedstock#47 * conda-forge/numba-cuda-feedstock#46 This removes that workaround. ## Notes for Reviewers ### Don't we need to change the `numba-cuda` pin? No, the fixes are just in new builds of 0.19.1. # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/brandon-b-miller - Jake Awe (https://github.com/AyodeAwe) URL: #19842
Contributes to rapidsai/build-planning#208 #489 temporarily removed the `cudf` test-time dependency here, because there weren't yet CUDA 13 `cudf` packages. Those now exist (rapidsai/cudf#19768), so this restores that dependency. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Vyas Ramasubramani (https://github.com/vyasr) URL: #493
Contributes to rapidsai/build-planning#208 #1162 temporarily removed the `cudf` test-time dependency here, because there weren't yet CUDA 13 `cudf` packages. Those now exist (rapidsai/cudf#19768), so this restores that dependency. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1164
Contributes to rapidsai/build-planning#208 #1536 temporarily removed the `cudf` test-time dependency here, because there weren't yet CUDA 13 `cudf` packages. Those now exist (rapidsai/cudf#19768), so this restores that dependency. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) - Peter Andreas Entschev (https://github.com/pentschev) URL: #1544
Contributes to rapidsai/build-planning#208
cuda-nvvm-toolsas a runtime dependency ofcudfconda packagesContributes to rapidsai/build-planning#68
dependencies.yamlmatrices (i.e., the ones that get written topyproject.tomlin source control)Notes for Reviewers
This switches GitHub Actions workflows to the
cuda13.0branch from here: rapidsai/shared-workflows#413A future round of PRs will revert that back to
branch-25.10, once all of RAPIDS supports CUDA 13.This has dependencies
Need these to be merged first:
decimal(precision=None)test #19821