Fix dask_setup and cleanup#1541
Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-25.10from Aug 27, 2025
Merged
Conversation
pentschev
added
bug
pentschev
commented
Aug 26, 2025
Comment on lines
+48
to
+51
| if ( | ||
| distributed.comm.ucx.cuda_context_created is False | ||
| or distributed.comm.ucx.cuda_context_created.has_context | ||
| ): |
Member
Author
There was a problem hiding this comment.
This would normally deserve a better fix, but since we're dropping that piece of code soon (within a week) with UCX-Py archive it's not worth spending more time on it.
3 tasks
TomAugspurger
approved these changes
Aug 26, 2025
2 tasks
Member
|
@pentschev @TomAugspurger can this be merged? I think |
Contributor
|
Yep. I think Peter is out today, so I'll merge this and keep an eye on CI. |
Contributor
|
/merge |
Member
|
Thank you! |
Member
Author
|
Thanks Tom. I'm mostly out today indeed, but I'm pretty sure the failure is not related to Dask, see the (or one of, haven't checked all the log) actual failure here. |
Member
|
Oh thank you! Did not see that hiding in those logs too... ok maybe we had 2 problems there 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused
dask_setuparguments, leaving only--create-cuda-contextusingworker._protocolto determine the protocol correctly instead of the incorrect "overload" of the argument fromcli.py. Additionally add tests to check thatdask_setupis called.Fixes #1540 .