Update identify_stream_usage CUDA runtime hooks to CUDA 13#19807
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from Aug 27, 2025
Merged
Conversation
The kernel launch and memcpyasync API have changed and we need updates to work properly.
robertmaynard
added
bug
davidwendt
approved these changes
Aug 27, 2025
Contributor
davidwendt
left a comment
davidwendt
left a comment
There was a problem hiding this comment.
Verified this works on my local machine.
Contributor
|
Reference #19768 |
PointKernel
approved these changes
Aug 27, 2025
vuule
approved these changes
Aug 27, 2025
Comment on lines
+214
to
+215
| // We need to define the __cudaLaunchKernel ABI as | ||
| // it isn't part of cuda_runtime.h when compiling as a C++ source |
Contributor
There was a problem hiding this comment.
do we know why this is the case in CUDA 13?
Contributor
There was a problem hiding this comment.
They changed their API.
My understanding is that the <<< >>> pattern changed to map to a different API which we need to now override.
The internal __cudaLaunchKernel declaration is hidden under ifdef __CUDACC__ in the header files in 13 which makes sense given how it is intended to be used. We just need to hook it here (without calling it) so the forward references are required in this .cpp file.
ttnghia
approved these changes
Aug 27, 2025
Contributor
|
/merge |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The kernel launch and memcpyasync API have changed and we need updates to work properly.
Checklist