Skip to content

Add cuda-nvvm-tools to depend on libdevice #46

Merged
kkraus14 merged 1 commit into
conda-forge:mainfrom
brandon-b-miller:fix-missing-libdevice
Aug 27, 2025
Merged

Add cuda-nvvm-tools to depend on libdevice #46
kkraus14 merged 1 commit into
conda-forge:mainfrom
brandon-b-miller:fix-missing-libdevice

Conversation

@brandon-b-miller
Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@brandon-b-miller
Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17273626998. Examine the logs at this URL for more detail.

@kkraus14
Copy link
Copy Markdown
Contributor

@brandon-b-miller should we do a repodata patch to fix this for past releases?

@kkraus14 kkraus14 merged commit e3aec85 into conda-forge:main Aug 27, 2025
5 checks passed
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Aug 27, 2025

Has this been tested with cuda-version=12.0? See conda-forge/cuda-python-feedstock#129.

@kkraus14
Copy link
Copy Markdown
Contributor

Has this been tested with cuda-version=12.0? See conda-forge/cuda-python-feedstock#129.

No... good catch, we'll need to resolve this. Apologies.

@kkraus14
Copy link
Copy Markdown
Contributor

@brandon-b-miller I think we can change cuda-nvvm-tools to cuda-nvcc-tools where in 12.0 and 12.1 it contained libdevice.10.bc and then in 12.2+ it depends on cuda-nvvm-tools

@bdice
Copy link
Copy Markdown
Contributor

bdice commented Aug 27, 2025

The narrower solution is to depend on cuda-nvcc-impl, which is what we settled on for cuda-python after some discussion and exploration. (I think the components needed are the same here.) I would prefer to be consistent here, and use the smallest dependency that satisfies our needs.

@brandon-b-miller brandon-b-miller deleted the fix-missing-libdevice branch August 27, 2025 21:59
@brandon-b-miller
Copy link
Copy Markdown
Contributor Author

Will follow up with a change here 👍

rapids-bot Bot pushed a commit to rapidsai/cudf that referenced this pull request Aug 29, 2025
CUDA 13 support was initially added here in #19768 

During that work, we faced some runtime issues with conda packages that @brandon-b-miller diagnosed as a missing dependency in `numba-cuda` (NVIDIA/numba-cuda#430).

To get past that, we temporarily introduced a runtime dependency on `cuda-nvvm-tools` in this project. That's no longer necessary, thanks to these:

* conda-forge/numba-cuda-feedstock#47
* conda-forge/numba-cuda-feedstock#46

This removes that workaround.

## Notes for Reviewers

### Don't we need to change the `numba-cuda` pin?

No, the fixes are just in new builds of 0.19.1.

#

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - https://github.com/brandon-b-miller
  - Jake Awe (https://github.com/AyodeAwe)

URL: #19842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants