revert numba CUDA 13 workaround#19842
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from Aug 29, 2025
jameslamb:revert-numba-workaround
Merged
revert numba CUDA 13 workaround#19842rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from jameslamb:revert-numba-workaround
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from
jameslamb:revert-numba-workaround
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test |
jameslamb
changed the title
brandon-b-miller
approved these changes
Aug 29, 2025
Contributor
brandon-b-miller
left a comment
brandon-b-miller
left a comment
There was a problem hiding this comment.
Thanks for staying on top of this @jameslamb !
AyodeAwe
approved these changes
Aug 29, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CUDA 13 support was initially added here in #19768
During that work, we faced some runtime issues with conda packages that @brandon-b-miller diagnosed as a missing dependency in
numba-cuda(NVIDIA/numba-cuda#430).To get past that, we temporarily introduced a runtime dependency on
cuda-nvvm-toolsin this project. That's no longer necessary, thanks to these:cuda-nvvm-toolswithcuda-nvcc-implconda-forge/numba-cuda-feedstock#47cuda-nvvm-toolsto depend on libdevice conda-forge/numba-cuda-feedstock#46This removes that workaround.
Notes for Reviewers
Don't we need to change the
numba-cudapin?No, the fixes are just in new builds of 0.19.1.
Checklist