[only21mil]

Problem

Clicking a terminal URL or file path containing CJK characters opens a truncated link. For example, https://ja.wikipedia.org/wiki/日本語 resolves to https://ja.wikipedia.org/wiki/日. A trailing emoji's second terminal cell can also fall outside the clickable range.

Ghostty represents wide glyphs with spacer cells. Link reconstruction currently turns those spacers into spaces, which terminate the URL and path matchers.

Change

Treat Ghostty spacer heads and tails as zero-length text while preserving actual blank cells. Use the same lengths when converting terminal columns to text offsets. A click on a spacer tail belongs to its glyph, and the underline includes both cells of a final wide glyph.

The change stays in the Ghostty link mapping. It does not change the shared URL or path patterns. Focused tests cover CJK URLs and paths, a trailing emoji, a wide character wrapping onto the next row, and a real blank that must still end a link.

Scope and approval

This is a small, focused fix for an existing terminal link defect under the exception in CONTRIBUTING.md. No new setting or product behavior is added.

Prior PRs: #10815, by Satyal Yadav, identified and attempted the same spacer-cell fix. It closed because the browser verification claim lacked visual evidence. The closing comment requested a before/after recording highlighting and opening a CJK or emoji link. This includes that evidence and credits the earlier work. The Unicode path matcher work in #20264, by Maseeek and Julius Marminge, is already present and remains unchanged.

Verification

• With the new tests and unchanged main production code, all four regressions fail. With the fix, all 71 tests pass: pnpm --filter @t3tools/web exec vp test run src/terminal/ghostty/surface.test.ts src/terminal-links.test.ts --project unit.
• Changed-file vp lint and vp fmt --check pass. vp run --filter @t3tools/web typecheck passes with existing suggestion diagnostics.
• Built the base and fixed web clients with pnpm --filter @t3tools/web build and ran them against a production server bundle with separate temporary state. Drove the real integrated terminal in Chrome on Linux. No provider run or provider credential was needed.
• Printed a CJK URL to a local HTTP endpoint that displays the requested path, then hovered and Ctrl-clicked it. Before, the underline ends at the first CJK character and the opened tab shows /demo/日. After, the full link underlines and the opened tab shows /demo/日本語. The fixed run also clicked the final wide glyph.

Not checked: macOS and Windows native clients, external editor launches, and mobile. Mobile uses a separate terminal implementation. The desktop client shares the changed web terminal, but Electron itself was not exercised.

The images below crop the real terminal above and the tab opened by its click below.

Before: the CJK URL opens only /demo/日.

After: the full URL opens /demo/日本語.

Animated recording: actual terminal hover and opened tabs before and after, with cuts between the tabs.

Regression failures on main production code:

The same regressions and existing terminal tests pass with the fix:

Production fix, tests, PR description and images written with GPT-6.1 Sol in T3 Code Nightly.

🤖 Generated with GPT-6.1 Sol in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Approved at 582b169

Macroscope's review found this PR approvable — This is a focused web-terminal bug fix that preserves wide CJK and emoji characters in existing links while keeping ordinary blank cells as link boundaries. The production change is localized to Ghostty link coordinate mapping and is covered by targeted regression tests.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Warning

Review limit reached

Only developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: aa2c80b
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: b164cf2e-230d-4310-a319-0b8d4c33093c

Commits

Reviewing files that changed from the base of the PR and between 582b169 and 4a4ed8a.

Files selected for processing: 3

• apps/web/src/terminal/ghostty/core.ts
• apps/web/src/terminal/ghostty/surface.test.ts
• apps/web/src/terminal/ghostty/surface.ts

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 807319c
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 481c06ca-d938-4cae-b3b6-78a626c7d04e

📥 Commits

Reviewing files that changed from the base of the PR and between 807319c and 582b169.

📒 Files selected for processing: 2

• apps/web/src/terminal/ghostty/surface.test.ts
• apps/web/src/terminal/ghostty/surface.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

Terminal link detection now excludes wide-cell spacers from reconstructed link text and offsets. Hit-testing maps spacer tails to their heads, and link ranges cover trailing spacer tails. Tests cover Unicode links and wrapped links.

Changes: Terminal link detection

Layer / File(s)	Summary
Wide-cell-aware link detection apps/web/src/terminal/ghostty/surface.ts, apps/web/src/terminal/ghostty/surface.test.ts	Cell text and column offsets omit wide-cell spacers. Hit-testing maps spacer tails to their heads, and link ranges include trailing spacer tails. Tests cover Unicode URLs and paths, wrapped links, and terminating blank cells.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 582b1

No actionable issue remains identified; the change is mergeable after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preserving wide characters in terminal links.
Description check		The description covers the problem, change, scope and approval rationale, verification results, limitations, and visual evidence. It matches the repository template and provides sufficient technical d…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description covers the problem, change, scope and approval rationale, verification results, limitations, and visual evidence. It matches the repository template and provides sufficient technical detail.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @only21mil. your spacer-aware link mapping is preserved, including clicks on wide-character tails and the full underline range. i merged current main into your branch and pushed the follow-up to this pr.

the missing case was in production decoding: a final-column wrap spacer after a spacer tail was never classified. the decoder now checks that final column too. the four regressions now use real ghostty wasm snapshots instead of fabricated cells. this reduces the test setup while covering the actual decoding path. the final diff against main is 3 files, 57 insertions and 5 deletions.

verification at 4a4ed8a838ba1f01cd371ad0adaf7a183d847272:

• all four regressions fail on main. the original fix passes three but still fails the wrap case.
• blacksmith: 88 focused tests pass across ghostty core, surface, and terminal links. vp run check:changed passes format, lint, knip, affected typechecks, and adjacent tests.
• real dev app and system chrome: printed the same cjk url through the integrated shell, hovered and ctrl-clicked it. main opened /demo/日; this head opens /demo/日本語. also clicked the final wide cell of a wrapped url with a spacer head after a spacer tail and confirmed the complete destination.
• all 28 ci checks pass. two independent gpt-6.1-sol reviewers approve this exact head with no findings.
• unverified: native electron, macos/windows, mobile, and external editor launches. coderabbit's automatic update review was rate limited; its check is green. web and desktop share the changed terminal implementation; mobile uses a separate one.

before and after use matching terminal output. each image shows the hovered terminal above and the destination opened by its click below.

short recording of the fixed hover and opened destination, with a cut between tabs:

git.cafe currently renders these external media embeds as links. the uploaded images load correctly in chrome, and video playback and seeking are verified. a native git.cafe attachment attempt returned 409 stale-operation, so inline media rendering on git.cafe remains unverified.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 4a4ed8a838ba1f01cd371ad0adaf7a183d847272 on this linux boat vm. no source changes or pushes were needed.

• installed and ran github/main (3ef1610079) in ../main, then stopped it before starting this exact pr head. both used fresh, isolated state with no seeded data.
• drove the actual web app with the repo's playwright and /usr/bin/google-chrome. added the real git repository through the app, created threads, and completed real codex gpt-6.1-sol turns on both versions. each turn ran printf and returned the requested unicode text.
• printed matching output through the integrated terminal. on main, ctrl-clicking http://localhost:9311/demo/日本語 opened only /demo/日. this head underlines and opens the complete /demo/日本語, including a click on the final glyph's second cell.
• verified an emoji link's second cell opens the complete /demo/🙂. verified a 150-column wrapped url with a wide glyph, its tail, and a final-column wrap spacer opens the complete destination when clicked on the next row's final tail.
• nearby behavior: the ascii link opens /ascii; a real space ends the link, and ctrl-clicking the following next opens no tab. a real cjk file path with a line/column suffix gets its complete underline.
• blacksmith: 88 existing focused tests pass across ghostty core, surface, and terminal links. vp run check:changed aa2c80b9e3b093ebe382bf0a555ce2dd0dc33d22 passes format, lint, both knip passes, affected typechecks, and 49 adjacent tests. the pr reports 28 successful ci checks, zero failing or pending.

the local destination server recorded the paths actually requested by the terminal clicks:

main click                 GET /demo/日
pr click and final tail    GET /demo/日本語
pr emoji tail              GET /demo/🙂
pr wrapped final tail      GET /wrap/<120 a characters>日本
pr ascii                   GET /ascii
pr space-separated next    no tab opened

matching terminal output is above the opened destination in each image.

the recording shows ctrl-hover, clicking the final wide cell, and the opened destination, with a cut between tab views. inspected the captures and verified uploaded video playback and seeking in chrome.

Not verified

native electron, macos/windows, and ios/android were not exercised on this linux vm. mobile has a separate terminal implementation. external editor launch and line/column navigation remain unverified because no supported external editor is installed. settings' provider-auth terminal and non-codex providers were not exercised. the vm's existing chrome renderer displayed the emoji as a missing glyph, so emoji appearance is unverified; its full unicode destination and second-cell activation were verified.

git.cafe renders the external evidence embeds as links. the uploaded images load, and the uploaded video plays and seeks in chrome; inline media rendering in git.cafe is unverified.