fix(desktop): hold-to-quit no longer strands the quit

[maria-rcks]

On macOS, holding Cmd+Q past the hold threshold concealed the window but never quit, and a lone Cmd tap some time later quit the app instantly. Once the hold completed, a Q auto-repeat arriving after the modifier keyUp ran clearWatchdog() and left the handler waiting for a Q keyUp that macOS does not reliably deliver, so the quit sat armed indefinitely with no timer behind it — and the next modifier keyUp, from any unrelated Cmd press, revived it.

A Q keydown proves the key is still physically down whether or not the modifier is still held, so it now pushes the quiet period back instead of disarming it. Continued repeats keep the app alive exactly as before; when they stop, the quiet period commits the quit, and quitOnRelease can no longer outlive the gesture.

Verified: vp test run on apps/desktop/src/window/QuitHold.test.ts — 31 passed, and the new case fails against the pre-fix module (expected quit to be called 1 times, but got 0). vp run --filter @t3tools/desktop typecheck — exit 0, no new diagnostics. vp lint and vp fmt --check on both changed files — clean. Note: vite-plus/test resolves to a second vitest instance on this Linux sandbox, so every suite in the repo fails to load with Cannot read properties of undefined (reading 'config') on origin/main too; the runs above used an equivalent copy importing vitest directly, discarded afterwards.

Desktop-only: the quit accelerator is intercepted in the Electron main process before-input-event handler, so there is no web or mobile equivalent to fix.

Fixes #9259

Done by Claude Opus 5 (1M context) in Claude Code.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved quit shortcut handling when key-release events are missed.
  • Repeated key presses now keep the pending quit active until the final release.
  • Prevented an additional quit from being triggered by a subsequent modifier-key tap.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a44e52d7-6a22-48fc-8287-cc1cb5bfd8d7

📥 Commits

Reviewing files that changed from the base of the PR and between 78a4c88 and 176d804.

📒 Files selected for processing (1)

• apps/desktop/src/window/QuitHold.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/desktop/src/window/QuitHold.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The quit hold handler now keeps the quiet-period watchdog active after modifier release. Tests cover delayed quitting, a missing final Q release, and prevention of a later standalone Cmd tap from quitting again.

Changes

Quit hold behavior

Layer / File(s)	Summary
Preserve pending quit after modifier release apps/desktop/src/window/QuitHold.ts, apps/desktop/src/window/QuitHold.test.ts	Repeated Q keydown events always restart the quiet period. Tests verify quitting after Q release or after a missing final Q release, and verify that a later standalone Cmd tap does not trigger another quit.

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 176d8

The macOS Cmd+Q hold behavior now preserves the pending quit through modifier release and avoids stale quits on a later Cmd press. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main fix: preventing macOS hold-to-quit from becoming stranded.
Description check	✅ Passed	The description clearly explains the failure, the fix, affected scope, validation results, and linked issue. It does not use the template headings or checklist, but it contains the required informatio…
Linked Issues check	✅ Passed	The implementation and regression tests address issue #9259. Repeated Q keydowns after Cmd release now preserve the pending quit, the quit completes when repeats stop, and a later standalone Cmd press…
Out of Scope Changes check	✅ Passed	The changes are limited to the desktop quit handler and its regression tests. They directly support the linked issue and stated objectives, with no unrelated code changes identified.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 176d804

Macroscope's review found this PR approvable — This is a narrowly scoped desktop quit-gesture bug fix: Q repeats now keep the committed quit timer alive after modifier release, while a missing final key-up still leads to an eventual quit. The production change is small and accompanied by focused regression tests.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 176d804