Conversation
mattsse
force-pushed
the
matt/add-crate-template
branch
from
cdd47b4 to
57a2b2d
Compare
clabby
pushed a commit
to clabby/reth
that referenced
this pull request
Mar 5, 2023
Move feature flags below comments
clabby
added a commit
to clabby/reth
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
clabby
added a commit
to clabby/reth
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
tcoratger
pushed a commit
to tcoratger/reth
that referenced
this pull request
Jul 16, 2024
Draft of generic impl
AshinGau
added a commit
to AshinGau/reth
that referenced
this pull request
Sep 11, 2024
…gmxyz#2) Improve asynchronous framework and yield IO operations. Add test in `grevm_test.rs`. This may not be standardized, but the entire framework is not yet perfect and the mock difficulty is relatively high, so the main process was written separately for testing. The file will be deleted later. Comparison of two tests: 1. `test_parallel_without_yield`: not yield IO operations, and are running with CPU operations. Total time of 12s. 2. `test_parallel_with_yield`: yield IO operations, and are running in separate thread pool. Total time of 5s.
AshinGau
added a commit
to AshinGau/reth
that referenced
this pull request
Oct 13, 2024
…gmxyz#2) Improve asynchronous framework and yield IO operations. Add test in `grevm_test.rs`. This may not be standardized, but the entire framework is not yet perfect and the mock difficulty is relatively high, so the main process was written separately for testing. The file will be deleted later. Comparison of two tests: 1. `test_parallel_without_yield`: not yield IO operations, and are running with CPU operations. Total time of 12s. 2. `test_parallel_with_yield`: yield IO operations, and are running in separate thread pool. Total time of 5s.
liamaharon
added a commit
to liamaharon/reth
that referenced
this pull request
Oct 19, 2024
Closed
1 task
zilayo
referenced
this pull request
in zilayo/reth
May 29, 2025
fix: hardcode tx gas used to avoid invalid block payload
1 task
yongkangc
added a commit
that referenced
this pull request
Feb 6, 2026
Previously, after on_save_blocks committed blocks (fsync #1), the persistence thread ran pruning in a separate MDBX write transaction with its own commit (fsync #2). During this entire pruning pass, the persistence thread could not process new requests. Merge pruning into the same write transaction as save_blocks by calling Pruner::run_with_provider() with the existing provider_rw before commit. This eliminates the second fsync entirely — one write transaction, one commit, one fsync per cycle. Prune errors are caught and logged but do not prevent block persistence. This preserves the existing guarantee that blocks are always committed regardless of prune outcome. Based on bench metrics (rf7d8): save p50=305ms, prune p50=128ms firing every other save. Prune accounts for 14.9% of total persistence wall time (53s / 356s). This change eliminates ~128ms of redundant fsync latency on every prune cycle. Amp-Thread-ID: https://ampcode.com/threads/T-019c3183-3b50-7379-8a4b-42f7a68aac22
This was referenced Feb 6, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add reth template with some sensible default clippy configs
see also https://github.com/rust-lang/rust-clippy
https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html
This is intended to be temporarily included in this monorepo so all new crates will use same default clippy config etc...
alternatively, there's clippy.toml but this is unstable and not everything is supported