Conversation
onbjerg
approved these changes
Sep 21, 2022
gakonst
added a commit
that referenced
this pull request
Feb 15, 2023
unfortunately alpine seems to be causing issues when used in hive
/reth.sh: line 78: /usr/local/bin/reth: cannot execute: required file not found
presumably because of some glibc issue
Running uname in the reth.sh we get a 64 linux machine:
Linux dc5b3a394e6c 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 x86_64 Linux
So maybe we would run docker build with --platform=linux/amd64, but this also did not work
=> [builder 4/4] RUN cd reth && cargo build --all --locked --profile release 418.3s
=> => # <jemalloc>: MADV_DONTNEED does not work (memset will be used instead)
=> => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
=> => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
=> => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
=> => # <jemalloc>: MADV_DONTNEED does not work (memset will be used instead)
=> => # <jemalloc>: (This is the expected behaviour if you are running under QEMU)
invalid character 'c' looking for beginning of value
So I decided to bite the bullet and just switch this over to Ubuntu, and if it's a problem
we will fix it later.
clabby
referenced
this pull request
in clabby/reth
Mar 5, 2023
Small changes to the deposit tx primitive
1 task
This was referenced Mar 8, 2024
1 task
Closed
1 task
Jackmeng1985
added a commit
to Jackmeng1985/reth
that referenced
this pull request
Jul 19, 2024
This was referenced Sep 2, 2025
Closed
s1na
pushed a commit
to s1na/reth
that referenced
this pull request
Sep 11, 2025
…igmxyz#1) When profiling is enabled, send SIGINT directly to samply process instead of process group. This allows samply to properly shut down its profiling threads and forward the signal to the reth child process, preventing the SendError panic during profiler cleanup. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
1 task
yongkangc
added a commit
that referenced
this pull request
Feb 6, 2026
Previously, after on_save_blocks committed blocks (fsync #1), the persistence thread ran pruning in a separate MDBX write transaction with its own commit (fsync #2). During this entire pruning pass, the persistence thread could not process new requests. Merge pruning into the same write transaction as save_blocks by calling Pruner::run_with_provider() with the existing provider_rw before commit. This eliminates the second fsync entirely — one write transaction, one commit, one fsync per cycle. Prune errors are caught and logged but do not prevent block persistence. This preserves the existing guarantee that blocks are always committed regardless of prune outcome. Based on bench metrics (rf7d8): save p50=305ms, prune p50=128ms firing every other save. Prune accounts for 14.9% of total persistence wall time (53s / 356s). This change eliminates ~128ms of redundant fsync latency on every prune cycle. Amp-Thread-ID: https://ampcode.com/threads/T-019c3183-3b50-7379-8a4b-42f7a68aac22
This was referenced Feb 6, 2026
AnilChinchawale
added a commit
to AnilChinchawale/reth
that referenced
this pull request
Feb 24, 2026
Implement XdcStateRootCache to handle state root divergence between XDC clients at checkpoint blocks (every 900 blocks). This is critical for sync stability. Key features: - Persistent mapping of remote (geth v2.6.8) → local state roots - Thread-safe with parking_lot::RwLock - 10M entry capacity to prevent eviction crashes - Auto-persist every 100 blocks - Backward scan on startup (last 10K blocks) to prevent genesis rewind - CSV format for disk storage (human-readable, debuggable) - Comprehensive test coverage The cache prevents the paradigmxyz#1 bug across XDC clients: chain rewind on restart due to state root mismatches at checkpoint reward blocks. Reference: Nethermind XdcStateRootCache implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add same rustfmt.toml as foundry