Skip to content

feat: add core crate#3

Merged
gakonst merged 4 commits intomasterfrom
matt/core-crate
Sep 27, 2022
Merged

feat: add core crate#3
gakonst merged 4 commits intomasterfrom
matt/core-crate

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 22, 2022

add reth-core crate

this is supposed to provide all necessary eth-related types, which will be required by almost any other crate.

atm this just reexports eth-core.

@rakita
Copy link
Collaborator

rakita commented Sep 25, 2022

core crate mostly has a different meaning in clients:
https://github.com/ethereum/go-ethereum/tree/master/core
https://github.com/openethereum/openethereum/tree/main/crates/ethcore

wdyt about the name reth-primitives?

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 25, 2022

primitives is great! let's go with that!

@gakonst
Copy link
Member

gakonst commented Sep 26, 2022

yeah let's call this primitives, sgtm

-.-

Co-authored-by: rakita <rakita@users.noreply.github.com>
@gakonst gakonst merged commit 4dc32e9 into master Sep 27, 2022
@gakonst gakonst deleted the matt/core-crate branch September 27, 2022 17:19
clabby added a commit to clabby/reth that referenced this pull request Aug 13, 2023
Resolution checkpoint

Resolution checkpoint paradigmxyz#2

Resolution checkpoint paradigmxyz#3

x

Resolution checkpoint paradigmxyz#4

Resolution checkpoint paradigmxyz#5

Resolution checkpoint paradigmxyz#6

Resolution checkpoint paradigmxyz#7

Resolution checkpoint paradigmxyz#8

Resolve checkpoint paradigmxyz#9 (transaction primitive)

Resolve checkpoint paradigmxyz#10 (rpc api transactions)

Resolve checkpoint paradigmxyz#11 (building w/o feature flag)

Start review

Compiling with and without `optimism` feature flag

Remove `DepositTx` from txpool mock tests, they never go into the txpool

fmt

code lint

fix signature tests

Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>

Use free CI runners (revert before upstream)

Co-authored-by: refcell <abigger87@gmail.com>

Signature test fixes

Co-authored-by refcell <abigger87@gmail.com>

Fix Receipt proptest

Co-authored-by BB <brian.t.bland@gmail.com>

lint

Fix variable-length compact for txtype/transaction

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>

Fix basefee tests

Remove unnecessary rpc deps

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
Co-authored-by: Roberto <bayardo@alum.mit.edu>
clabby added a commit to clabby/reth that referenced this pull request Aug 13, 2023
Resolution checkpoint

Resolution checkpoint paradigmxyz#2

Resolution checkpoint paradigmxyz#3

x

Resolution checkpoint paradigmxyz#4

Resolution checkpoint paradigmxyz#5

Resolution checkpoint paradigmxyz#6

Resolution checkpoint paradigmxyz#7

Resolution checkpoint paradigmxyz#8

Resolve checkpoint paradigmxyz#9 (transaction primitive)

Resolve checkpoint paradigmxyz#10 (rpc api transactions)

Resolve checkpoint paradigmxyz#11 (building w/o feature flag)

Start review

Compiling with and without `optimism` feature flag

Remove `DepositTx` from txpool mock tests, they never go into the txpool

fmt

code lint

fix signature tests

Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>

Use free CI runners (revert before upstream)

Co-authored-by: refcell <abigger87@gmail.com>

Signature test fixes

Co-authored-by refcell <abigger87@gmail.com>

Fix Receipt proptest

Co-authored-by BB <brian.t.bland@gmail.com>

lint

Fix variable-length compact for txtype/transaction

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>

Fix basefee tests

Remove unnecessary rpc deps

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
Co-authored-by: Roberto <bayardo@alum.mit.edu>
mattsse pushed a commit that referenced this pull request Aug 13, 2024
AshinGau added a commit to AshinGau/reth that referenced this pull request Sep 11, 2024
Fix: simplify block_in_place function call
joshieDo added a commit that referenced this pull request Sep 27, 2024
zilayo pushed a commit to zilayo/reth that referenced this pull request May 29, 2025
s1na pushed a commit to s1na/reth that referenced this pull request Sep 11, 2025
…paradigmxyz#3)

* feat: add cache clearing and warmup before benchmarks

- Clear filesystem caches (page cache, dentries, inodes) before each benchmark run
- Add 10-block warmup run after cache clearing to warm up caches
- Warmup runs without output directory to minimize overhead
- Handles cases where sudo permissions are not available with warnings

This ensures more consistent benchmark results by starting each run from a known cache state.

* feat: make warmup blocks configurable via CLI

- Add --warmup-blocks CLI argument with default value of 10
- Store warmup_blocks in BenchmarkRunner struct
- Simplify run_warmup method to use stored value
- Users can now customize warmup duration: --warmup-blocks 5

* feat: make warmup blocks default to benchmark blocks count

- Change --warmup-blocks to default to --blocks value when not specified
- Add get_warmup_blocks() method to handle the default logic
- Update help text to clarify the default behavior
- Add comprehensive tests for the new default behavior

This ensures warmup covers the same range as the benchmark by default,
while still allowing explicit override with --warmup-blocks.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Only clear fs caches prior to warmup, and unwind back to starting block after warmup

* Output starting/ending timestamps of benchmark runs

* chrono serde

* Run warmup prior to benchmark loop, not within it

* Compile binaries before warmup, use git hash instead of ref for binary caching

* Deduplicate commit refs

---------

Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
jenpaff pushed a commit that referenced this pull request Oct 6, 2025
* feat: added BalanceChange and CodeChange for BAL

* fixes
felicityin added a commit to felicityin/reth that referenced this pull request Dec 31, 2025
AnilChinchawale added a commit to AnilChinchawale/reth that referenced this pull request Mar 2, 2026
…with FCU feeder v3

- Issue paradigmxyz#3 (stages show 0): Expected behavior during initial sync
  - Stages update after pipeline commits, not during download
  - Downgraded to P3

- Issue paradigmxyz#5 (FCU feeder): SOLVED
  - Created reth-fcu-feeder-v3.py with genesis as finalizedBlockHash
  - Key insight: using genesis triggers proper backfill sync

- APO Reth now actively syncing at 11.5M blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants