feat(rpc): add rpc types and interface defintions#8
Conversation
mattsse
force-pushed
the
matt/rpc-support
branch
from
18ff72c to
7e1ef19
Compare
mattsse
force-pushed
the
matt/rpc-support
branch
from
7e1ef19 to
ac1ec25
Compare
| @@ -0,0 +1,25 @@ | |||
| //! Ethereum related types | |||
There was a problem hiding this comment.
It seems that rust is moving away from using mod.rs as main way to specify modules: https://doc.rust-lang.org/book/ch07-05-separating-modules-into-different-files.html#alternate-file-paths
should we do the same?
There was a problem hiding this comment.
personally, I'm not a fan of declaring modules as files, but that's just because I'm not used to it.
we should decide this for the entire codebase and be consistent.
There was a problem hiding this comment.
I'm a bit conflicted on it - I'm used to mod.rs by now, but honestly mod.rs has always been a bit opaque to me, you never know what's in there. Some people put nothing in there (just re-exports and docs, maybe a prelude module), others put the bulk of their impl in there. I could go either way but I might slightly favor cutting mod.rs?
There was a problem hiding this comment.
My experience is I needed no insignificant time to get used to not having mod.rs, as I prefer it more. But now, consistency is more important and I don't mind it. The reason why I am mentioning it is that rustlang, is moving to no mod.rs way and in that sense, it is becoming "idiomatic" way to use modules.
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
looks good, left a few nitpick comments
onbjerg
left a comment
onbjerg
left a comment
There was a problem hiding this comment.
Should we also implement the debug namespace (getRawHeader, getRawBlock, getRawTransaction, getRawReceipts, getBadBlocks)? It is a part of the official execution client RPC spec.
Some other missing ones:
eth_createAccessListeth_signeth_signTransactioneth_getProof
Source: https://ethereum.github.io/execution-apis/api-documentation/
We probably also need to support the engine API (auth spec, RPC spec).
|
good point, will add |
|
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
…igmxyz#8) - Implement cache layer for scheduler and partition without mutex. - Reformat grevm crate code with rustfmt: ``` cargo fmt -p reth-grevm ```
…igmxyz#8) - Implement cache layer for scheduler and partition without mutex. - Reformat grevm crate code with rustfmt: ``` cargo fmt -p reth-grevm ```
chore: upgrade to latest reth
4 participants
adds 3 crates: