Conversation
mattsse
left a comment
There was a problem hiding this comment.
should we move this into a subfolder called net?
so ./net/p2p or ./net/devp2p?
I can imagine we'll need additional stuff related to p2p, or net in general
|
yeah, there will probably be multiple crates related to networking (sentry? downloader?) so that makes sense |
onbjerg
left a comment
There was a problem hiding this comment.
nit: let's make a habit of writing docs "normal cased"(? is that even a term), so e.g. "networking utilities for reth" -> "Networking utilities for reth"
crates/net/Cargo.toml
Outdated
There was a problem hiding this comment.
I don't think we need to make net a crate itself.
| [package] | |
| name = "reth-net" | |
| version = "0.1.0" | |
| edition = "2021" | |
| license = "MIT OR Apache-2.0" | |
| repository = "https://github.com/foundry-rs/reth" | |
| readme = "README.md" | |
| description = "networking utilities for reth" | |
| [dependencies] |
There was a problem hiding this comment.
afaik cargo doesn't support workspace members without a Cargo.toml, so either we need net as a crate or we would have to specify the subfolders (net/p2p) as individual workspaces. Maybe we can go back to this as p2p and see if the hierarchy makes more sense once more networking related code has been written
There was a problem hiding this comment.
this only works if we're explicitly setting members:
"crates/primitives",
"crates/net/p2p",instead of crates/*
I suggest we just list all crates that we have
There was a problem hiding this comment.
I see, that makes sense. switched to explicitly setting workspace members
crates/net/src/lib.rs
Outdated
There was a problem hiding this comment.
if we need a utils/common crate for net we can just create /net/utils
b0708d7 to
3cce527
Compare
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
Add the core data structure of hint generate 1. `hint.rs` : Responsible for the Init and Update of Parallel Execution Hint, and maintaining the read-write set of a batch of transactions. 2. `tx_dependency.rs` : Maintain dependencies for a batch of transactions and generate optimal partitions. These data structures are uniformly managed by the Scheduler and updated in multiple Rounds to generate the best results.
Add the core data structure of hint generate 1. `hint.rs` : Responsible for the Init and Update of Parallel Execution Hint, and maintaining the read-write set of a batch of transactions. 2. `tx_dependency.rs` : Maintain dependencies for a batch of transactions and generate optimal partitions. These data structures are uniformly managed by the Scheduler and updated in multiple Rounds to generate the best results.
add redis args update reids implementation Merge pull request paradigmxyz#4 from data/merge-upstream-1 merge upstream merge upstream Merge redis implementation to latest tip
* feat: add merkle stage metrics * feat: add blockchain validation metrics * feat: add hash builder metrics * feat: add node iter metrics
* feat: added storage structs as per eip * clippy --------- Co-authored-by: Ishika Choudhury <117741714+Rimeeeeee@users.noreply.github.com>
Co-authored-by: eason <eason@brevis.network>
fix: splitted the sha lookup rule in ecr policy text
adding
reth-p2pbased on the template for now, this should eventually provide nice interfaces for other components to interact with the network.