Skip to content

feat: add p2p crate#4

Merged
gakonst merged 4 commits intomasterfrom
dan/add-p2p
Sep 30, 2022
Merged

feat: add p2p crate#4
gakonst merged 4 commits intomasterfrom
dan/add-p2p

Conversation

@Rjected
Copy link
Member

@Rjected Rjected commented Sep 28, 2022

adding reth-p2p based on the template for now, this should eventually provide nice interfaces for other components to interact with the network.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this into a subfolder called net?
so ./net/p2p or ./net/devp2p?

I can imagine we'll need additional stuff related to p2p, or net in general

@Rjected
Copy link
Member Author

Rjected commented Sep 28, 2022

yeah, there will probably be multiple crates related to networking (sentry? downloader?) so that makes sense

Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's make a habit of writing docs "normal cased"(? is that even a term), so e.g. "networking utilities for reth" -> "Networking utilities for reth"

Comment on lines 1 to 10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to make net a crate itself.

Suggested change
[package]
name = "reth-net"
version = "0.1.0"
edition = "2021"
license = "MIT OR Apache-2.0"
repository = "https://github.com/foundry-rs/reth"
readme = "README.md"
description = "networking utilities for reth"
[dependencies]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik cargo doesn't support workspace members without a Cargo.toml, so either we need net as a crate or we would have to specify the subfolders (net/p2p) as individual workspaces. Maybe we can go back to this as p2p and see if the hierarchy makes more sense once more networking related code has been written

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only works if we're explicitly setting members:

     "crates/primitives",
    "crates/net/p2p",

instead of crates/*

I suggest we just list all crates that we have

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that makes sense. switched to explicitly setting workspace members

Comment on lines 1 to 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we need a utils/common crate for net we can just create /net/utils

@gakonst gakonst merged commit 6ff7cf5 into master Sep 30, 2022
@Rjected Rjected deleted the dan/add-p2p branch October 5, 2022 21:14
clabby added a commit to clabby/reth that referenced this pull request Aug 13, 2023
Resolution checkpoint

Resolution checkpoint paradigmxyz#2

Resolution checkpoint paradigmxyz#3

x

Resolution checkpoint paradigmxyz#4

Resolution checkpoint paradigmxyz#5

Resolution checkpoint paradigmxyz#6

Resolution checkpoint paradigmxyz#7

Resolution checkpoint paradigmxyz#8

Resolve checkpoint paradigmxyz#9 (transaction primitive)

Resolve checkpoint paradigmxyz#10 (rpc api transactions)

Resolve checkpoint paradigmxyz#11 (building w/o feature flag)

Start review

Compiling with and without `optimism` feature flag

Remove `DepositTx` from txpool mock tests, they never go into the txpool

fmt

code lint

fix signature tests

Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>

Use free CI runners (revert before upstream)

Co-authored-by: refcell <abigger87@gmail.com>

Signature test fixes

Co-authored-by refcell <abigger87@gmail.com>

Fix Receipt proptest

Co-authored-by BB <brian.t.bland@gmail.com>

lint

Fix variable-length compact for txtype/transaction

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>

Fix basefee tests

Remove unnecessary rpc deps

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
Co-authored-by: Roberto <bayardo@alum.mit.edu>
clabby added a commit to clabby/reth that referenced this pull request Aug 13, 2023
Resolution checkpoint

Resolution checkpoint paradigmxyz#2

Resolution checkpoint paradigmxyz#3

x

Resolution checkpoint paradigmxyz#4

Resolution checkpoint paradigmxyz#5

Resolution checkpoint paradigmxyz#6

Resolution checkpoint paradigmxyz#7

Resolution checkpoint paradigmxyz#8

Resolve checkpoint paradigmxyz#9 (transaction primitive)

Resolve checkpoint paradigmxyz#10 (rpc api transactions)

Resolve checkpoint paradigmxyz#11 (building w/o feature flag)

Start review

Compiling with and without `optimism` feature flag

Remove `DepositTx` from txpool mock tests, they never go into the txpool

fmt

code lint

fix signature tests

Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>

Use free CI runners (revert before upstream)

Co-authored-by: refcell <abigger87@gmail.com>

Signature test fixes

Co-authored-by refcell <abigger87@gmail.com>

Fix Receipt proptest

Co-authored-by BB <brian.t.bland@gmail.com>

lint

Fix variable-length compact for txtype/transaction

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>

Fix basefee tests

Remove unnecessary rpc deps

Co-authored-by: Brian Bland <brian.t.bland@gmail.com>
Co-authored-by: refcell <abigger87@gmail.com>
Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com>
Co-authored-by: Roberto <bayardo@alum.mit.edu>
mattsse pushed a commit that referenced this pull request Aug 14, 2024
AshinGau pushed a commit to AshinGau/reth that referenced this pull request Sep 11, 2024
Add the core data structure of hint generate
1. `hint.rs` : Responsible for the Init and Update of Parallel Execution
Hint, and maintaining the read-write set of a batch of transactions.
2. `tx_dependency.rs` : Maintain dependencies for a batch of
transactions and generate optimal partitions.
These data structures are uniformly managed by the Scheduler and updated
in multiple Rounds to generate the best results.
AshinGau pushed a commit to AshinGau/reth that referenced this pull request Oct 13, 2024
Add the core data structure of hint generate
1. `hint.rs` : Responsible for the Init and Update of Parallel Execution
Hint, and maintaining the read-write set of a batch of transactions.
2. `tx_dependency.rs` : Maintain dependencies for a batch of
transactions and generate optimal partitions.
These data structures are uniformly managed by the Scheduler and updated
in multiple Rounds to generate the best results.
HenryYYang added a commit to HenryYYang/reth that referenced this pull request Jan 22, 2025
add redis args
update reids implementation
Merge pull request paradigmxyz#4 from data/merge-upstream-1
merge upstream
merge upstream
Merge redis implementation to latest tip
fynnss pushed a commit to fynnss/reth that referenced this pull request Jul 14, 2025
* feat: add merkle stage metrics

* feat: add blockchain validation metrics

* feat: add hash builder metrics

* feat: add node iter metrics
s1na pushed a commit to s1na/reth that referenced this pull request Sep 11, 2025
jenpaff pushed a commit that referenced this pull request Oct 6, 2025
* feat: added storage structs as per eip

* clippy

---------

Co-authored-by: Ishika Choudhury <117741714+Rimeeeeee@users.noreply.github.com>
eason1981 added a commit to brevis-network/reth that referenced this pull request Oct 14, 2025
Co-authored-by: eason <eason@brevis.network>
shemnon pushed a commit to shemnon/reth that referenced this pull request Jan 20, 2026
fix: splitted the sha lookup rule in ecr policy text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants