Conversation
mattsse
approved these changes
Sep 29, 2022
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
should we setup nextest right away?
Collaborator
Author
|
done |
mattsse
approved these changes
Sep 29, 2022
clabby
added a commit
to clabby/reth
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
clabby
added a commit
to clabby/reth
that referenced
this pull request
Aug 13, 2023
Resolution checkpoint Resolution checkpoint paradigmxyz#2 Resolution checkpoint paradigmxyz#3 x Resolution checkpoint paradigmxyz#4 Resolution checkpoint paradigmxyz#5 Resolution checkpoint paradigmxyz#6 Resolution checkpoint paradigmxyz#7 Resolution checkpoint paradigmxyz#8 Resolve checkpoint paradigmxyz#9 (transaction primitive) Resolve checkpoint paradigmxyz#10 (rpc api transactions) Resolve checkpoint paradigmxyz#11 (building w/o feature flag) Start review Compiling with and without `optimism` feature flag Remove `DepositTx` from txpool mock tests, they never go into the txpool fmt code lint fix signature tests Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Use free CI runners (revert before upstream) Co-authored-by: refcell <abigger87@gmail.com> Signature test fixes Co-authored-by refcell <abigger87@gmail.com> Fix Receipt proptest Co-authored-by BB <brian.t.bland@gmail.com> lint Fix variable-length compact for txtype/transaction Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Fix basefee tests Remove unnecessary rpc deps Co-authored-by: Brian Bland <brian.t.bland@gmail.com> Co-authored-by: refcell <abigger87@gmail.com> Co-authored-by: nicolas <48695862+merklefruit@users.noreply.github.com> Co-authored-by: Roberto <bayardo@alum.mit.edu>
fynnss
added a commit
to fynnss/reth
that referenced
this pull request
Jul 28, 2025
* add live sync performance metrics implementation * add block insert total time and remove fcu metrics * fix redundancy metrics for live sync
jenpaff
pushed a commit
that referenced
this pull request
Oct 6, 2025
eason1981
added a commit
to brevis-network/reth
that referenced
this pull request
Oct 14, 2025
Co-authored-by: eason <eason@brevis.network>
shemnon
pushed a commit
to shemnon/reth
that referenced
this pull request
Jan 20, 2026
fix: single ECR repo for images
joshieDo
added a commit
that referenced
this pull request
Feb 4, 2026
…length - Issue #5: Add flush_current_changeset_offset() before reading sidecar in truncate_changesets() to ensure in-memory offset is written - Issue #7: Use ChangesetOffsetReader::with_len() instead of new() to respect committed length from header, ignoring uncommitted records - Add regression tests for both issues - Update changeset-healing-review.md to reflect 17 tests - Remove unused variables in tests
AnilChinchawale
added a commit
to AnilChinchawale/reth
that referenced
this pull request
Mar 2, 2026
…with FCU feeder v3 - Issue paradigmxyz#3 (stages show 0): Expected behavior during initial sync - Stages update after pipeline commits, not during download - Downgraded to P3 - Issue paradigmxyz#5 (FCU feeder): SOLVED - Created reth-fcu-feeder-v3.py with genesis as finalizedBlockHash - Key insight: using genesis triggers proper backfill sync - APO Reth now actively syncing at 11.5M blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.