docs(allocator, data_structures): correct comments#20966
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
docs(allocator, data_structures): correct comments#20966graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
This was referenced Apr 2, 2026
Member
Author
This was referenced Apr 2, 2026
github-actions
bot
added
the
C-docs
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR follows up on #18172 by adjusting a few allocator/data-structure doc comments that were made inaccurate during the “remove bumpalo references” cleanup.
Changes:
- Updates
NonEmptyStackdesign docs to mention a downward-growing stack alternative. - Clarifies allocator chunk minimum alignment in
from_raw_parts. - Tweaks
Allocatorinline rationale comments to describe delegation toBump.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| crates/oxc_data_structures/src/stack/non_empty.rs | Updates design commentary for an alternative stack growth strategy. |
| crates/oxc_allocator/src/from_raw_parts.rs | Clarifies the minimum chunk alignment constant’s relationship to allocator internals. |
| crates/oxc_allocator/src/allocator.rs | Adjusts inline(always) justification comments for wrapper methods. |
This was referenced Apr 2, 2026
overlookmotel
force-pushed
the
om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement
branch
from
b6fe07c to
e76edb0
Compare
overlookmotel
force-pushed
the
om/04-02-docs_allocator_data_structures_correct_comments
branch
from
3e04edd to
ddd06ac
Compare
overlookmotel
added
the
0-merge
Graphite App
Contributor
Merge activity
|
Follow on after #18172. That PR made changes to comments to remove references to `bumpalo` from the codebase. Correct a few of those comments which were incorrect.
graphite-app
bot
force-pushed
the
om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement
branch
from
e76edb0 to
4c37a7a
Compare
graphite-app
bot
force-pushed
the
om/04-02-docs_allocator_data_structures_correct_comments
branch
from
ddd06ac to
b1da750
Compare
Base automatically changed from
om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement
to
main
April 2, 2026 15:16
graphite-app
bot
deleted the
om/04-02-docs_allocator_data_structures_correct_comments
branch
leaysgur
pushed a commit
that referenced
this pull request
Apr 7, 2026
### 🐛 Bug Fixes - fc7f60c allocator: Revert changes to `get_current_chunk_footer_field_offset` (#20964) (overlookmotel) - 31316c8 semantic: Rebind class expressions before identifier checks (#20916) (camc314) ### ⚡ Performance - fb52383 napi/parser, linter/plugins: Clear buffers and source texts earlier (#21025) (overlookmotel) - 3b7dec4 napi/parser, linter/plugins: Use `utf8Slice` for decoding UTF-8 strings (#21022) (overlookmotel) - 012c924 napi/parser, linter/plugins: Speed up decoding strings in raw transfer (#21021) (overlookmotel) - 55e1e9b napi/parser, linter/plugins: Initialize vars as 0 (#21020) (overlookmotel) - c25ef02 napi/parser, linter/plugins: Simplify branch condition in `deserializeStr` (#21019) (overlookmotel) - 9f494c3 napi/parser, linter/plugins: Raw transfer use `String.fromCharCode` in string decoding (#21018) (overlookmotel) - 91cf105 allocator: Increase initial chunk size from 512B to 16KB (#20968) (overlookmotel) - cbc0c21 allocator: Add `#[cold]` to to error handling functions (#20967) (overlookmotel) - 0503a78 napi/parser, linter/plugins: Faster deserialization of `raw` fields (#20923) (overlookmotel) - a24f75e napi/parser: Optimize string deserialization for non-ASCII sources (#20834) (Joshua Tuddenham) ### 📚 Documentation - c78a57a syntax: Fix typo (#21044) (camc314) - f5e228f allocator: Fix typo in comment (#20972) (overlookmotel) - 7159d51 allocator: Improve doc comment examples for `vec2::Vec` (#20969) (overlookmotel) - b1da750 allocator, data_structures: Correct comments (#20966) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on after #18172.
That PR made changes to comments to remove references to
bumpalofrom the codebase. Correct a few of those comments which were incorrect.