refactor(allocator): remove bump field from ChunkIter#20973
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
|
From Copilot's review on fitzgen/bumpalo#319, sounds like this is misguided. It may be OK, but not worth risking it. |

Minor simplification to
Bumpcode.It's unnecessary for
ChunkIterto contain aPhantomData<&'a mut Bump>because it also contains aChunkRawIter<'a, MIN_ALIGN>- and that containsPhantomData<&'a mut Bump>. This is sufficient to "hold" the lifetime for both iterators.Suggested same change upstream: fitzgen/bumpalo#319