Skip to content

refactor(allocator): remove bump field from ChunkIter#20973

Closed
overlookmotel wants to merge 1 commit intoom/04-02-docs_allocator_fix_typo_in_commentfrom
om/04-02-refactor_allocator_remove_bump_field_from_chunkiter_
Closed

refactor(allocator): remove bump field from ChunkIter#20973
overlookmotel wants to merge 1 commit intoom/04-02-docs_allocator_fix_typo_in_commentfrom
om/04-02-refactor_allocator_remove_bump_field_from_chunkiter_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 2, 2026

Minor simplification to Bump code.

It's unnecessary for ChunkIter to contain a PhantomData<&'a mut Bump> because it also contains a ChunkRawIter<'a, MIN_ALIGN> - and that contains PhantomData<&'a mut Bump>. This is sufficient to "hold" the lifetime for both iterators.

Suggested same change upstream: fitzgen/bumpalo#319

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-02-refactor_allocator_remove_bump_field_from_chunkiter_ (c18ae91) with om/04-02-docs_allocator_fix_typo_in_comment (0510d95)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel
Copy link
Copy Markdown
Member Author

From Copilot's review on fitzgen/bumpalo#319, sounds like this is misguided. It may be OK, but not worth risking it.

@overlookmotel overlookmotel deleted the om/04-02-refactor_allocator_remove_bump_field_from_chunkiter_ branch April 2, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant