fix(allocator): revert changes to get_current_chunk_footer_field_offset#20964
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2026
Conversation
Member
Author
This was referenced Apr 2, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a small internal change to get_current_chunk_footer_field_offset in oxc_allocator, aligning it with the current Bump implementation to avoid a potential performance regression in Allocator::from_raw_parts’s layout-deduction path.
Changes:
- Construct the dummy
BumpviaBump::<1>::with_min_align()instead ofBump::new()to keep the offset-deduction code simpler for optimization/const-folding. - Simplify the raw pointer derivation with
ptr::from_ref(&bump)(type inference) while preserving behavior.
This was referenced Apr 2, 2026
Base automatically changed from
om/04-01-refactor_allocator_use_latest_bumpalo_as_base_for_bump_
to
main
April 2, 2026 14:54
5838a7f to
343a594
Compare
Contributor
Merge activity
|
…set` (#20964) Partial revert of #18168. #18168 made a small change to `get_current_chunk_footer_field_offset` (used by `Allocator::from_raw_parts`). That change was correct in the context of the other changes made to `Bump` in that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version of `Bump`.
343a594 to
fc7f60c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Partial revert of #18168.
#18168 made a small change to
get_current_chunk_footer_field_offset(used byAllocator::from_raw_parts).That change was correct in the context of the other changes made to
Bumpin that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version ofBump.