Skip to content

fix(allocator): revert changes to get_current_chunk_footer_field_offset#20964

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_
Apr 2, 2026
Merged

fix(allocator): revert changes to get_current_chunk_footer_field_offset#20964
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 2, 2026

Partial revert of #18168.

#18168 made a small change to get_current_chunk_footer_field_offset (used by Allocator::from_raw_parts).

That change was correct in the context of the other changes made to Bump in that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version of Bump.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 2, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ (343a594) with main (caa2dce)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2026 13:39
Copilot AI review requested due to automatic review settings April 2, 2026 13:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a small internal change to get_current_chunk_footer_field_offset in oxc_allocator, aligning it with the current Bump implementation to avoid a potential performance regression in Allocator::from_raw_parts’s layout-deduction path.

Changes:

  • Construct the dummy Bump via Bump::<1>::with_min_align() instead of Bump::new() to keep the offset-deduction code simpler for optimization/const-folding.
  • Simplify the raw pointer derivation with ptr::from_ref(&bump) (type inference) while preserving behavior.

Base automatically changed from om/04-01-refactor_allocator_use_latest_bumpalo_as_base_for_bump_ to main April 2, 2026 14:54
@overlookmotel overlookmotel force-pushed the om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ branch from 5838a7f to 343a594 Compare April 2, 2026 14:55
@overlookmotel overlookmotel self-assigned this Apr 2, 2026
@overlookmotel overlookmotel added the A-allocator Area - Allocator label Apr 2, 2026
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 2, 2026 — with Graphite App
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 2, 2026

Merge activity

…set` (#20964)

Partial revert of #18168.

#18168 made a small change to `get_current_chunk_footer_field_offset` (used by `Allocator::from_raw_parts`).

That change was correct in the context of the other changes made to `Bump` in that PR, but now that #20963 has rolled back most of those changes, this change needs to be reverted too as it's a potential perf regression with current version of `Bump`.
@graphite-app graphite-app bot force-pushed the om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ branch from 343a594 to fc7f60c Compare April 2, 2026 15:09
@graphite-app graphite-app bot merged commit fc7f60c into main Apr 2, 2026
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2026
@graphite-app graphite-app bot deleted the om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ branch April 2, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants