Skip to content

refactor(allocator): remove unnecessary pub(crate) from mod statement#20965

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement
Apr 2, 2026
Merged

refactor(allocator): remove unnecessary pub(crate) from mod statement#20965
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 2, 2026

Partial revert of #18168.

mod bumpalo_alloc; does not need to be prefixed with pub(crate), as it's defined in crate root. Remove pub(crate), just because it's a bit confusing one that one module has the prefix and none of the others do.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 2, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement (e76edb0) with om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ (343a594)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2026 13:42
Copilot AI review requested due to automatic review settings April 2, 2026 13:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant pub(crate) visibility modifier from the bumpalo_alloc module declaration in oxc_allocator’s crate root, aligning it with the other internal modules and reducing confusion after the partial revert of #18168.

Changes:

  • Change pub(crate) mod bumpalo_alloc; to mod bumpalo_alloc; in crates/oxc_allocator/src/lib.rs.

@overlookmotel overlookmotel force-pushed the om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement branch from b6fe07c to e76edb0 Compare April 2, 2026 14:55
@overlookmotel overlookmotel force-pushed the om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ branch from 5838a7f to 343a594 Compare April 2, 2026 14:55
@overlookmotel overlookmotel self-assigned this Apr 2, 2026
@overlookmotel overlookmotel added the A-allocator Area - Allocator label Apr 2, 2026
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 2, 2026 — with Graphite App
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Apr 2, 2026

Merge activity

…ment (#20965)

Partial revert of #18168.

`mod bumpalo_alloc;` does not need to be prefixed with `pub(crate)`, as it's defined in crate root. Remove `pub(crate)`, just because it's a bit confusing one that one module has the prefix and none of the others do.
@graphite-app graphite-app bot force-pushed the om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ branch from 343a594 to fc7f60c Compare April 2, 2026 15:09
@graphite-app graphite-app bot force-pushed the om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement branch from e76edb0 to 4c37a7a Compare April 2, 2026 15:10
Base automatically changed from om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_ to main April 2, 2026 15:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2026
@graphite-app graphite-app bot merged commit 4c37a7a into main Apr 2, 2026
28 checks passed
@graphite-app graphite-app bot deleted the om/04-02-refactor_allocator_remove_unnecessary_pub_crate_from_mod_statement branch April 2, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants