refactor(allocator): remove unnecessary pub(crate) from mod statement#20965
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2026
Conversation
Member
Author
This was referenced Apr 2, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant pub(crate) visibility modifier from the bumpalo_alloc module declaration in oxc_allocator’s crate root, aligning it with the other internal modules and reducing confusion after the partial revert of #18168.
Changes:
- Change
pub(crate) mod bumpalo_alloc;tomod bumpalo_alloc;incrates/oxc_allocator/src/lib.rs.
This was referenced Apr 2, 2026
b6fe07c to
e76edb0
Compare
5838a7f to
343a594
Compare
Contributor
Merge activity
|
343a594 to
fc7f60c
Compare
e76edb0 to
4c37a7a
Compare
Base automatically changed from
om/04-02-fix_allocator_revert_changes_to_get_current_chunk_footer_field_offset_
to
main
April 2, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Partial revert of #18168.
mod bumpalo_alloc;does not need to be prefixed withpub(crate), as it's defined in crate root. Removepub(crate), just because it's a bit confusing one that one module has the prefix and none of the others do.