Skip to content

docs(allocator, data_structures): correct comments #20966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 2, 2026
+6 −6
Merged

docs(allocator, data_structures): correct comments #20966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/oxc_allocator/src/allocator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ impl Allocator {
/// [`Vec::new_in`]: crate::Vec::new_in
/// [`HashMap::new_in`]: crate::HashMap::new_in
//
// `#[inline(always)]` because it's a small function
// `#[inline(always)]` because just delegates to `Bump` method
#[expect(clippy::inline_always)]
#[inline(always)]
pub fn new() -> Self {
Expand All @@ -268,7 +268,7 @@ impl Allocator {
///
/// See [`Allocator`] docs for more information on efficient use of [`Allocator`].
//
// `#[inline(always)]` because it's a small function
// `#[inline(always)]` because just delegates to `Bump` method
#[expect(clippy::inline_always)]
#[inline(always)]
pub fn with_capacity(capacity: usize) -> Self {
Expand Down Expand Up @@ -506,7 +506,7 @@ impl Allocator {
/// }
/// ```
//
// `#[inline(always)]` because it's a small function
// `#[inline(always)]` because just delegates to `Bump` method
#[expect(clippy::inline_always)]
#[inline(always)]
pub fn reset(&mut self) {
Expand Down Expand Up @@ -536,7 +536,7 @@ impl Allocator {
///
/// [`used_bytes`]: Allocator::used_bytes
//
// `#[inline(always)]` because it's a small function
// `#[inline(always)]` because just delegates to `Bump` method
#[expect(clippy::inline_always)]
#[inline(always)]
pub fn capacity(&self) -> usize {
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_allocator/src/from_raw_parts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use std::{

use crate::{Allocator, bump::Bump};

/// Minimum alignment for allocator chunks.
/// Minimum alignment for allocator chunks. Same as for `Bump`.
const MIN_ALIGN: usize = 16;

const CHUNK_FOOTER_SIZE: usize = size_of::<ChunkFooter>();
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_data_structures/src/stack/non_empty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ use super::{StackCapacity, StackCommon};
/// uses 1 less register, but disadvantage that [`last`] and [`last_mut`] are 2 instructions, not 1.
/// <https://godbolt.org/z/xnx7YP5de>
///
/// 2. Stack could grow downwards, like a bump allocator does. This would probably make [`pop`] use
/// 2. Stack could grow downwards, like `bumpalo` does. This would probably make [`pop`] use
/// 1 less register, but at the cost that: (a) the stack can never grow in place, which would incur
/// more memory copies when the stack grows, and (b) [`as_slice`] would have the entries in
/// reverse order.
Expand Down
Loading