Skip to content

refactor(allocator): add generic param to Bump in ChunkIter#20974

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_
Apr 2, 2026
Merged

refactor(allocator): add generic param to Bump in ChunkIter#20974
graphite-app[bot] merged 1 commit intomainfrom
om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 2, 2026

Refactor. PhantomData<&'a mut Bump> -> PhantomData<&'a mut Bump<MIN_ALIGN>>. The generic param is not necessary here due to the PhantomData wrapper, but it's more explicit and matches ChunkRawIter.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 2, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 2, 2026
@overlookmotel overlookmotel self-assigned this Apr 2, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2026 14:52
Copilot AI review requested due to automatic review settings April 2, 2026 14:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors ChunkIter’s PhantomData marker to explicitly include the MIN_ALIGN const generic on Bump, aligning it with ChunkRawIter and avoiding reliance on the default const parameter.

Changes:

  • Update ChunkIter’s PhantomData from &'a mut Bump to &'a mut Bump<MIN_ALIGN> for const-generic explicitness and consistency.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_ (a0a9195) with om/04-02-docs_allocator_fix_typo_in_comment (5b9268b)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel force-pushed the om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_ branch from 57af2dd to a0a9195 Compare April 2, 2026 14:55
@overlookmotel overlookmotel force-pushed the om/04-02-docs_allocator_fix_typo_in_comment branch from 0510d95 to 5b9268b Compare April 2, 2026 14:55
@overlookmotel overlookmotel added A-allocator Area - Allocator 0-merge Merge with Graphite Merge Queue labels Apr 2, 2026
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 2, 2026

Merge activity

Refactor. `PhantomData<&'a mut Bump>` -> `PhantomData<&'a mut Bump<MIN_ALIGN>>`. The generic param is not necessary here due to the `PhantomData` wrapper, but it's more explicit and matches `ChunkRawIter`.
@graphite-app graphite-app bot force-pushed the om/04-02-docs_allocator_fix_typo_in_comment branch from 5b9268b to f5e228f Compare April 2, 2026 15:13
@graphite-app graphite-app bot force-pushed the om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_ branch from a0a9195 to 59e1091 Compare April 2, 2026 15:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2026
Base automatically changed from om/04-02-docs_allocator_fix_typo_in_comment to main April 2, 2026 15:21
@graphite-app graphite-app bot merged commit 59e1091 into main Apr 2, 2026
28 checks passed
@graphite-app graphite-app bot deleted the om/04-02-refactor_allocator_add_generic_param_to_bump_in_chunkiter_ branch April 2, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants