refactor(allocator): add generic param to Bump in ChunkIter#20974
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
This was referenced Apr 2, 2026
Member
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors ChunkIter’s PhantomData marker to explicitly include the MIN_ALIGN const generic on Bump, aligning it with ChunkRawIter and avoiding reliance on the default const parameter.
Changes:
- Update
ChunkIter’sPhantomDatafrom&'a mut Bumpto&'a mut Bump<MIN_ALIGN>for const-generic explicitness and consistency.
Merging this PR will not alter performance
Comparing Footnotes
|
57af2dd to
a0a9195
Compare
0510d95 to
5b9268b
Compare
Member
Author
Merge activity
|
5b9268b to
f5e228f
Compare
a0a9195 to
59e1091
Compare
Base automatically changed from
om/04-02-docs_allocator_fix_typo_in_comment
to
main
April 2, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor.
PhantomData<&'a mut Bump>->PhantomData<&'a mut Bump<MIN_ALIGN>>. The generic param is not necessary here due to thePhantomDatawrapper, but it's more explicit and matchesChunkRawIter.