feat(linter/plugins): implement sourceCode.markVariableAsUsed#20357
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 14, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
Implements ESLint-compatible sourceCode.markVariableAsUsed() in Oxlint’s JS plugin SourceCode shim and adds a fixture-based snapshot test to validate behavior across ESM and CommonJS scope layouts.
Changes:
- Implement
markVariableAsUsed(name, refNode?)inapps/oxlint/src-js/plugins/scope.ts, including defaultingrefNodetoProgramand handling the global→module/outer-function scope transition. - Add a new fixture (
sourceCode_markVariableAsUsed) with a JS plugin and ESM/CJS input files to exercise marking variables as used at different scope levels. - Add a snapshot (
output.snap.md) and fixture.oxlintrc.jsonto lock expected output.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/scope.ts | Adds the actual markVariableAsUsed implementation and updates its documentation. |
| apps/oxlint/test/fixtures/sourceCode_markVariableAsUsed/plugin.ts | Fixture plugin that calls markVariableAsUsed in multiple scope scenarios and reports results. |
| apps/oxlint/test/fixtures/sourceCode_markVariableAsUsed/files/index.js | ESM fixture source exercising module scope + nested scopes/shadowing. |
| apps/oxlint/test/fixtures/sourceCode_markVariableAsUsed/files/index.cjs | CommonJS fixture source exercising outer-function top scope + nested scopes/shadowing. |
| apps/oxlint/test/fixtures/sourceCode_markVariableAsUsed/.oxlintrc.json | Fixture config enabling the test plugin/rule while disabling correctness category. |
| apps/oxlint/test/fixtures/sourceCode_markVariableAsUsed/output.snap.md | Snapshot capturing expected diagnostics output for both fixture files. |
Member
Author
Merge activity
|
Fixes #19971. Implement `sourceCode.markVariableAsUsed`. It has some shortcomings at present - it does mark vars as used, so any other JS plugins can see that, but it doesn't communicate this info back to Rust side, so `no-unused-vars` doesn't act on it. But at least it doesn't cause a crash with "unimplemented" error. The remaining issue is tracked in #20350.
graphite-app
bot
force-pushed
the
om/03-13-feat_linter_plugins_implement_sourcecode.markvariableasused_
branch
from
b56a30a to
c95951f
Compare
graphite-app
bot
deleted the
om/03-13-feat_linter_plugins_implement_sourcecode.markvariableasused_
branch
camc314
pushed a commit
that referenced
this pull request
Mar 16, 2026
# Oxlint ### 🚀 Features - c95951f linter/plugins: Implement `sourceCode.markVariableAsUsed` (#20357) (overlookmotel) - 7a2a7d0 linter: Implement `n/handle-callback-err` rule (#19616) (Mikhail Baev) ### 🐛 Bug Fixes - f8fbd6e linter/plugins: Remove `hashbang` property from AST (#20365) (overlookmotel) - 6eb5b01 linter/prefer-await-to-then: Ignore Promise static methods (#20347) (camc314) - a4b61f7 linter: Remove `defineConfig` check (#20308) (camc314) - 3ad7f53 linter/explicit-module-boundary-types: False positive with satisfies expr (#20309) (camc314) - f547401 linter/no-unused-private-class-members: Treat switch discriminants as read (#20307) (camc314) - 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen) ### ⚡ Performance - e4f7248 linter: Remove unnecessary clone of owned String in drain loop (#20388) (Boshen) - 4a67f1d linter: Eliminate Vec allocation in disable directive matching (#20387) (Boshen) - 618a598 linter/plugins: Add fast path for files with no comments (#20366) (overlookmotel) - b0125c5 linter/plugins: Deserialize comments without AST (#20364) (overlookmotel) - 9cd612f linter/plugins: Recycle comment objects (#20362) (overlookmotel) - bf442f8 linter/plugins: Cheaper `Token` creation (#20360) (overlookmotel) - 5474d0a semantic: V8-style walk-up reference resolution (#20292) (Boshen) - 7946eba linter/plugins: Avoid arguments spread and temp array when merging (#20318) (overlookmotel) - fc7cf8a linter/plugins: Pre-define less CFG merger functions (#20317) (overlookmotel) - 3b9eb28 linter/plugins: Streamline getting/creating visit fn mergers (#20319) (overlookmotel) - f04e850 linter/plugins: Inline binary search functions into call sites (#20312) (overlookmotel) - fe24afe linter/plugins: Apply replace globals TSDown plugin to JS files (#20305) (overlookmotel) - 77cdacc linter/plugins: Use array buffer views for tokens (#20301) (overlookmotel) - 910c941 linter/plugins: Reorder branches in `getTokenByRangeStart` (#20296) (overlookmotel) - af7674c linter/tokens: Avoid extra token value allocation (#20013) (camc314) ### 📚 Documentation - 24490b5 linter: Improve formatting for 80ish rules' docs. (#20411) (connorshea) - 3383523 linter: Improve `--tsconfig` flag docs (#20342) (camc314) # Oxfmt ### 🚀 Features - d22c443 oxfmt: Export `OxfmtConfig` type (#20275) (leaysgur) - a11ecff oxfmt/lsp: Respect `angular` language id as `.component.html` file (#20242) (Sysix) ### 🐛 Bug Fixes - ce65099 formatter: Preserve parentheses around as expression before private field access (#20419) (bab) - f908742 oxfmt: Revert #20326 partially (#20413) (leaysgur) - 4ef93ea formatter: Honor trailing ignore comments after list separators (#19925) (Andreas Lubbe) - 68fb0d0 oxfmt: Skip vite.config.ts which fails to import (#20326) (leaysgur) - 88ee826 oxfmt: Handle literalline for script-in-vue (#20130) (leaysgur) - 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19971.
Implement
sourceCode.markVariableAsUsed.It has some shortcomings at present - it does mark vars as used, so any other JS plugins can see that, but it doesn't communicate this info back to Rust side, so
no-unused-varsdoesn't act on it. But at least it doesn't cause a crash with "unimplemented" error.The remaining issue is tracked in #20350.