Skip to content

fix(linter/no-unused-private-class-members): treat switch discriminants as read#20307

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_linter_no-unused-private-class-members_treat_switch_discriminants_as_read
Mar 12, 2026
Merged

fix(linter/no-unused-private-class-members): treat switch discriminants as read#20307
graphite-app[bot] merged 1 commit intomainfrom
c/03-12-fix_linter_no-unused-private-class-members_treat_switch_discriminants_as_read

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 12, 2026 •
edited
Loading

fixes #20302

@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Mar 12, 2026

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review March 12, 2026 19:22
Copilot AI review requested due to automatic review settings March 12, 2026 19:22
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Mar 12, 2026
Copilot AI reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the no-unused-private-class-members ESLint rule to correctly recognize that a private field used as a switch statement discriminant (e.g., switch (this.#state)) is being read. Previously, only case expressions (SwitchCase) were treated as value contexts, causing false positives when private members appeared in the switch(...) position.

Changes:

  • Added AstKind::SwitchStatement(_) to the is_value_context match arms so the discriminant is treated as a read.
  • Added a passing test case exercising a private field in a switch discriminant.

You can also share your feedback on Copilot code review. Take the survey.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1

Comparing c/03-12-fix_linter_no-unused-private-class-members_treat_switch_discriminants_as_read (d2c3cca) with main (7a2a7d0)2

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (77cdacc) during the generation of this report, so 7a2a7d0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
@camc314 camc314 self-assigned this Mar 12, 2026
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Mar 12, 2026 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/03-12-fix_linter_no-unused-private-class-members_treat_switch_discriminants_as_read branch from d2c3cca to f547401 Compare March 12, 2026 19:38
@graphite-app graphite-app bot merged commit f547401 into main Mar 12, 2026
21 checks passed
@graphite-app graphite-app bot deleted the c/03-12-fix_linter_no-unused-private-class-members_treat_switch_discriminants_as_read branch March 12, 2026 19:43
@Boshen Boshen mentioned this pull request Mar 16, 2026
Merged
camc314 pushed a commit that referenced this pull request Mar 16, 2026
@Boshen
release(apps): oxlint v1.56.0 && oxfmt v0.41.0 (#20423)
5446ebd 
# Oxlint
### 🚀 Features

- c95951f linter/plugins: Implement `sourceCode.markVariableAsUsed` (#20357) (overlookmotel)
- 7a2a7d0 linter: Implement `n/handle-callback-err` rule (#19616) (Mikhail Baev)

### 🐛 Bug Fixes

- f8fbd6e linter/plugins: Remove `hashbang` property from AST (#20365) (overlookmotel)
- 6eb5b01 linter/prefer-await-to-then: Ignore Promise static methods (#20347) (camc314)
- a4b61f7 linter: Remove `defineConfig` check (#20308) (camc314)
- 3ad7f53 linter/explicit-module-boundary-types: False positive with satisfies expr (#20309) (camc314)
- f547401 linter/no-unused-private-class-members: Treat switch discriminants as read (#20307) (camc314)
- 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen)

### ⚡ Performance

- e4f7248 linter: Remove unnecessary clone of owned String in drain loop (#20388) (Boshen)
- 4a67f1d linter: Eliminate Vec allocation in disable directive matching (#20387) (Boshen)
- 618a598 linter/plugins: Add fast path for files with no comments (#20366) (overlookmotel)
- b0125c5 linter/plugins: Deserialize comments without AST (#20364) (overlookmotel)
- 9cd612f linter/plugins: Recycle comment objects (#20362) (overlookmotel)
- bf442f8 linter/plugins: Cheaper `Token` creation (#20360) (overlookmotel)
- 5474d0a semantic: V8-style walk-up reference resolution (#20292) (Boshen)
- 7946eba linter/plugins: Avoid arguments spread and temp array when merging (#20318) (overlookmotel)
- fc7cf8a linter/plugins: Pre-define less CFG merger functions (#20317) (overlookmotel)
- 3b9eb28 linter/plugins: Streamline getting/creating visit fn mergers (#20319) (overlookmotel)
- f04e850 linter/plugins: Inline binary search functions into call sites (#20312) (overlookmotel)
- fe24afe linter/plugins: Apply replace globals TSDown plugin to JS files (#20305) (overlookmotel)
- 77cdacc linter/plugins: Use array buffer views for tokens (#20301) (overlookmotel)
- 910c941 linter/plugins: Reorder branches in `getTokenByRangeStart` (#20296) (overlookmotel)
- af7674c linter/tokens: Avoid extra token value allocation (#20013) (camc314)

### 📚 Documentation

- 24490b5 linter: Improve formatting for 80ish rules' docs. (#20411) (connorshea)
- 3383523 linter: Improve `--tsconfig` flag docs (#20342) (camc314)
# Oxfmt
### 🚀 Features

- d22c443 oxfmt: Export `OxfmtConfig` type (#20275) (leaysgur)
- a11ecff oxfmt/lsp: Respect `angular` language id as `.component.html` file (#20242) (Sysix)

### 🐛 Bug Fixes

- ce65099 formatter: Preserve parentheses around as expression before private field access (#20419) (bab)
- f908742 oxfmt: Revert #20326 partially (#20413) (leaysgur)
- 4ef93ea formatter: Honor trailing ignore comments after list separators (#19925) (Andreas Lubbe)
- 68fb0d0 oxfmt: Skip vite.config.ts which fails to import (#20326) (leaysgur)
- 88ee826 oxfmt: Handle literalline for script-in-vue (#20130) (leaysgur)
- 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: no-unused-private-class-members reports false positive for switch discriminant

2 participants

@camc314