Skip to content

feat(oxfmt/lsp): respect angular language id as .component.html file#20242

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-11-feat_oxfmt_lsp_respect_angular_language_id_as_.component.html_file
Mar 12, 2026
Merged

feat(oxfmt/lsp): respect angular language id as .component.html file#20242
graphite-app[bot] merged 1 commit intomainfrom
03-11-feat_oxfmt_lsp_respect_angular_language_id_as_.component.html_file

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Mar 11, 2026

related oxc-project/oxc-zed#138 (comment)
This does not resolve the original issue. The editor is not sending the language id to the server, but we know at least how to handle them.

Copy link
Member Author

Sysix commented Mar 11, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Mar 11, 2026
@Sysix Sysix requested a review from Copilot March 11, 2026 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the oxfmt LSP language-id handling so that documents identified as angular are treated like Angular component templates (*.component.html) when determining formatting strategy.

Changes:

  • Add angular to the LanguageId → file-extension mapping used to derive a fake path for formatting.

You can also share your feedback on Copilot code review. Take the survey.

@Sysix Sysix marked this pull request as ready for review March 11, 2026 21:41
Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least LTGM for now. 🥲

FYI: angular/angular#67545

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
Copy link
Member

leaysgur commented Mar 12, 2026

Merge activity

  • Mar 12, 5:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 5:58 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Mar 12, 6:00 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Label and Check PR Title').
  • Mar 12, 5:14 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 6:39 PM UTC: Sysix added this pull request to the Graphite merge queue.
  • Mar 12, 6:51 PM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Mar 12, 2026
…ile (#20242)

related oxc-project/oxc-zed#138 (comment)
This does not resolve the original issue. The editor is not sending the language id to the server, but we know at least how to handle them.
@graphite-app graphite-app bot force-pushed the 03-11-feat_oxfmt_lsp_respect_angular_language_id_as_.component.html_file branch from 78b1e16 to 55e8b97 Compare March 12, 2026 05:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
…ile (#20242)

related oxc-project/oxc-zed#138 (comment)
This does not resolve the original issue. The editor is not sending the language id to the server, but we know at least how to handle them.
@graphite-app graphite-app bot force-pushed the 03-11-feat_oxfmt_lsp_respect_angular_language_id_as_.component.html_file branch from 55e8b97 to a11ecff Compare March 12, 2026 18:39
@graphite-app graphite-app bot merged commit a11ecff into main Mar 12, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 03-11-feat_oxfmt_lsp_respect_angular_language_id_as_.component.html_file branch March 12, 2026 18:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
camc314 pushed a commit that referenced this pull request Mar 16, 2026
# Oxlint
### 🚀 Features

- c95951f linter/plugins: Implement `sourceCode.markVariableAsUsed` (#20357) (overlookmotel)
- 7a2a7d0 linter: Implement `n/handle-callback-err` rule (#19616) (Mikhail Baev)

### 🐛 Bug Fixes

- f8fbd6e linter/plugins: Remove `hashbang` property from AST (#20365) (overlookmotel)
- 6eb5b01 linter/prefer-await-to-then: Ignore Promise static methods (#20347) (camc314)
- a4b61f7 linter: Remove `defineConfig` check (#20308) (camc314)
- 3ad7f53 linter/explicit-module-boundary-types: False positive with satisfies expr (#20309) (camc314)
- f547401 linter/no-unused-private-class-members: Treat switch discriminants as read (#20307) (camc314)
- 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen)

### ⚡ Performance

- e4f7248 linter: Remove unnecessary clone of owned String in drain loop (#20388) (Boshen)
- 4a67f1d linter: Eliminate Vec allocation in disable directive matching (#20387) (Boshen)
- 618a598 linter/plugins: Add fast path for files with no comments (#20366) (overlookmotel)
- b0125c5 linter/plugins: Deserialize comments without AST (#20364) (overlookmotel)
- 9cd612f linter/plugins: Recycle comment objects (#20362) (overlookmotel)
- bf442f8 linter/plugins: Cheaper `Token` creation (#20360) (overlookmotel)
- 5474d0a semantic: V8-style walk-up reference resolution (#20292) (Boshen)
- 7946eba linter/plugins: Avoid arguments spread and temp array when merging (#20318) (overlookmotel)
- fc7cf8a linter/plugins: Pre-define less CFG merger functions (#20317) (overlookmotel)
- 3b9eb28 linter/plugins: Streamline getting/creating visit fn mergers (#20319) (overlookmotel)
- f04e850 linter/plugins: Inline binary search functions into call sites (#20312) (overlookmotel)
- fe24afe linter/plugins: Apply replace globals TSDown plugin to JS files (#20305) (overlookmotel)
- 77cdacc linter/plugins: Use array buffer views for tokens (#20301) (overlookmotel)
- 910c941 linter/plugins: Reorder branches in `getTokenByRangeStart` (#20296) (overlookmotel)
- af7674c linter/tokens: Avoid extra token value allocation (#20013) (camc314)

### 📚 Documentation

- 24490b5 linter: Improve formatting for 80ish rules' docs. (#20411) (connorshea)
- 3383523 linter: Improve `--tsconfig` flag docs (#20342) (camc314)
# Oxfmt
### 🚀 Features

- d22c443 oxfmt: Export `OxfmtConfig` type (#20275) (leaysgur)
- a11ecff oxfmt/lsp: Respect `angular` language id as `.component.html` file (#20242) (Sysix)

### 🐛 Bug Fixes

- ce65099 formatter: Preserve parentheses around as expression before private field access (#20419) (bab)
- f908742 oxfmt: Revert #20326 partially (#20413) (leaysgur)
- 4ef93ea formatter: Honor trailing ignore comments after list separators (#19925) (Andreas Lubbe)
- 68fb0d0 oxfmt: Skip vite.config.ts which fails to import (#20326) (leaysgur)
- 88ee826 oxfmt: Handle literalline for script-in-vue (#20130) (leaysgur)
- 1c07b3b diagnostics: Handle `WouldBlock` in stdout writes to prevent panic (#20295) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants