fix(linter): add .with_help() to operator-assignment, no-nonoctal-decimal-escape by anthonyamaro15 · Pull Request #19732 · oxc-project/oxc

anthonyamaro15 · 2026-02-26T02:37:12Z

Add .with_help() to diagnostics that only provide a warning message, giving developers actionable guidance on how to resolve each issue.

sort_keys: Sort keys alphabetically per configured order
operator_assignment: Use consistent operator assignment shorthand
no_nonoctal_decimal_escape: Use the actual character or valid escape sequence

Part of #19121

…onoctal_decimal_escape

Copilot

Pull request overview

This PR updates several ESLint-rule diagnostics to include additional guidance text (with_help) so warnings are more actionable, aligning with #19121’s request to avoid message-only diagnostics.

Changes:

Added help text to sort-keys, operator-assignment, and no-nonoctal-decimal-escape diagnostics.
Updated snapshot outputs to reflect the new help text in rendered diagnostics.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/eslint/sort_keys.rs	Adds `with_help` to the base diagnostic for `sort-keys`.
crates/oxc_linter/src/rules/eslint/operator_assignment.rs	Adds `with_help` to the base diagnostic for `operator-assignment`.
crates/oxc_linter/src/rules/eslint/no_nonoctal_decimal_escape.rs	Adds `with_help` to the diagnostic for invalid decimal escapes.
crates/oxc_linter/src/snapshots/eslint_sort_keys.snap	Snapshot updates for the new help text rendering.
crates/oxc_linter/src/snapshots/eslint_operator_assignment.snap	Snapshot updates for the new help text rendering.
crates/oxc_linter/src/snapshots/eslint_no_nonoctal_decimal_escape.snap	Snapshot updates for the new help text rendering.

crates/oxc_linter/src/rules/eslint/sort_keys.rs

crates/oxc_linter/src/rules/eslint/operator_assignment.rs

codspeed-hq · 2026-02-26T02:44:00Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 51 skipped benchmarks¹

_{Comparing anthonyamaro15:fix/eslint-diagnostics-help-text-9 (bcc9423) with main (ef798af)}

51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…ess_backreference

…fixers

crates/oxc_linter/src/rules/eslint/operator_assignment.rs

crates/oxc_linter/src/rules/eslint/sort_imports.rs

camc314

Some of these messages could be clearer

anthonyamaro15 · 2026-02-26T15:44:47Z

Some of these messages could be clearer

@camc314 thanks for the feedback, I'll make the changes later today after work

…nd sort_imports

…adding a not about the desired behaviour is superfluous

crates/oxc_linter/src/snapshots/eslint_operator_assignment.snap

crates/oxc_linter/src/snapshots/eslint_sort_imports.snap

camc314

Thank you! I removed some of the help messages, as the message already describes the problem - we want to avoid duplicate infomation in the diagnosic, as it's more for the user to read, and more tokens for the agent to consume while not provinding more action to fix the problem

# Oxlint ### 🚀 Features - 2e0e1d0 linter/no-unused-vars: Add experimental fix mode controls (off|suggestion|fix) (#19774) (camc314) - f34f6fa linter: Introduce typeCheck config option (#19764) (camc314) - 694be7d linter: Introduce typeAware as config options (#19614) (camc314) - 655c38f semantic: Add "did you mean?" suggestions to undefined name errors (#19102) (copilot-swe-agent) - e97a57e linter/id-length: Use serde to deserialize rule options (#19636) (camc314) - c4a3677 parser: Report error for initializer in ambient context (#19187) (camc314) - 346045a linter/id-length: Add `checkGeneric` option (#19634) (camc314) ### 🐛 Bug Fixes - 1b7a937 linter: Correct double-comparisons fix with swapped operands (#19846) (camc314) - c308857 linter/consistent_type_imports: Add missing help and notes to diagnostics (#19827) (Daniel Osmond) - 7682e5a linter/plugins: Decode escapes in identifier tokens (#19838) (overlookmotel) - f368fcd linter/consistent_type_assertions: Add missing with_help and with_note to diagnostics (#19826) (Daniel Osmond) - 04e6223 npm: Add `preferUnplugged` for Yarn PnP compatibility (#19829) (Boshen) - 86d5037 linter: Add help text to no-extend-native, no-useless-backreference (#19733) (Anthony Amaro) - 50e8eff linter: Add .with_help() to operator-assignment, no-nonoctal-decimal-escape (#19732) (Anthony Amaro) - 1417bdc linter/no-wrapper-object-types: Add help messages to missing diagnostics (#19771) (Daniel Osmond) - 0838477 linter/ban_ts_comment: Add help and notes to missing diagnostics (#19781) (Daniel Osmond) - e8c77cf linter/adjacent_overload_signatures: Add missing diagnostics (#19780) (Daniel Osmond) - 28834ac linter/ban_types: Add missing help and note to diagnostics (#19782) (Daniel Osmond) - fd938d3 linter/prefer-enum-initializers: Add help messages to missing diagnostics (#19772) (Daniel Osmond) - eb928ee linter/no-dynamic-delete: Add help messages to missing diagnostics (#19768) (Daniel Osmond) - a985666 linter/no-empty-interface: Add help messages to missing diagnostics (#19769) (Daniel Osmond) - 2dc0ceb linter/no-extra-non-null-assertion: Add help messages to missing diagnostics (#19770) (Daniel Osmond) - 95d5d66 linter/no-dupe-keys: Handle `__proto__` proto setters in (#19762) (camc314) - 24ff0db linter/exhaustive-deps: False positive for member expressions in IIFEs (#19751) (Dennis Chen) - 7243a58 linter/no-use-before-define: Honor `ignoreTypeReferences` when value and type name collisions (#19747) (Dimava) - eefd818 linter/explicit-module-boundary-types: Add help messages to missing diagnostics (#19736) (Daniel Osmond) - 0440e9a linter: Add help text to no_control_regex, no_fallthrough, no_param_reassign (#19655) (Anthony Amaro) - e84cb2f react/display-name: Handle merged type+value context symbols (#19608) (camc314) - ce7e253 linter/prefer-object-from-entries: Require exact path match in unicorn helper (#19687) (camc314) - f5694ce estree/tokens: Reverse field order of `regex` object in tokens (#19679) (overlookmotel) - b2b7a55 estree/tokens: Generate tokens for files with BOM (#19535) (overlookmotel) - 0722721 linter/jsx-curly-brace-presence: False positive with prop & mixed quotes (#19674) (camc314) - 3496acd linter: Enhance diagnostic help messages for eslint rules (#19653) (Anthony Amaro) - e384e94 linter: Enhance help diagnostic messages for more eslint rules (#19658) (Anthony Amaro) - a4d5b34 linter: Avoid non-promise catch false positives (#19574) (camc314) - 5706f38 linter: `unicorn/no-array-callback-reference` skip `Effect.*` array-like methods name. (#19633) (Said Atrahouch) ### ⚡ Performance - 05ccf9f linter/plugins: Transfer tokens via raw transfer (#19893) (overlookmotel) - 4b0611a estree/tokens: Introduce `ESTreeTokenConfig` trait (#19842) (overlookmotel) - ec88f6a estree/tokens: Serialize tokens while visiting AST (#19726) (overlookmotel) - d4dcf26 linter/plugins: Remove `typescript` from bundle (#19531) (overlookmotel) - 6a6513c linter/plugins: Use Oxc tokens in plugins (#19498) (camc314) ### 📚 Documentation - d86f59e linter: Improve docs for no-useless-concat, mark as pending fixer. (#19859) (connorshea) - caa091d linter/plugins: Correct doc comments for `initTokens` (#19530) (overlookmotel) - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) - dc0ff73 linter/no-useless-constructor: Warn for parameter properties as well (#19638) (Ole Asteo) # Oxfmt ### 🚀 Features - 5141bc2 formatter: Support trailing ignore comments (#19304) (Andreas Lubbe) - 4888a99 oxfmt/lsp: Support other schemes beside `file://` and `untitled://` (#19872) (Sysix) - 14a0181 oxfmt: Support `graphql()` variant for gql-in-js (#19703) (leaysgur) - ca68ea6 oxfmt: Support gql-in-js substitution (#19670) (leaysgur) - 035933c formatter,oxfmt: Support js-in-vue (partially) (#19514) (leaysgur) - 9e11dc6 parser,estree,coverage: Collect tokens in parser and convert to ESTree format (#19497) (camc314) ### 🐛 Bug Fixes - 8e3842d oxfmt: Avoid embedded TSFN crash by returning errors as data (take2) (#19806) (Yuji Sugiura) - 04e6223 npm: Add `preferUnplugged` for Yarn PnP compatibility (#19829) (Boshen) - e540585 oxfmt: Support tailwind sort for CSS/LESS/SCSS (#19803) (leaysgur) - 93bb861 formatter: Trim trailing whitespace before breaking line (#19740) (leaysgur) - b85f97b formatter: Drop blank line between terminal call and first chain member (#19659) (Dunqing) ### ⚡ Performance - b3b2d30 parser: Introduce `ParserConfig` (#19637) (overlookmotel) ### 📚 Documentation - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

fix(linter): add .with_help() to sort_keys, operator_assignment, no_n…

103c5a3

…onoctal_decimal_escape

anthonyamaro15 requested a review from camc314 as a code owner February 26, 2026 02:37

Copilot AI review requested due to automatic review settings February 26, 2026 02:37

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 26, 2026

Copilot started reviewing on behalf of anthonyamaro15 February 26, 2026 02:37 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

crates/oxc_linter/src/rules/eslint/sort_keys.rs Outdated Show resolved Hide resolved

crates/oxc_linter/src/rules/eslint/operator_assignment.rs Outdated Show resolved Hide resolved

anthonyamaro15 added 2 commits February 25, 2026 19:36

fix(linter): add help text to sort_imports, no_extend_native, no_usel…

b8f77c6

…ess_backreference

fix(linter): use .with_note() instead of .with_help() for rules with …

b42fd90

…fixers

camc314 reviewed Feb 26, 2026

View reviewed changes

crates/oxc_linter/src/rules/eslint/operator_assignment.rs Outdated Show resolved Hide resolved

camc314 reviewed Feb 26, 2026

View reviewed changes

crates/oxc_linter/src/rules/eslint/sort_imports.rs Outdated Show resolved Hide resolved

camc314 requested changes Feb 26, 2026

View reviewed changes

camc314 self-assigned this Feb 26, 2026

anthonyamaro15 and others added 3 commits February 26, 2026 17:16

fix(linter): make help text more actionable for operator_assignment a…

a57c8b5

…nd sort_imports

[autofix.ci] apply automated fixes

68dd1f5

remove note for sort_keys, since we provide a fixer for this rule, …

3b10093

…adding a not about the desired behaviour is superfluous

camc314 changed the title ~~fix(linter): add .with_help() to sort_keys, operator_assignment, no_nonoctal_decimal_escape~~ fix(linter): add .with_help() to operator_assignment, no_nonoctal_decimal_escape Feb 27, 2026

camc314 changed the title ~~fix(linter): add .with_help() to operator_assignment, no_nonoctal_decimal_escape~~ fix(linter): add .with_help() to sort-imports, operator_assignment, no_nonoctal_decimal_escape Feb 27, 2026

camc314 reviewed Feb 27, 2026

View reviewed changes

crates/oxc_linter/src/snapshots/eslint_operator_assignment.snap Outdated Show resolved Hide resolved

camc314 reviewed Feb 27, 2026

View reviewed changes

crates/oxc_linter/src/snapshots/eslint_sort_imports.snap Outdated Show resolved Hide resolved

camc314 added 2 commits February 27, 2026 17:52

fix: only show operator assignment note when no fix available

0fb17c7

fix: remove superfluous help in sort imports rule

3b98340

camc314 approved these changes Feb 27, 2026

View reviewed changes

camc314 added 2 commits February 27, 2026 17:54

remove non-actionable sort imports diagnostics

c186aa0

Merge branch 'main' into fix/eslint-diagnostics-help-text-9

bcc9423

camc314 changed the title ~~fix(linter): add .with_help() to sort-imports, operator_assignment, no_nonoctal_decimal_escape~~ fix(linter): add .with_help() to operator_assignment, no_nonoctal_decimal_escape Feb 27, 2026

camc314 changed the title ~~fix(linter): add .with_help() to operator_assignment, no_nonoctal_decimal_escape~~ fix(linter): add .with_help() to operator-assignment, no-nonoctal-decimal-escape Feb 27, 2026

camc314 merged commit 50e8eff into oxc-project:main Feb 27, 2026
22 checks passed

Boshen mentioned this pull request Mar 2, 2026

release(apps): oxlint v1.51.0 && oxfmt v0.36.0 #19912

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter): add .with_help() to operator-assignment, no-nonoctal-decimal-escape#19732

fix(linter): add .with_help() to operator-assignment, no-nonoctal-decimal-escape#19732
camc314 merged 10 commits intooxc-project:mainfrom
anthonyamaro15:fix/eslint-diagnostics-help-text-9

anthonyamaro15 commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Uh oh!

anthonyamaro15 commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

anthonyamaro15 commented Feb 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

anthonyamaro15 commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Feb 26, 2026 •

edited

Loading