Skip to content

Comments

fix(linter): unicorn/no-array-callback-reference skip Effect.* array-like methods name.#19633

Merged
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:effect-no-array-callback-fix
Feb 23, 2026
Merged

fix(linter): unicorn/no-array-callback-reference skip Effect.* array-like methods name.#19633
camc314 merged 1 commit intooxc-project:mainfrom
Afsoon:effect-no-array-callback-fix

Conversation

@Afsoon
Copy link
Contributor

@Afsoon Afsoon commented Feb 23, 2026

Fix #18876. The PR #19127 fixed unicorn/no-array-for-each.

@Afsoon Afsoon requested a review from camc314 as a code owner February 23, 2026 12:41
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 23, 2026
@Afsoon Afsoon force-pushed the effect-no-array-callback-fix branch from bd941ad to 80350eb Compare February 23, 2026 12:45
@camc314 camc314 merged commit 5706f38 into oxc-project:main Feb 23, 2026
28 checks passed
@camc314 camc314 self-assigned this Feb 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 23, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing Afsoon:effect-no-array-callback-fix (80350eb) with main (a08c28d)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (72c947e) during the generation of this report, so a08c28d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: unicorn/no-array-callback-reference and unicorn/no-array-for-each false positives on Effect library methods

2 participants