feat(linter): introduce typeAware as config options by camc314 · Pull Request #19614 · oxc-project/oxc

camc314 · 2026-02-21T22:10:45Z

No description provided.

camc314 · 2026-02-21T22:10:58Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-21T22:16:58Z

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 51 skipped benchmarks¹

_{Comparing c/02-14-feat_linter_introduce_typeaware_as_config_options (65ce812) with main (ecf1699)}

51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2026-02-25T01:14:29Z

TODO: add a test case to make sure we merge options correctly in extenss

Copilot

Pull request overview

This PR introduces a new options object in the Oxlint configuration schema to support options.typeAware, allowing type-aware linting to be enabled via config (in addition to CLI/LSP flags), with updated CLI/LSP behavior and expanded test coverage.

Changes:

Add OxlintOptions / options.typeAware to Rust config model and JSON schema outputs.
Make CLI and LSP compute an “effective” type-aware setting using config + flags (LSP options can override config).
Reject options.typeAware when it appears in nested configs, and add fixtures/snapshots validating the behavior.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tasks/website_linter/src/snapshots/schema_markdown.snap	Updates schema docs snapshot to include `options.typeAware`.
tasks/website_linter/src/snapshots/schema_json.snap	Updates schema JSON snapshot with `options` + `OxlintOptions`.
npm/oxlint/configuration_schema.json	Publishes `options` and `OxlintOptions` in shipped schema.
crates/oxc_linter/src/config/oxlintrc.rs	Adds `OxlintOptions` and wires it into `Oxlintrc` merge/serde/schema + tests.
crates/oxc_linter/src/config/mod.rs	Adds `options` to `LintConfig` and imports `OxlintOptions`.
crates/oxc_linter/src/config/config_store.rs	Exposes `type_aware_enabled()` and updates tests/builders for new field.
crates/oxc_linter/src/config/config_builder.rs	Propagates options into built `LintConfig` and exposes `type_aware()` accessor.
crates/oxc_language_server/README.md	Documents LSP `typeAware` as nullable/inheriting from config.
apps/oxlint/test/lsp/utils.ts	Allows passing `typeAware` initialization option in test harness.
apps/oxlint/test/lsp/lint/lint.test.ts	Adds LSP fixture cases for config-driven type aware and override behavior.
apps/oxlint/test/lsp/lint/fixtures/config-ts-type-aware/test.ts	New fixture file for type-aware config behavior.
apps/oxlint/test/lsp/lint/fixtures/config-ts-type-aware/test-with-lsp-config.ts	New fixture file for LSP override behavior.
apps/oxlint/test/lsp/lint/fixtures/config-ts-type-aware/oxlint.config.ts	New JS config enabling `options.typeAware`.
apps/oxlint/test/lsp/lint/fixtures/config-ts-nested-type-aware-invalid/oxlint.config.ts	New fixture root config for nested-config behavior.
apps/oxlint/test/lsp/lint/fixtures/config-ts-nested-type-aware-invalid/nested/test.ts	New nested fixture file.
apps/oxlint/test/lsp/lint/fixtures/config-ts-nested-type-aware-invalid/nested/oxlint.config.ts	New nested JS config using `options.typeAware`.
apps/oxlint/test/lsp/lint/snapshots/lint.test.ts.snap	Snapshot updates for new fixtures/behavior.
apps/oxlint/test/fixtures/js_config_type_aware/oxlint.config.ts	Adds CLI fixture using `options.typeAware` in JS config.
apps/oxlint/test/fixtures/js_config_type_aware/output.snap.md	Snapshot for CLI fixture output.
apps/oxlint/test/fixtures/js_config_type_aware/files/test.js	CLI fixture input file.
apps/oxlint/test/fixtures/js_config_invalid_cli_arg/output.snap.md	Updates expected unknown-field list to include `options`.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_tsgolint_type_aware_config@test.ts.snap	New/updated LSP snapshot for config-driven type aware.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_tsgolint_type_aware_config@test-with-lsp-config.ts.snap	New/updated LSP snapshot for LSP override behavior.
apps/oxlint/src/lsp/snapshots/fixtures_lsp_tsgolint_nested_type_aware@test-root.ts_nested__test.ts.snap	New/updated LSP snapshot for nested typeAware rejection.
apps/oxlint/src/lsp/server_linter.rs	Uses config-derived typeAware when LSP option is unset; updates watcher logic; tests.
apps/oxlint/src/lsp/options.rs	Changes LSP `type_aware` option from `bool` to `Option<bool>` and parsing/tests.
apps/oxlint/src/lint.rs	CLI now ORs `--type-aware` with root config `options.typeAware`.
apps/oxlint/src/config_loader.rs	Rejects `options.typeAware` in nested configs; adds root-dir-aware loader + tests.
apps/oxlint/src-js/package/config.generated.ts	Adds `options?: OxlintOptions` and `OxlintOptions.typeAware` typings.
apps/oxlint/fixtures/tsgolint/config-type-aware.json	Adds CLI fixture enabling type aware via JSON config.
apps/oxlint/fixtures/tsgolint/config-type-aware-with-overrides.json	Adds fixture verifying overrides under type aware.
apps/oxlint/fixtures/tsgolint/config-type-aware-false.json	Adds fixture verifying disabled type aware.
apps/oxlint/fixtures/tsgolint/config-type-aware-false-with-overrides.json	Adds fixture verifying overrides when type aware is false.
apps/oxlint/fixtures/lsp/tsgolint/type_aware_config/test.ts	Adds LSP fixture input.
apps/oxlint/fixtures/lsp/tsgolint/type_aware_config/test-with-lsp-config.ts	Adds LSP fixture input for override case.
apps/oxlint/fixtures/lsp/tsgolint/type_aware_config/.oxlintrc.json	Adds LSP root config enabling `options.typeAware`.
apps/oxlint/fixtures/lsp/tsgolint/nested_type_aware/test-root.ts	Adds LSP fixture input.
apps/oxlint/fixtures/lsp/tsgolint/nested_type_aware/nested/test.ts	Adds LSP nested fixture input.
apps/oxlint/fixtures/lsp/tsgolint/nested_type_aware/nested/.oxlintrc.json	Adds nested config that should be rejected for `options.typeAware`.
apps/oxlint/fixtures/lsp/tsgolint/nested_type_aware/.oxlintrc.json	Adds LSP root config for nested-type-aware rejection scenario.

crates/oxc_linter/src/config/mod.rs

camc314 · 2026-02-25T11:54:57Z

Merge activity

Feb 25, 11:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 25, 11:54 AM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 25, 12:02 PM UTC: Merged by the Graphite merge queue.

Closes oxc-project#15972. Adds `options.reportUnusedDisableDirectives` to `.oxlintrc.json`, following the same pattern as `typeAware` (oxc-project#19614) and `typeCheck` (oxc-project#19764). - Root-config-only (nested configs are rejected with a clear error) - CLI `--report-unused-disable-directives[-severity]` takes precedence over the config file value - Schema, TypeScript types, and website snapshots regenerated Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

# Oxlint ### 🚀 Features - 2e0e1d0 linter/no-unused-vars: Add experimental fix mode controls (off|suggestion|fix) (#19774) (camc314) - f34f6fa linter: Introduce typeCheck config option (#19764) (camc314) - 694be7d linter: Introduce typeAware as config options (#19614) (camc314) - 655c38f semantic: Add "did you mean?" suggestions to undefined name errors (#19102) (copilot-swe-agent) - e97a57e linter/id-length: Use serde to deserialize rule options (#19636) (camc314) - c4a3677 parser: Report error for initializer in ambient context (#19187) (camc314) - 346045a linter/id-length: Add `checkGeneric` option (#19634) (camc314) ### 🐛 Bug Fixes - 1b7a937 linter: Correct double-comparisons fix with swapped operands (#19846) (camc314) - c308857 linter/consistent_type_imports: Add missing help and notes to diagnostics (#19827) (Daniel Osmond) - 7682e5a linter/plugins: Decode escapes in identifier tokens (#19838) (overlookmotel) - f368fcd linter/consistent_type_assertions: Add missing with_help and with_note to diagnostics (#19826) (Daniel Osmond) - 04e6223 npm: Add `preferUnplugged` for Yarn PnP compatibility (#19829) (Boshen) - 86d5037 linter: Add help text to no-extend-native, no-useless-backreference (#19733) (Anthony Amaro) - 50e8eff linter: Add .with_help() to operator-assignment, no-nonoctal-decimal-escape (#19732) (Anthony Amaro) - 1417bdc linter/no-wrapper-object-types: Add help messages to missing diagnostics (#19771) (Daniel Osmond) - 0838477 linter/ban_ts_comment: Add help and notes to missing diagnostics (#19781) (Daniel Osmond) - e8c77cf linter/adjacent_overload_signatures: Add missing diagnostics (#19780) (Daniel Osmond) - 28834ac linter/ban_types: Add missing help and note to diagnostics (#19782) (Daniel Osmond) - fd938d3 linter/prefer-enum-initializers: Add help messages to missing diagnostics (#19772) (Daniel Osmond) - eb928ee linter/no-dynamic-delete: Add help messages to missing diagnostics (#19768) (Daniel Osmond) - a985666 linter/no-empty-interface: Add help messages to missing diagnostics (#19769) (Daniel Osmond) - 2dc0ceb linter/no-extra-non-null-assertion: Add help messages to missing diagnostics (#19770) (Daniel Osmond) - 95d5d66 linter/no-dupe-keys: Handle `__proto__` proto setters in (#19762) (camc314) - 24ff0db linter/exhaustive-deps: False positive for member expressions in IIFEs (#19751) (Dennis Chen) - 7243a58 linter/no-use-before-define: Honor `ignoreTypeReferences` when value and type name collisions (#19747) (Dimava) - eefd818 linter/explicit-module-boundary-types: Add help messages to missing diagnostics (#19736) (Daniel Osmond) - 0440e9a linter: Add help text to no_control_regex, no_fallthrough, no_param_reassign (#19655) (Anthony Amaro) - e84cb2f react/display-name: Handle merged type+value context symbols (#19608) (camc314) - ce7e253 linter/prefer-object-from-entries: Require exact path match in unicorn helper (#19687) (camc314) - f5694ce estree/tokens: Reverse field order of `regex` object in tokens (#19679) (overlookmotel) - b2b7a55 estree/tokens: Generate tokens for files with BOM (#19535) (overlookmotel) - 0722721 linter/jsx-curly-brace-presence: False positive with prop & mixed quotes (#19674) (camc314) - 3496acd linter: Enhance diagnostic help messages for eslint rules (#19653) (Anthony Amaro) - e384e94 linter: Enhance help diagnostic messages for more eslint rules (#19658) (Anthony Amaro) - a4d5b34 linter: Avoid non-promise catch false positives (#19574) (camc314) - 5706f38 linter: `unicorn/no-array-callback-reference` skip `Effect.*` array-like methods name. (#19633) (Said Atrahouch) ### ⚡ Performance - 05ccf9f linter/plugins: Transfer tokens via raw transfer (#19893) (overlookmotel) - 4b0611a estree/tokens: Introduce `ESTreeTokenConfig` trait (#19842) (overlookmotel) - ec88f6a estree/tokens: Serialize tokens while visiting AST (#19726) (overlookmotel) - d4dcf26 linter/plugins: Remove `typescript` from bundle (#19531) (overlookmotel) - 6a6513c linter/plugins: Use Oxc tokens in plugins (#19498) (camc314) ### 📚 Documentation - d86f59e linter: Improve docs for no-useless-concat, mark as pending fixer. (#19859) (connorshea) - caa091d linter/plugins: Correct doc comments for `initTokens` (#19530) (overlookmotel) - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) - dc0ff73 linter/no-useless-constructor: Warn for parameter properties as well (#19638) (Ole Asteo) # Oxfmt ### 🚀 Features - 5141bc2 formatter: Support trailing ignore comments (#19304) (Andreas Lubbe) - 4888a99 oxfmt/lsp: Support other schemes beside `file://` and `untitled://` (#19872) (Sysix) - 14a0181 oxfmt: Support `graphql()` variant for gql-in-js (#19703) (leaysgur) - ca68ea6 oxfmt: Support gql-in-js substitution (#19670) (leaysgur) - 035933c formatter,oxfmt: Support js-in-vue (partially) (#19514) (leaysgur) - 9e11dc6 parser,estree,coverage: Collect tokens in parser and convert to ESTree format (#19497) (camc314) ### 🐛 Bug Fixes - 8e3842d oxfmt: Avoid embedded TSFN crash by returning errors as data (take2) (#19806) (Yuji Sugiura) - 04e6223 npm: Add `preferUnplugged` for Yarn PnP compatibility (#19829) (Boshen) - e540585 oxfmt: Support tailwind sort for CSS/LESS/SCSS (#19803) (leaysgur) - 93bb861 formatter: Trim trailing whitespace before breaking line (#19740) (leaysgur) - b85f97b formatter: Drop blank line between terminal call and first chain member (#19659) (Dunqing) ### ⚡ Performance - b3b2d30 parser: Introduce `ParserConfig` (#19637) (overlookmotel) ### 📚 Documentation - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Closes oxc-project#15972. Adds `options.reportUnusedDisableDirectives` to `.oxlintrc.json`, following the same pattern as `typeAware` (oxc-project#19614) and `typeCheck` (oxc-project#19764). - Root-config-only (nested configs are rejected with a clear error) - CLI `--report-unused-disable-directives[-severity]` takes precedence over the config file value - Schema, TypeScript types, and website snapshots regenerated Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ile (#19799) See #15972. ## Summary - Adds `options.reportUnusedDisableDirectives` to `.oxlintrc.json`, following the same pattern as `typeAware` (#19614) and `typeCheck` (#19764) - Root-config-only — nested configs are rejected with a clear diagnostic error - CLI `--report-unused-disable-directives` / `--report-unused-disable-directives-severity` take precedence over the config file value when both are set - Schema (`npm/oxlint/configuration_schema.json`), TypeScript types (`config.generated.ts`), and website snapshots regenerated ## Test plan - [ ] Unit tests in `oxlintrc.rs`: deserialization, `is_empty`, `merge` - [ ] Unit tests in `config_store.rs`: accessor returns value / `None` by default - [ ] Unit tests in `config_loader.rs`: nested config rejection - [ ] Integration tests in `config_builder.rs`: `extends` inheritance and override precedence - [ ] `cargo test -p oxc_linter && cargo test -p oxlint` ## Note on AI usage This PR was implemented with Claude Code assistance and has been reviewed and tested by the contributor. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wagenet <9835+wagenet@users.noreply.github.com> Co-authored-by: Cameron Clark <cameron.clark@hey.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request labels Feb 21, 2026

camc314 force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch 6 times, most recently from 853f5a3 to bf890a9 Compare February 24, 2026 21:36

camc314 changed the base branch from main to graphite-base/19614 February 24, 2026 21:50

camc314 force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch from bf890a9 to 613f5b0 Compare February 24, 2026 21:50

camc314 changed the base branch from graphite-base/19614 to c/02-24-chore_oxlint_bump_min_tsgolint_version_to_0.15.0 February 24, 2026 21:50

This was referenced Feb 24, 2026

chore(deps): update dependency oxlint-tsgolint to v0.15.0 #19692

Merged

chore(oxlint): bump min tsgolint version to 0.15.0 #19693

Merged

graphite-app bot changed the base branch from c/02-24-chore_oxlint_bump_min_tsgolint_version_to_0.15.0 to graphite-base/19614 February 24, 2026 21:57

graphite-app bot force-pushed the graphite-base/19614 branch from 4862be1 to 7d7d0b0 Compare February 24, 2026 22:04

graphite-app bot force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch from 613f5b0 to cf5d8df Compare February 24, 2026 22:04

graphite-app bot changed the base branch from graphite-base/19614 to main February 24, 2026 22:04

graphite-app bot force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch from cf5d8df to 26c42b9 Compare February 24, 2026 22:05

camc314 marked this pull request as ready for review February 25, 2026 11:07

camc314 requested review from Sysix and overlookmotel as code owners February 25, 2026 11:07

Copilot AI review requested due to automatic review settings February 25, 2026 11:07

Copilot started reviewing on behalf of camc314 February 25, 2026 11:07 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

crates/oxc_linter/src/config/mod.rs Show resolved Hide resolved

camc314 self-assigned this Feb 25, 2026

camc314 force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch from 26c42b9 to 65ce812 Compare February 25, 2026 11:42

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 25, 2026

feat(linter): introduce typeAware as config options (#19614)

694be7d

graphite-app bot force-pushed the c/02-14-feat_linter_introduce_typeaware_as_config_options branch from 65ce812 to 694be7d Compare February 25, 2026 11:55

graphite-app bot merged commit 694be7d into main Feb 25, 2026
21 checks passed

graphite-app bot deleted the c/02-14-feat_linter_introduce_typeaware_as_config_options branch February 25, 2026 12:02

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 25, 2026

camc314 mentioned this pull request Feb 25, 2026

linter: Support more CLI flags via config file options #15972

Open

7 tasks

wagenet mentioned this pull request Feb 27, 2026

feat(linter): add options.reportUnusedDisableDirectives to config file #19799

Merged

5 tasks

connorshea mentioned this pull request Feb 27, 2026

feat: Add typeAware option to the generated config when relevant. oxc-project/oxlint-migrate#406

Merged

Sysix mentioned this pull request Mar 1, 2026

auto enable buildFromOxlintConfigFile typeAware when related option is found oxc-project/eslint-plugin-oxlint#644

Open

Boshen mentioned this pull request Mar 2, 2026

release(apps): oxlint v1.51.0 && oxfmt v0.36.0 #19912

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): introduce typeAware as config options#19614

feat(linter): introduce typeAware as config options#19614
graphite-app[bot] merged 1 commit intomainfrom
c/02-14-feat_linter_introduce_typeaware_as_config_options

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

Uh oh!

camc314 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camc314 commented Feb 25, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

camc314 commented Feb 25, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Feb 21, 2026 •

edited

Loading

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

camc314 commented Feb 25, 2026 •

edited by graphite-app bot

Loading