docs(linter/no-caller): Improve docs and diagnostic for rule. by connorshea · Pull Request #17890 · oxc-project/oxc

connorshea · 2026-01-11T20:22:58Z

Simple improvement. Also improved the tests slightly to remove unnecessary tuple usage, as the rule takes no config options.

Copilot

Pull request overview

This PR improves the documentation and diagnostic messages for the no-caller linter rule. The changes focus on better formatting, clearer messaging, and more consistent style without altering any functional behavior.

Changes:

Updated diagnostic and help messages to use backticks for identifiers and add periods for consistency
Improved documentation with better wording, consistent indentation, and an added MDN reference link
Simplified test cases by removing unnecessary None tuple values since the rule takes no configuration

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_linter/src/snapshots/eslint_no_caller.snap	Updated snapshot to reflect diagnostic message improvements (periods and backticks)
crates/oxc_linter/src/rules/eslint/no_caller.rs	Improved diagnostic messages, enhanced documentation with better wording and MDN link, fixed example indentation, and simplified test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2026-01-11T20:29:02Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing better-no-caller (6c23e29) with main (1e5ae93)}

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks¹

41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2026-01-11T21:13:21Z

Merge activity

Jan 11, 9:13 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 11, 9:13 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jan 11, 9:23 PM UTC: Merged by the Graphite merge queue.

Simple improvement. Also improved the tests slightly to remove unnecessary tuple usage, as the rule takes no config options.

# Oxlint ### 🚀 Features - 9699a1b linter/prefer-global-this: Add suggestion (#17873) (Mikhail Baev) - 51c2815 linter/no-invalid-regexp: Add labels and help text to flag diagnostics (#17865) (camchenry) - 344d77d linter/no-ex-assign: Improve diagnostic with more detail (#17864) (camchenry) - 7d280e0 linter: Add fixer for `unicorn/no-useless-error-capture-stack-trace` rule (#17839) (Mikhail Baev) - af1d0e3 linter/prefer-optional-chain: Add rule (#17831) (camc314) - e3c4108 vscode: Add more supported languages to extension (#17812) (Alexander Lichter) - 4a46678 vscode: Activate extension on more languages (#17717) (Sysix) - b1298fc vscode: Sync formatter with supported files (#17615) (Alexander Lichter) - c7f0848 linte/rno-required-prop-with-default: Implement suggestion (#17747) (Minsu Lee) - 0e8127e linter/vue: Implement no-lifecycle-after-await (#17701) (yefan) - 3567304 linter/vitest: Implement `consistent-each-for` (#17601) (Said Atrahouch) - 883e156 linter: Add fixer for `unicorn/no-useless-collection-argument` rule (#17594) (Mikhail Baev) - 4eb335c linter/vitest: Implemented prefer-called-once (#17674) (Said Atrahouch) - 2bd2d5a linter/vitest: Implement hoisted-apis-on-top (#17658) (Said Atrahouch) - cfb2bcc linter/vue: Implement no-arrow-functions-in-watch (#17672) (yefan) - a68208a linter/eslint-plugin-vitest: Implements `prefer-describe-function-title` (#17677) (Said Atrahouch) - efa029f linter/vitest: Implement no-unneeded-async-expect-function (#17494) (Minsu Lee) ### 🐛 Bug Fixes - 49cf66e lsp: Fix workspace worker selection for nested and similar-named workspaces (#17853) (Copilot) - 84f4f3c linter: Add doc url for tsgolint diagnostics (#17879) (Sysix) - 76c903f linter/consistent-indexed-object-style: Skip fixing default exported interface (#17874) (Copilot) - 7e87d16 linter/tabindex-no-positive: Improve diagnostic phrasing (#17849) (connorshea) - 28f9fba vscode: Fix nested search for binaries (#17832) (Sysix) - 8ca2cd2 linter: Move jsx-a11y/no-static-element-interactions rule to nursery. (#17818) (connorshea) - dc9fdd6 linter/consistent-indexed-object-style: Re-port test cases and fix some bugs (#17802) (camc314) - 7bbd880 linter: Update prefer-destructuring rule metadata (#17642) (Hamir Mahal) - 3c45185 linter/consistent-indexed-object-style: False positive with circular reference (#17789) (heygsc) - bd186b4 vscode: Search for `oxlint` and `oxfmt` in every workspace directory (#17760) (Sysix) - 3e0dff7 linter/no-hooks: Add punctuation to diagnostic message (#17751) (camc314) - 6ae21f9 linter/prefer-called-once: Avoid panic on trailing comma (#17735) (Said Atrahouch) - 32c3901 oxlint: Do not panic on invalid `no-unused-vars` configuration (#17719) (Sysix) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - f87a1e2 linter: Check for giving reserved plugin name before calling `load_plugin` on napi side (#17841) (Sysix) ### 📚 Documentation - a2b3a24 linter/no-caller: Improve docs and diagnostic for rule. (#17890) (connorshea) - aa48247 linter/no-unsafe-finally: Improve rule docs. (#17891) (connorshea) - 1b0bdee linter: Tweak docs for no-useless-constructor and hoisted-apis-on-top (#17888) (connorshea) - 8f24fa9 vscode: Remove mention of a built-in server (#17836) (Sysix) - e81a306 linter: Update the tsconfig flag mention for the import plugin. (#17778) (connorshea) # Oxfmt ### 🚀 Features - 539b350 formatter/sort_imports: Update `NODE_BUILTINS` modules (#17771) (nilptr) - 2e03ebf oxfmt/lsp: Use `SourceFormatter` to support non-JS files and napi features (#17655) (leaysgur) - 623f7eb oxfmt/sort_package_json: Use `options.sort_scripts` (#17740) (leaysgur) - 86c0168 oxfmt/sort_package_json: Handle `oxfmtrc.sort_scripts` option (#17738) (leaysgur) - 256636a oxfmt/lsp: Add `.editorconfig` to `get_watcher_patterns` (#17694) (leaysgur) - 3f3db39 oxfmt/lsp: Use `ConfigResolver` to align with CLI (#17654) (leaysgur) ### 🐛 Bug Fixes - fdd1e1e formatter: Don't wrap parenthesis for type assertion when it's an declaration of export default (#17878) (Dunqing) - f0813ad formatter: Incorrect type annotation check for short argument (#17877) (Dunqing) - 9e89389 formatter/tailwindcss: Nested class string doesn't respect `singleQuote: true` (#17838) (Dunqing) - e2f534c formatter/sort_imports: Handle alignable comment with JsLabels (#17791) (leaysgur) - f0cedd4 formatter/tailwindcss: Class name is broken after sorting when its contains single quotes with `singleQuote: true` (#17790) (Dunqing) - 1864142 oxfmt/tailwindcss: Bundle `prettier/plugins/*` (#17782) (leaysgur) - 3a9d43b oxfmt: Ignore explicit positional path which is ignored by directory (#17732) (leaysgur) - 0563217 formatter: Classes will be stripped out when both `experimentalTailwindcss` and `experimentalSortImports` are enabled (#17726) (Dunqing) ### ⚡ Performance - d1bc514 formatter: Optimize RegExpLiteral formatting to avoid heap allocations (#17797) (Dunqing) ### 📚 Documentation - 62b7a01 formatter: Clarify `experimentalTailwindcss` configuration comments (#17898) (Dunqing) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 11, 2026 20:22

connorshea requested a review from camc314 as a code owner January 11, 2026 20:22

github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Jan 11, 2026

Copilot started reviewing on behalf of connorshea January 11, 2026 20:23 View session

Copilot AI reviewed Jan 11, 2026

View reviewed changes

camc314 approved these changes Jan 11, 2026

View reviewed changes

camc314 self-assigned this Jan 11, 2026

camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026

docs(linter/no-caller): Improve docs and diagnostic for rule. (#17890)

a2b3a24

Simple improvement. Also improved the tests slightly to remove unnecessary tuple usage, as the rule takes no config options.

graphite-app bot force-pushed the better-no-caller branch from 6c23e29 to a2b3a24 Compare January 11, 2026 21:18

graphite-app bot merged commit a2b3a24 into main Jan 11, 2026
20 checks passed

graphite-app bot deleted the better-no-caller branch January 11, 2026 21:23

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026

Boshen mentioned this pull request Jan 12, 2026

release(apps): oxlint v1.39.0 && oxfmt v0.24.0 #17921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

docs(linter/no-caller): Improve docs and diagnostic for rule.#17890

docs(linter/no-caller): Improve docs and diagnostic for rule.#17890
graphite-app[bot] merged 1 commit intomainfrom
better-no-caller

connorshea commented Jan 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Jan 11, 2026

Uh oh!

camc314 commented Jan 11, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

connorshea commented Jan 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq bot commented Jan 11, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Jan 11, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Jan 11, 2026 •

edited by graphite-app bot

Loading