Skip to content

Comments

fix(linter/prefer-called-once): avoid panic on trailing comma#17735

Merged
camc314 merged 5 commits intooxc-project:mainfrom
Afsoon:fix-panic-prefer-called-once
Jan 7, 2026
Merged

fix(linter/prefer-called-once): avoid panic on trailing comma#17735
camc314 merged 5 commits intooxc-project:mainfrom
Afsoon:fix-panic-prefer-called-once

Conversation

@Afsoon
Copy link
Contributor

@Afsoon Afsoon commented Jan 7, 2026

Fix #17733

@Afsoon Afsoon requested a review from camc314 as a code owner January 7, 2026 05:35
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jan 7, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

Merging this PR will not alter performance

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1


Comparing Afsoon:fix-panic-prefer-called-once (c3b9bdb) with main (0e8127e)

Open in CodSpeed

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :) Jk I missed a typo

@connorshea connorshea self-requested a review January 7, 2026 05:57
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this was using source text checks that won't work in certain cases, so I've added a few test cases where this will fail to fix the code correctly.

(Technically I guess it shouldn't delete the code comments, so the tests I've added are arguably wrong, but I feel less strongly about keeping those)

---- rules::vitest::prefer_called_once::test stdout ----

thread 'rules::vitest::prefer_called_once::test' (12306774) panicked at crates/oxc_linter/src/fixer/mod.rs:395:13:
Linter fixer produced invalid syntax.

Input code: 
```
expect(window.HTMLElement.prototype.scrollIntoView).toHaveBeenCalledTimes(/* comment (because why not) */1,);
```

Fixed code: 
```
expect(window.HTMLElement.prototype.scrollIntoView).toHaveBeenCalledOnce(/* comment ();
```

Parse errors: [OxcDiagnostic { inner: OxcDiagnosticInner { message: "Unterminated multiline comment", labels: Some([LabeledSpan { label: None, span: SourceSpan { offset: SourceOffset(73), length: 14 }, primary: false }]), help: None, note: None, severity: Error, code: OxcCode { scope: None, number: None }, url: None } }]

I also added some tests to the other rules with similar fixers just to make sure this isn't a problem on those rules, you can ignore those.

@Afsoon
Copy link
Contributor Author

Afsoon commented Jan 7, 2026

I will convert this PR to draft, you are right with those assumptions. In this state, it doesn't solve the problem.

@Afsoon Afsoon marked this pull request as draft January 7, 2026 07:06
@camc314 camc314 changed the title fix(linter/eslint-plugin-vitest): Detect if the arguments have a trailing command and not panic while fix it fix(linter/prefer-called-once): detect if the arguments have a trailing command and not panic while fix it Jan 7, 2026
@Afsoon Afsoon marked this pull request as ready for review January 7, 2026 13:46
@connorshea connorshea changed the title fix(linter/prefer-called-once): detect if the arguments have a trailing command and not panic while fix it fix(linter/prefer-called-once): avoid panic on trailing comma Jan 7, 2026
@Afsoon
Copy link
Contributor Author

Afsoon commented Jan 7, 2026

I change how I handle the fix. Now instead of remove everything, I'm only removing the argument span and comma span. Or if it's okay to remove the comment, I can replace completly the modifiers and args.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there're still bugs here. I'm going to take a look

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314
Copy link
Contributor

camc314 commented Jan 7, 2026

there're still bugs here. I'm going to take a look

fixed by c3b9bdb

@camc314 camc314 self-assigned this Jan 7, 2026
@camc314 camc314 merged commit 6ae21f9 into oxc-project:main Jan 7, 2026
19 checks passed
Dunqing pushed a commit that referenced this pull request Jan 12, 2026
# Oxlint
### 🚀 Features

- 9699a1b linter/prefer-global-this: Add suggestion (#17873) (Mikhail
Baev)
- 51c2815 linter/no-invalid-regexp: Add labels and help text to flag
diagnostics (#17865) (camchenry)
- 344d77d linter/no-ex-assign: Improve diagnostic with more detail
(#17864) (camchenry)
- 7d280e0 linter: Add fixer for
`unicorn/no-useless-error-capture-stack-trace` rule (#17839) (Mikhail
Baev)
- af1d0e3 linter/prefer-optional-chain: Add rule (#17831) (camc314)
- e3c4108 vscode: Add more supported languages to extension (#17812)
(Alexander Lichter)
- 4a46678 vscode: Activate extension on more languages (#17717) (Sysix)
- b1298fc vscode: Sync formatter with supported files (#17615)
(Alexander Lichter)
- c7f0848 linte/rno-required-prop-with-default: Implement suggestion
(#17747) (Minsu Lee)
- 0e8127e linter/vue: Implement no-lifecycle-after-await (#17701)
(yefan)
- 3567304 linter/vitest: Implement `consistent-each-for` (#17601) (Said
Atrahouch)
- 883e156 linter: Add fixer for `unicorn/no-useless-collection-argument`
rule (#17594) (Mikhail Baev)
- 4eb335c linter/vitest: Implemented prefer-called-once (#17674) (Said
Atrahouch)
- 2bd2d5a linter/vitest: Implement hoisted-apis-on-top (#17658) (Said
Atrahouch)
- cfb2bcc linter/vue: Implement no-arrow-functions-in-watch (#17672)
(yefan)
- a68208a linter/eslint-plugin-vitest: Implements
`prefer-describe-function-title` (#17677) (Said Atrahouch)
- efa029f linter/vitest: Implement no-unneeded-async-expect-function
(#17494) (Minsu Lee)

### 🐛 Bug Fixes

- 49cf66e lsp: Fix workspace worker selection for nested and
similar-named workspaces (#17853) (Copilot)
- 84f4f3c linter: Add doc url for tsgolint diagnostics (#17879) (Sysix)
- 76c903f linter/consistent-indexed-object-style: Skip fixing default
exported interface (#17874) (Copilot)
- 7e87d16 linter/tabindex-no-positive: Improve diagnostic phrasing
(#17849) (connorshea)
- 28f9fba vscode: Fix nested search for binaries (#17832) (Sysix)
- 8ca2cd2 linter: Move jsx-a11y/no-static-element-interactions rule to
nursery. (#17818) (connorshea)
- dc9fdd6 linter/consistent-indexed-object-style: Re-port test cases and
fix some bugs (#17802) (camc314)
- 7bbd880 linter: Update prefer-destructuring rule metadata (#17642)
(Hamir Mahal)
- 3c45185 linter/consistent-indexed-object-style: False positive with
circular reference (#17789) (heygsc)
- bd186b4 vscode: Search for `oxlint` and `oxfmt` in every workspace
directory (#17760) (Sysix)
- 3e0dff7 linter/no-hooks: Add punctuation to diagnostic message
(#17751) (camc314)
- 6ae21f9 linter/prefer-called-once: Avoid panic on trailing comma
(#17735) (Said Atrahouch)
- 32c3901 oxlint: Do not panic on invalid `no-unused-vars` configuration
(#17719) (Sysix)
- 59a6228 parser: Detect TS1363 error for type-only imports with mixed
default and named/namespace bindings (#17712) (Copilot)

### ⚡ Performance

- f87a1e2 linter: Check for giving reserved plugin name before calling
`load_plugin` on napi side (#17841) (Sysix)

### 📚 Documentation

- a2b3a24 linter/no-caller: Improve docs and diagnostic for rule.
(#17890) (connorshea)
- aa48247 linter/no-unsafe-finally: Improve rule docs. (#17891)
(connorshea)
- 1b0bdee linter: Tweak docs for no-useless-constructor and
hoisted-apis-on-top (#17888) (connorshea)
- 8f24fa9 vscode: Remove mention of a built-in server (#17836) (Sysix)
- e81a306 linter: Update the tsconfig flag mention for the import
plugin. (#17778) (connorshea)
# Oxfmt
### 🚀 Features

- 539b350 formatter/sort_imports: Update `NODE_BUILTINS` modules
(#17771) (nilptr)
- 2e03ebf oxfmt/lsp: Use `SourceFormatter` to support non-JS files and
napi features (#17655) (leaysgur)
- 623f7eb oxfmt/sort_package_json: Use `options.sort_scripts` (#17740)
(leaysgur)
- 86c0168 oxfmt/sort_package_json: Handle `oxfmtrc.sort_scripts` option
(#17738) (leaysgur)
- 256636a oxfmt/lsp: Add `.editorconfig` to `get_watcher_patterns`
(#17694) (leaysgur)
- 3f3db39 oxfmt/lsp: Use `ConfigResolver` to align with CLI (#17654)
(leaysgur)

### 🐛 Bug Fixes

- fdd1e1e formatter: Don't wrap parenthesis for type assertion when it's
an declaration of export default (#17878) (Dunqing)
- f0813ad formatter: Incorrect type annotation check for short argument
(#17877) (Dunqing)
- 9e89389 formatter/tailwindcss: Nested class string doesn't respect
`singleQuote: true` (#17838) (Dunqing)
- e2f534c formatter/sort_imports: Handle alignable comment with JsLabels
(#17791) (leaysgur)
- f0cedd4 formatter/tailwindcss: Class name is broken after sorting when
its contains single quotes with `singleQuote: true` (#17790) (Dunqing)
- 1864142 oxfmt/tailwindcss: Bundle `prettier/plugins/*` (#17782)
(leaysgur)
- 3a9d43b oxfmt: Ignore explicit positional path which is ignored by
directory (#17732) (leaysgur)
- 0563217 formatter: Classes will be stripped out when both
`experimentalTailwindcss` and `experimentalSortImports` are enabled
(#17726) (Dunqing)

### ⚡ Performance

- d1bc514 formatter: Optimize RegExpLiteral formatting to avoid heap
allocations (#17797) (Dunqing)

### 📚 Documentation

- 62b7a01 formatter: Clarify `experimentalTailwindcss` configuration
comments (#17898) (Dunqing)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oxlint: vitest/prefer-called-once rule panic if arguments have a trailing comma

3 participants