fix(formatter): classes will be stripped out when both experimentalTailwindcss and experimentalSortImports are enabled

[Dunqing]

close: #17725

This is caused by our use of Document::from for sorted elements when experimentalSortImports is enabled. This method will use Vec::default() for sorted_tailwind_classes, which causes classes to be stripped.

In this PR,

I removed Document::from and used Document::new everywhere that needs to pass sorted_tailwind_classes explicitly, so that we can ensure it is passed correctly.

And for the experimentalSortImports, it will replace sorted elements directly instead of constructing a new Document, so that the sorted_tailwind_classes remains as is.

[Dunqing]

• fix(formatter): classes will be stripped out when both experimentalTailwindcss and experimentalSortImports are enabled #17726 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-07-fix_formatter_classes_will_be_stripped_out_when_both_experimentaltailwindcss_and_experimentalsortimports_are_enabled (7464b39) with main (3567304)}

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks¹

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a bug where Tailwind CSS classes were being stripped when both experimentalTailwindcss and experimentalSortImports options were enabled together. The root cause was that Document::from was using Vec::default() for the sorted_tailwind_classes field, causing the classes to be lost during import sorting.

Key Changes:

• Removed the From<ArenaVec> trait implementation for Document that was defaulting sorted_tailwind_classes to an empty vector
• Modified SortImportsTransform::transform to mutate the Formatted object in-place via a new replace_elements method, preserving the sorted_tailwind_classes
• Updated all Document::from usages to Document::new with explicit sorted_tailwind_classes parameter

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_formatter/src/formatter/format_element/document.rs	Removed From trait implementation and added replace_elements method to enable in-place element replacement
crates/oxc_formatter/src/ir_transform/sort_imports/mod.rs	Changed transform to take &mut Formatted and use replace_elements instead of creating a new Document
crates/oxc_formatter/src/lib.rs	Simplified transform invocation to unconditional call with early return inside
crates/oxc_formatter/src/write/template.rs	Updated to use Document::new with explicit empty Tailwind classes vector
crates/oxc_formatter/src/formatter/printer/mod.rs	Updated test code to use Document::new with explicit empty Tailwind classes vector
apps/oxfmt/test/tailwindcss.test.ts	Added test suite for the interaction between Tailwind sorting and import sorting

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[leaysgur]

Merge activity

• Jan 7, 1:24 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 7, 1:24 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Jan 7, 1:31 AM UTC: Merged by the Graphite merge queue.