feat(vscode): activate extension on more languages by Sysix · Pull Request #17717 · oxc-project/oxc

Sysix · 2026-01-06T15:27:51Z

Follow up from #17615

Activates the extension on the languages which are supported now by oxfmt

Sysix · 2026-01-06T15:28:08Z

feat(vscode): activate extension on more languages #17717 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

TheAlexLichter · 2026-01-06T22:25:02Z

On the long run we should enable it via * I guess?

Sysix · 2026-01-06T22:36:28Z

The docs suggest it as the last option:

Note: To ensure a great user experience, please use this activation event in your extension only when no other activation events combination works in your use-case.

https://code.visualstudio.com/api/references/activation-events#Start-up

nrayburn-tech · 2026-01-07T02:11:53Z

For what it's worth, ESLint and Prettier both use onStartupFinished as the only activation event. Likely due to the dynamic nature of which languages can be supported by those tools through custom parsers.

I don't know if oxfmt supports everything that Prettier does, but if it does then you may need to just use onStartupFinished as well.

TheAlexLichter · 2026-01-07T08:32:46Z

From what I've seen, the reason why prettier is doing it is that language support can be added through plugins.

editors/vscode/package.json

Sysix · 2026-01-08T18:13:13Z

Merge activity

Jan 8, 6:13 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 8, 6:13 PM UTC: Sysix added this pull request to the Graphite merge queue.
Jan 8, 6:18 PM UTC: Merged by the Graphite merge queue.

Follow up from #17615 Activates the extension on the languages which are supported now by `oxfmt`

Copilot

Pull request overview

This PR extends VSCode extension activation to support additional file types that oxfmt can format. Following up on PR #17615, the extension now activates for CSS, Handlebars, HTML, JSON, JSONC, Markdown, TOML, and YAML files, which are supported by oxfmt through its prettier integration and native TOML support.

Key Changes

Added 8 new language activation events in alphabetical order
Covers most file types supported by oxfmt via prettier (HTML, YAML, Markdown, CSS) and native formatters (TOML)
Maintains existing activation for JavaScript/TypeScript-based frameworks (astro, svelte, vue)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-08T18:18:00Z

editors/vscode/package.json

  "activationEvents": [
    "onLanguage:astro",
+    "onLanguage:css",
+    "onLanguage:handlebars",
+    "onLanguage:html",
    "onLanguage:javascript",
    "onLanguage:javascriptreact",
+    "onLanguage:json",
+    "onLanguage:jsonc",
+    "onLanguage:markdown",
    "onLanguage:svelte",
+    "onLanguage:toml",
    "onLanguage:typescript",
    "onLanguage:typescriptreact",
-    "onLanguage:vue"
+    "onLanguage:vue",
+    "onLanguage:yaml"


Additional supported languages are missing from activationEvents. Consider adding the following language activation events to match oxfmt's complete language support: "onLanguage:graphql" (after css), "onLanguage:less" (after jsonc), "onLanguage:mdx" (after markdown), and "onLanguage:scss" (after svelte). All these file types are supported by oxfmt through its prettier integration.

@copilot Create new PR for it,
Create after that for each new line a new comment to me, referencing the counterpart of editors/vscode/client/tools/formatter.ts

# Oxlint ### 🚀 Features - 9699a1b linter/prefer-global-this: Add suggestion (#17873) (Mikhail Baev) - 51c2815 linter/no-invalid-regexp: Add labels and help text to flag diagnostics (#17865) (camchenry) - 344d77d linter/no-ex-assign: Improve diagnostic with more detail (#17864) (camchenry) - 7d280e0 linter: Add fixer for `unicorn/no-useless-error-capture-stack-trace` rule (#17839) (Mikhail Baev) - af1d0e3 linter/prefer-optional-chain: Add rule (#17831) (camc314) - e3c4108 vscode: Add more supported languages to extension (#17812) (Alexander Lichter) - 4a46678 vscode: Activate extension on more languages (#17717) (Sysix) - b1298fc vscode: Sync formatter with supported files (#17615) (Alexander Lichter) - c7f0848 linte/rno-required-prop-with-default: Implement suggestion (#17747) (Minsu Lee) - 0e8127e linter/vue: Implement no-lifecycle-after-await (#17701) (yefan) - 3567304 linter/vitest: Implement `consistent-each-for` (#17601) (Said Atrahouch) - 883e156 linter: Add fixer for `unicorn/no-useless-collection-argument` rule (#17594) (Mikhail Baev) - 4eb335c linter/vitest: Implemented prefer-called-once (#17674) (Said Atrahouch) - 2bd2d5a linter/vitest: Implement hoisted-apis-on-top (#17658) (Said Atrahouch) - cfb2bcc linter/vue: Implement no-arrow-functions-in-watch (#17672) (yefan) - a68208a linter/eslint-plugin-vitest: Implements `prefer-describe-function-title` (#17677) (Said Atrahouch) - efa029f linter/vitest: Implement no-unneeded-async-expect-function (#17494) (Minsu Lee) ### 🐛 Bug Fixes - 49cf66e lsp: Fix workspace worker selection for nested and similar-named workspaces (#17853) (Copilot) - 84f4f3c linter: Add doc url for tsgolint diagnostics (#17879) (Sysix) - 76c903f linter/consistent-indexed-object-style: Skip fixing default exported interface (#17874) (Copilot) - 7e87d16 linter/tabindex-no-positive: Improve diagnostic phrasing (#17849) (connorshea) - 28f9fba vscode: Fix nested search for binaries (#17832) (Sysix) - 8ca2cd2 linter: Move jsx-a11y/no-static-element-interactions rule to nursery. (#17818) (connorshea) - dc9fdd6 linter/consistent-indexed-object-style: Re-port test cases and fix some bugs (#17802) (camc314) - 7bbd880 linter: Update prefer-destructuring rule metadata (#17642) (Hamir Mahal) - 3c45185 linter/consistent-indexed-object-style: False positive with circular reference (#17789) (heygsc) - bd186b4 vscode: Search for `oxlint` and `oxfmt` in every workspace directory (#17760) (Sysix) - 3e0dff7 linter/no-hooks: Add punctuation to diagnostic message (#17751) (camc314) - 6ae21f9 linter/prefer-called-once: Avoid panic on trailing comma (#17735) (Said Atrahouch) - 32c3901 oxlint: Do not panic on invalid `no-unused-vars` configuration (#17719) (Sysix) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - f87a1e2 linter: Check for giving reserved plugin name before calling `load_plugin` on napi side (#17841) (Sysix) ### 📚 Documentation - a2b3a24 linter/no-caller: Improve docs and diagnostic for rule. (#17890) (connorshea) - aa48247 linter/no-unsafe-finally: Improve rule docs. (#17891) (connorshea) - 1b0bdee linter: Tweak docs for no-useless-constructor and hoisted-apis-on-top (#17888) (connorshea) - 8f24fa9 vscode: Remove mention of a built-in server (#17836) (Sysix) - e81a306 linter: Update the tsconfig flag mention for the import plugin. (#17778) (connorshea) # Oxfmt ### 🚀 Features - 539b350 formatter/sort_imports: Update `NODE_BUILTINS` modules (#17771) (nilptr) - 2e03ebf oxfmt/lsp: Use `SourceFormatter` to support non-JS files and napi features (#17655) (leaysgur) - 623f7eb oxfmt/sort_package_json: Use `options.sort_scripts` (#17740) (leaysgur) - 86c0168 oxfmt/sort_package_json: Handle `oxfmtrc.sort_scripts` option (#17738) (leaysgur) - 256636a oxfmt/lsp: Add `.editorconfig` to `get_watcher_patterns` (#17694) (leaysgur) - 3f3db39 oxfmt/lsp: Use `ConfigResolver` to align with CLI (#17654) (leaysgur) ### 🐛 Bug Fixes - fdd1e1e formatter: Don't wrap parenthesis for type assertion when it's an declaration of export default (#17878) (Dunqing) - f0813ad formatter: Incorrect type annotation check for short argument (#17877) (Dunqing) - 9e89389 formatter/tailwindcss: Nested class string doesn't respect `singleQuote: true` (#17838) (Dunqing) - e2f534c formatter/sort_imports: Handle alignable comment with JsLabels (#17791) (leaysgur) - f0cedd4 formatter/tailwindcss: Class name is broken after sorting when its contains single quotes with `singleQuote: true` (#17790) (Dunqing) - 1864142 oxfmt/tailwindcss: Bundle `prettier/plugins/*` (#17782) (leaysgur) - 3a9d43b oxfmt: Ignore explicit positional path which is ignored by directory (#17732) (leaysgur) - 0563217 formatter: Classes will be stripped out when both `experimentalTailwindcss` and `experimentalSortImports` are enabled (#17726) (Dunqing) ### ⚡ Performance - d1bc514 formatter: Optimize RegExpLiteral formatting to avoid heap allocations (#17797) (Dunqing) ### 📚 Documentation - 62b7a01 formatter: Clarify `experimentalTailwindcss` configuration comments (#17898) (Dunqing) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Jan 6, 2026

leaysgur mentioned this pull request Jan 7, 2026

vscode: Support non-js files and full options #16729

Closed

2 tasks

TheAlexLichter reviewed Jan 7, 2026

View reviewed changes

editors/vscode/package.json Show resolved Hide resolved

Sysix force-pushed the 01-06-feat_vscode_activate_extension_on_more_languages branch from 7f9144c to 194f0c5 Compare January 7, 2026 19:23

Sysix marked this pull request as ready for review January 8, 2026 18:12

Sysix requested a review from camc314 as a code owner January 8, 2026 18:12

Copilot AI review requested due to automatic review settings January 8, 2026 18:12

Copilot started reviewing on behalf of Sysix January 8, 2026 18:12 View session

Sysix added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026

feat(vscode): activate extension on more languages (#17717)

4a46678

Follow up from #17615 Activates the extension on the languages which are supported now by `oxfmt`

graphite-app bot force-pushed the 01-06-feat_vscode_activate_extension_on_more_languages branch from 194f0c5 to 4a46678 Compare January 8, 2026 18:13

Copilot AI reviewed Jan 8, 2026

View reviewed changes

graphite-app bot merged commit 4a46678 into main Jan 8, 2026
19 checks passed

graphite-app bot deleted the 01-06-feat_vscode_activate_extension_on_more_languages branch January 8, 2026 18:18

Copilot AI mentioned this pull request Jan 8, 2026

Add missing language activation events for GraphQL, LESS, MDX, and SCSS #17811

Closed

12 tasks

Boshen mentioned this pull request Jan 12, 2026

release(apps): oxlint v1.39.0 && oxfmt v0.24.0 #17921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(vscode): activate extension on more languages#17717

feat(vscode): activate extension on more languages#17717
graphite-app[bot] merged 1 commit intomainfrom
01-06-feat_vscode_activate_extension_on_more_languages

Sysix commented Jan 6, 2026 •

edited

Loading

Uh oh!

Sysix commented Jan 6, 2026

Uh oh!

TheAlexLichter commented Jan 6, 2026

Uh oh!

Sysix commented Jan 6, 2026

Uh oh!

nrayburn-tech commented Jan 7, 2026

Uh oh!

TheAlexLichter commented Jan 7, 2026

Uh oh!

Uh oh!

Sysix commented Jan 8, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 8, 2026

Uh oh!

Sysix Jan 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

Sysix commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jan 6, 2026

How to use the Graphite Merge Queue

Uh oh!

TheAlexLichter commented Jan 6, 2026

Uh oh!

Sysix commented Jan 6, 2026

Uh oh!

nrayburn-tech commented Jan 7, 2026

Uh oh!

TheAlexLichter commented Jan 7, 2026

Uh oh!

Uh oh!

Sysix commented Jan 8, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Uh oh!

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Sysix Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jan 6, 2026 •

edited

Loading

Sysix commented Jan 8, 2026 •

edited by graphite-app bot

Loading