fix(formatter/tailwindcss): class name is broken after sorting when its contains single quotes with `singleQuote: true` by Dunqing · Pull Request #17790 · oxc-project/oxc

Dunqing · 2026-01-08T08:39:08Z

Dunqing · 2026-01-08T08:39:28Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-01-08T08:44:16Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-08-fix_formatter_tailwindcss_class_name_is_broken_when_its_contains_single_quotes_with_singlequote_true (5587f63) with main (5755b2d)¹}

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks²

No successful run was found on main (1736af5) during the generation of this report, so 5755b2d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This pull request fixes a bug where Tailwind CSS class names containing quotes (e.g., before:content-['hello']) were being incorrectly formatted after sorting when quote style options like singleQuote: true were enabled. The fix ensures that quote normalization respects the formatter's configuration while preserving nested quotes within the class content.

Key Changes:

Replaced manual quote extraction logic with the existing FormatLiteralStringToken::clean_text() utility to properly normalize quotes
Updated write_tailwind_string_literal() to accept the full TailwindContextEntry for proper context handling
Added Deref implementation to CleanedStringLiteralText for more ergonomic string operations

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
crates/oxc_formatter/src/write/mod.rs	Simplified call to `write_tailwind_string_literal` by passing full context instead of extracting quote style manually
crates/oxc_formatter/src/utils/tailwindcss.rs	Updated function to use normalized string quotes and accept full context; ensures closing quotes are written on all code paths
crates/oxc_formatter/src/utils/string.rs	Added `Deref` trait implementation for `CleanedStringLiteralText` to enable direct string operations
apps/oxfmt/test/tailwindcss.test.ts	Added comprehensive test coverage for quote handling with various formatter options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_formatter/src/utils/tailwindcss.rs

leaysgur

Feel free to merge first, after addressing 🤖 review.

(I will read through again tomorrow~)

Dunqing · 2026-01-08T09:33:53Z

Merge activity

Jan 8, 9:33 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 8, 9:33 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Jan 8, 9:40 AM UTC: Merged by the Graphite merge queue.

…ts contains single quotes with `singleQuote: true` (#17790) close: #17761

# Oxlint ### 🚀 Features - 9699a1b linter/prefer-global-this: Add suggestion (#17873) (Mikhail Baev) - 51c2815 linter/no-invalid-regexp: Add labels and help text to flag diagnostics (#17865) (camchenry) - 344d77d linter/no-ex-assign: Improve diagnostic with more detail (#17864) (camchenry) - 7d280e0 linter: Add fixer for `unicorn/no-useless-error-capture-stack-trace` rule (#17839) (Mikhail Baev) - af1d0e3 linter/prefer-optional-chain: Add rule (#17831) (camc314) - e3c4108 vscode: Add more supported languages to extension (#17812) (Alexander Lichter) - 4a46678 vscode: Activate extension on more languages (#17717) (Sysix) - b1298fc vscode: Sync formatter with supported files (#17615) (Alexander Lichter) - c7f0848 linte/rno-required-prop-with-default: Implement suggestion (#17747) (Minsu Lee) - 0e8127e linter/vue: Implement no-lifecycle-after-await (#17701) (yefan) - 3567304 linter/vitest: Implement `consistent-each-for` (#17601) (Said Atrahouch) - 883e156 linter: Add fixer for `unicorn/no-useless-collection-argument` rule (#17594) (Mikhail Baev) - 4eb335c linter/vitest: Implemented prefer-called-once (#17674) (Said Atrahouch) - 2bd2d5a linter/vitest: Implement hoisted-apis-on-top (#17658) (Said Atrahouch) - cfb2bcc linter/vue: Implement no-arrow-functions-in-watch (#17672) (yefan) - a68208a linter/eslint-plugin-vitest: Implements `prefer-describe-function-title` (#17677) (Said Atrahouch) - efa029f linter/vitest: Implement no-unneeded-async-expect-function (#17494) (Minsu Lee) ### 🐛 Bug Fixes - 49cf66e lsp: Fix workspace worker selection for nested and similar-named workspaces (#17853) (Copilot) - 84f4f3c linter: Add doc url for tsgolint diagnostics (#17879) (Sysix) - 76c903f linter/consistent-indexed-object-style: Skip fixing default exported interface (#17874) (Copilot) - 7e87d16 linter/tabindex-no-positive: Improve diagnostic phrasing (#17849) (connorshea) - 28f9fba vscode: Fix nested search for binaries (#17832) (Sysix) - 8ca2cd2 linter: Move jsx-a11y/no-static-element-interactions rule to nursery. (#17818) (connorshea) - dc9fdd6 linter/consistent-indexed-object-style: Re-port test cases and fix some bugs (#17802) (camc314) - 7bbd880 linter: Update prefer-destructuring rule metadata (#17642) (Hamir Mahal) - 3c45185 linter/consistent-indexed-object-style: False positive with circular reference (#17789) (heygsc) - bd186b4 vscode: Search for `oxlint` and `oxfmt` in every workspace directory (#17760) (Sysix) - 3e0dff7 linter/no-hooks: Add punctuation to diagnostic message (#17751) (camc314) - 6ae21f9 linter/prefer-called-once: Avoid panic on trailing comma (#17735) (Said Atrahouch) - 32c3901 oxlint: Do not panic on invalid `no-unused-vars` configuration (#17719) (Sysix) - 59a6228 parser: Detect TS1363 error for type-only imports with mixed default and named/namespace bindings (#17712) (Copilot) ### ⚡ Performance - f87a1e2 linter: Check for giving reserved plugin name before calling `load_plugin` on napi side (#17841) (Sysix) ### 📚 Documentation - a2b3a24 linter/no-caller: Improve docs and diagnostic for rule. (#17890) (connorshea) - aa48247 linter/no-unsafe-finally: Improve rule docs. (#17891) (connorshea) - 1b0bdee linter: Tweak docs for no-useless-constructor and hoisted-apis-on-top (#17888) (connorshea) - 8f24fa9 vscode: Remove mention of a built-in server (#17836) (Sysix) - e81a306 linter: Update the tsconfig flag mention for the import plugin. (#17778) (connorshea) # Oxfmt ### 🚀 Features - 539b350 formatter/sort_imports: Update `NODE_BUILTINS` modules (#17771) (nilptr) - 2e03ebf oxfmt/lsp: Use `SourceFormatter` to support non-JS files and napi features (#17655) (leaysgur) - 623f7eb oxfmt/sort_package_json: Use `options.sort_scripts` (#17740) (leaysgur) - 86c0168 oxfmt/sort_package_json: Handle `oxfmtrc.sort_scripts` option (#17738) (leaysgur) - 256636a oxfmt/lsp: Add `.editorconfig` to `get_watcher_patterns` (#17694) (leaysgur) - 3f3db39 oxfmt/lsp: Use `ConfigResolver` to align with CLI (#17654) (leaysgur) ### 🐛 Bug Fixes - fdd1e1e formatter: Don't wrap parenthesis for type assertion when it's an declaration of export default (#17878) (Dunqing) - f0813ad formatter: Incorrect type annotation check for short argument (#17877) (Dunqing) - 9e89389 formatter/tailwindcss: Nested class string doesn't respect `singleQuote: true` (#17838) (Dunqing) - e2f534c formatter/sort_imports: Handle alignable comment with JsLabels (#17791) (leaysgur) - f0cedd4 formatter/tailwindcss: Class name is broken after sorting when its contains single quotes with `singleQuote: true` (#17790) (Dunqing) - 1864142 oxfmt/tailwindcss: Bundle `prettier/plugins/*` (#17782) (leaysgur) - 3a9d43b oxfmt: Ignore explicit positional path which is ignored by directory (#17732) (leaysgur) - 0563217 formatter: Classes will be stripped out when both `experimentalTailwindcss` and `experimentalSortImports` are enabled (#17726) (Dunqing) ### ⚡ Performance - d1bc514 formatter: Optimize RegExpLiteral formatting to avoid heap allocations (#17797) (Dunqing) ### 📚 Documentation - 62b7a01 formatter: Clarify `experimentalTailwindcss` configuration comments (#17898) (Dunqing) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug labels Jan 8, 2026

Dunqing assigned leaysgur Jan 8, 2026

Dunqing requested a review from leaysgur January 8, 2026 09:00

Dunqing marked this pull request as ready for review January 8, 2026 09:00

Copilot AI review requested due to automatic review settings January 8, 2026 09:00

Copilot started reviewing on behalf of Dunqing January 8, 2026 09:00 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

crates/oxc_formatter/src/utils/tailwindcss.rs Show resolved Hide resolved

crates/oxc_formatter/src/utils/tailwindcss.rs Show resolved Hide resolved

crates/oxc_formatter/src/utils/tailwindcss.rs Show resolved Hide resolved

leaysgur approved these changes Jan 8, 2026

View reviewed changes

Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026

Dunqing force-pushed the 01-08-fix_formatter_tailwindcss_class_name_is_broken_when_its_contains_single_quotes_with_singlequote_true branch from 5587f63 to f367f77 Compare January 8, 2026 09:34

fix(formatter/tailwindcss): class name is broken after sorting when i…

f0cedd4

…ts contains single quotes with `singleQuote: true` (#17790) close: #17761

graphite-app bot force-pushed the 01-08-fix_formatter_tailwindcss_class_name_is_broken_when_its_contains_single_quotes_with_singlequote_true branch from f367f77 to f0cedd4 Compare January 8, 2026 09:34

graphite-app bot merged commit f0cedd4 into main Jan 8, 2026
20 checks passed

graphite-app bot deleted the 01-08-fix_formatter_tailwindcss_class_name_is_broken_when_its_contains_single_quotes_with_singlequote_true branch January 8, 2026 09:40

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 8, 2026

Boshen mentioned this pull request Jan 12, 2026

release(apps): oxlint v1.39.0 && oxfmt v0.24.0 #17921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(formatter/tailwindcss): class name is broken after sorting when its contains single quotes with `singleQuote: true`#17790

fix(formatter/tailwindcss): class name is broken after sorting when its contains single quotes with `singleQuote: true`#17790
graphite-app[bot] merged 1 commit intomainfrom
01-08-fix_formatter_tailwindcss_class_name_is_broken_when_its_contains_single_quotes_with_singlequote_true

Dunqing commented Jan 8, 2026 •

edited

Loading

Uh oh!

Dunqing commented Jan 8, 2026

Uh oh!

codspeed-hq bot commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Uh oh!

Dunqing commented Jan 8, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

Dunqing commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Jan 8, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Jan 8, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

leaysgur left a comment

Choose a reason for hiding this comment

Uh oh!

Dunqing commented Jan 8, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Jan 8, 2026 •

edited

Loading

Dunqing commented Jan 8, 2026 •

edited by graphite-app bot

Loading